| Message ID | 20241018-spi-nor-v1-1-d725bfb701ec@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | mtd: spi-nor: atmel: add at25sf321b entry | expand |
On 10/18/24 10:51 AM, Marcus Folkesson wrote: > Add entry for the at25sf321b 32Mbit SPI flash which is able to provide > SFDP information. then we could initialize the flash based on SFDP. If you don't need locking then probably you won't need a flash entry at all. See https://docs.kernel.org/driver-api/mtd/spi-nor.html > > Link: > https://www.renesas.com/en/document/dst/at25sf321b-datasheet?r=1608806 > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> > --- > drivers/mtd/spi-nor/atmel.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c > index 45d1153a04a07b7c61f46b117311b24ab695038f..e635559711a4b402d23d49da93efc15e6be571dd 100644 > --- a/drivers/mtd/spi-nor/atmel.c > +++ b/drivers/mtd/spi-nor/atmel.c > @@ -238,6 +238,12 @@ static const struct flash_info atmel_nor_parts[] = { > .flags = SPI_NOR_HAS_LOCK, > .no_sfdp_flags = SECT_4K, > .fixups = &at25fs_nor_fixups > + }, { > + .id = SNOR_ID(0x1f, 0x87, 0x01), > + .name = "at25sf321b", > + .size = SZ_4M, > + .flags = SPI_NOR_HAS_LOCK, > + .no_sfdp_flags = SECT_4K, > }, > }; > > > --- > base-commit: 200289db261f0c8131a5756133e9d30966289c3b > change-id: 20241018-spi-nor-dc29698dea0f > > Best regards,
Hi Tudor, On Tue, Oct 29, 2024 at 07:16:08AM +0000, Tudor Ambarus wrote: > > > On 10/18/24 10:51 AM, Marcus Folkesson wrote: > > Add entry for the at25sf321b 32Mbit SPI flash which is able to provide > > SFDP information. > > then we could initialize the flash based on SFDP. If you don't need > locking then probably you won't need a flash entry at all. See > https://docs.kernel.org/driver-api/mtd/spi-nor.html Hrmf. It seems like I have been looking into the wrong datasheet. The actual device is at25sf321, not at25s321b, where the former can not be identified using the SFDP table. At25sf321 and at25s321b uses the same JEDEC ID though, probably what got me wrong in the first place. Please see page 10 in https://www.renesas.cn/zh/document/apn/an201-adesto-32mbit-products-overview for further reading. I will send a v2 with updated details. Best regards, Marcus Folkesson
diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c index 45d1153a04a07b7c61f46b117311b24ab695038f..e635559711a4b402d23d49da93efc15e6be571dd 100644 --- a/drivers/mtd/spi-nor/atmel.c +++ b/drivers/mtd/spi-nor/atmel.c @@ -238,6 +238,12 @@ static const struct flash_info atmel_nor_parts[] = { .flags = SPI_NOR_HAS_LOCK, .no_sfdp_flags = SECT_4K, .fixups = &at25fs_nor_fixups + }, { + .id = SNOR_ID(0x1f, 0x87, 0x01), + .name = "at25sf321b", + .size = SZ_4M, + .flags = SPI_NOR_HAS_LOCK, + .no_sfdp_flags = SECT_4K, }, };
Add entry for the at25sf321b 32Mbit SPI flash which is able to provide SFDP information. Link: https://www.renesas.com/en/document/dst/at25sf321b-datasheet?r=1608806 Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> --- drivers/mtd/spi-nor/atmel.c | 6 ++++++ 1 file changed, 6 insertions(+) --- base-commit: 200289db261f0c8131a5756133e9d30966289c3b change-id: 20241018-spi-nor-dc29698dea0f Best regards,