| Message ID | 20241024061347.1771063-3-saravanak@google.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | A few minor fw_devlink fixes | expand |
On Wed, Oct 23, 2024 at 11:13:43PM -0700, Saravana Kannan wrote: > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you'll see error > messages like this when the supplier has probed and tries to make sure > all its fwnode consumers are linked to it using device links: > > tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with 1-0008 > > Reported-by: Jon Hunter <jonathanh@nvidia.com> > Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ > Tested-by: Jon Hunter <jonathanh@nvidia.com> > Suggested-by: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > drivers/phy/tegra/xusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding <treding@nvidia.com>
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index cfdb54b6070a..0a2096085971 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -543,7 +543,7 @@ static int tegra_xusb_port_init(struct tegra_xusb_port *port, device_initialize(&port->dev); port->dev.type = &tegra_xusb_port_type; - port->dev.of_node = of_node_get(np); + device_set_node(&port->dev, of_fwnode_handle(of_node_get(np))); port->dev.parent = padctl->dev; err = dev_set_name(&port->dev, "%s-%u", name, index);