| Message ID | ba31cf3a-af3d-4ff1-87a8-f05aaf8c780b@stanley.mountain |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [next] drm/tegra: Fix NULL vs IS_ERR() check in probe() | expand |
On 9/13/24 10:34 PM, Dan Carpenter wrote: > The iommu_paging_domain_alloc() function doesn't return NULL pointers, > it returns error pointers. Update the check to match. > > Fixes: 45c690aea8ee ("drm/tegra: Use iommu_paging_domain_alloc()") > Signed-off-by: Dan Carpenter<dan.carpenter@linaro.org> > --- > drivers/gpu/drm/tegra/drm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com> Thanks, baolu
On Fri, Sep 13, 2024 at 05:34:54PM +0300, Dan Carpenter wrote: > The iommu_paging_domain_alloc() function doesn't return NULL pointers, > it returns error pointers. Update the check to match. > > Fixes: 45c690aea8ee ("drm/tegra: Use iommu_paging_domain_alloc()") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/gpu/drm/tegra/drm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Thierry
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index c9eb329665ec..34d22ba210b0 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -1153,8 +1153,8 @@ static int host1x_drm_probe(struct host1x_device *dev) if (host1x_drm_wants_iommu(dev) && device_iommu_mapped(dma_dev)) { tegra->domain = iommu_paging_domain_alloc(dma_dev); - if (!tegra->domain) { - err = -ENOMEM; + if (IS_ERR(tegra->domain)) { + err = PTR_ERR(tegra->domain); goto free; }
The iommu_paging_domain_alloc() function doesn't return NULL pointers, it returns error pointers. Update the check to match. Fixes: 45c690aea8ee ("drm/tegra: Use iommu_paging_domain_alloc()") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/gpu/drm/tegra/drm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)