mbox series

[v4,0/3] pwm: Add pwm driver for Sophgo SG2042

Message ID cover.1729037302.git.unicorn_wang@outlook.com
Headers show
Series pwm: Add pwm driver for Sophgo SG2042 | expand

Message

Chen Wang Oct. 16, 2024, 12:19 a.m. UTC
From: Chen Wang <unicorn_wang@outlook.com>

Add driver for pwm controller of Sophgo SG2042 SoC.

Thanks,
Chen

---

Changes in v4:
  The patch series is based on v6.12-rc1.

  Updated driver to set property atomic of pwm_chip to true as per suggestion
  from Sean.

Changes in v3:
  The patch series is catched up with v6.12-rc1. You can simply review or test
  the patches at the link [3].

  Add patch #3 for dts part change.

Changes in v2:
  The patch series is based on v6.11-rc6. You can simply review or test the
  patches at the link [2].

  Fixed following issues as per comments from Yixun Lan, Krzysztof Kozlowski
  and Uwe Kleine-König, thanks.

  - Some minor issues in dt-bindings.
  - driver issues, use macros with name prefix for registers access; add
    limitations comments; fixed potential calculation overflow problem;
    add .get_state() callback and other miscellaneous code improvements.

Changes in v1:
  The patch series is based on v6.11-rc6. You can simply review or test the
  patches at the link [1].

Link: https://lore.kernel.org/linux-riscv/cover.1725536870.git.unicorn_wang@outlook.com/ [1]
Link: https://lore.kernel.org/linux-riscv/cover.1725931796.git.unicorn_wang@outlook.com/ [2]
Link: https://lore.kernel.org/linux-riscv/cover.1728355974.git.unicorn_wang@outlook.com/ [3]
---

Chen Wang (3):
  dt-bindings: pwm: sophgo: add PWM controller for SG2042
  pwm: sophgo: add driver for Sophgo SG2042 PWM
  riscv: sophgo: dts: add pwm controller for SG2042 SoC

 .../bindings/pwm/sophgo,sg2042-pwm.yaml       |  51 +++++
 arch/riscv/boot/dts/sophgo/sg2042.dtsi        |   8 +
 drivers/pwm/Kconfig                           |  10 +
 drivers/pwm/Makefile                          |   1 +
 drivers/pwm/pwm-sophgo-sg2042.c               | 181 ++++++++++++++++++
 5 files changed, 251 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml
 create mode 100644 drivers/pwm/pwm-sophgo-sg2042.c


base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc

Comments

Chen Wang Oct. 22, 2024, midnight UTC | #1
Hello, Uwe,

If it looks good to you, can you please apply the binding & driver part 
of this patchset for next v6.13?For dts part, I will handle it.

Thanks,

Chen

On 2024/10/16 8:19, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@outlook.com>
>
> Add driver for pwm controller of Sophgo SG2042 SoC.
>
> Thanks,
> Chen
>
> ---
>
> Changes in v4:
>    The patch series is based on v6.12-rc1.
>
>    Updated driver to set property atomic of pwm_chip to true as per suggestion
>    from Sean.
>
> Changes in v3:
>    The patch series is catched up with v6.12-rc1. You can simply review or test
>    the patches at the link [3].
>
>    Add patch #3 for dts part change.
>
> Changes in v2:
>    The patch series is based on v6.11-rc6. You can simply review or test the
>    patches at the link [2].
>
>    Fixed following issues as per comments from Yixun Lan, Krzysztof Kozlowski
>    and Uwe Kleine-König, thanks.
>
>    - Some minor issues in dt-bindings.
>    - driver issues, use macros with name prefix for registers access; add
>      limitations comments; fixed potential calculation overflow problem;
>      add .get_state() callback and other miscellaneous code improvements.
>
> Changes in v1:
>    The patch series is based on v6.11-rc6. You can simply review or test the
>    patches at the link [1].
>
> Link: https://lore.kernel.org/linux-riscv/cover.1725536870.git.unicorn_wang@outlook.com/ [1]
> Link: https://lore.kernel.org/linux-riscv/cover.1725931796.git.unicorn_wang@outlook.com/ [2]
> Link: https://lore.kernel.org/linux-riscv/cover.1728355974.git.unicorn_wang@outlook.com/ [3]
> ---
>
> Chen Wang (3):
>    dt-bindings: pwm: sophgo: add PWM controller for SG2042
>    pwm: sophgo: add driver for Sophgo SG2042 PWM
>    riscv: sophgo: dts: add pwm controller for SG2042 SoC
>
>   .../bindings/pwm/sophgo,sg2042-pwm.yaml       |  51 +++++
>   arch/riscv/boot/dts/sophgo/sg2042.dtsi        |   8 +
>   drivers/pwm/Kconfig                           |  10 +
>   drivers/pwm/Makefile                          |   1 +
>   drivers/pwm/pwm-sophgo-sg2042.c               | 181 ++++++++++++++++++
>   5 files changed, 251 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml
>   create mode 100644 drivers/pwm/pwm-sophgo-sg2042.c
>
>
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
Chen Wang Oct. 22, 2024, 12:53 p.m. UTC | #2
Adding another email address of Uwe.

Hi, Uwe, not sure if <u.kleine-koenig@baylibre.com>is another emailbox 
adderss of yours?


On 2024/10/22 8:00, Chen Wang wrote:
> Hello, Uwe,
>
> If it looks good to you, can you please apply the binding & driver 
> part of this patchset for next v6.13?For dts part, I will handle it.
>
> Thanks,
>
> Chen
>
> On 2024/10/16 8:19, Chen Wang wrote:
>> From: Chen Wang <unicorn_wang@outlook.com>
>>
>> Add driver for pwm controller of Sophgo SG2042 SoC.
>>
>> Thanks,
>> Chen
>>
>> ---
>>
>> Changes in v4:
>>    The patch series is based on v6.12-rc1.
>>
>>    Updated driver to set property atomic of pwm_chip to true as per 
>> suggestion
>>    from Sean.
>>
>> Changes in v3:
>>    The patch series is catched up with v6.12-rc1. You can simply 
>> review or test
>>    the patches at the link [3].
>>
>>    Add patch #3 for dts part change.
>>
>> Changes in v2:
>>    The patch series is based on v6.11-rc6. You can simply review or 
>> test the
>>    patches at the link [2].
>>
>>    Fixed following issues as per comments from Yixun Lan, Krzysztof 
>> Kozlowski
>>    and Uwe Kleine-König, thanks.
>>
>>    - Some minor issues in dt-bindings.
>>    - driver issues, use macros with name prefix for registers access; 
>> add
>>      limitations comments; fixed potential calculation overflow problem;
>>      add .get_state() callback and other miscellaneous code 
>> improvements.
>>
>> Changes in v1:
>>    The patch series is based on v6.11-rc6. You can simply review or 
>> test the
>>    patches at the link [1].
>>
>> Link: 
>> https://lore.kernel.org/linux-riscv/cover.1725536870.git.unicorn_wang@outlook.com/ 
>> [1]
>> Link: 
>> https://lore.kernel.org/linux-riscv/cover.1725931796.git.unicorn_wang@outlook.com/ 
>> [2]
>> Link: 
>> https://lore.kernel.org/linux-riscv/cover.1728355974.git.unicorn_wang@outlook.com/ 
>> [3]
>> ---
>>
>> Chen Wang (3):
>>    dt-bindings: pwm: sophgo: add PWM controller for SG2042
>>    pwm: sophgo: add driver for Sophgo SG2042 PWM
>>    riscv: sophgo: dts: add pwm controller for SG2042 SoC
>>
>>   .../bindings/pwm/sophgo,sg2042-pwm.yaml       |  51 +++++
>>   arch/riscv/boot/dts/sophgo/sg2042.dtsi        |   8 +
>>   drivers/pwm/Kconfig                           |  10 +
>>   drivers/pwm/Makefile                          |   1 +
>>   drivers/pwm/pwm-sophgo-sg2042.c               | 181 ++++++++++++++++++
>>   5 files changed, 251 insertions(+)
>>   create mode 100644 
>> Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml
>>   create mode 100644 drivers/pwm/pwm-sophgo-sg2042.c
>>
>>
>> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Uwe Kleine-König Oct. 22, 2024, 3:42 p.m. UTC | #3
Hello,

On Tue, Oct 22, 2024 at 08:53:42PM +0800, Chen Wang wrote:
> Adding another email address of Uwe.
> 
> Hi, Uwe, not sure if <u.kleine-koenig@baylibre.com>is another emailbox
> adderss of yours?
> 
> 
> On 2024/10/22 8:00, Chen Wang wrote:
> > If it looks good to you, can you please apply the binding & driver part
> > of this patchset for next v6.13?For dts part, I will handle it.

It's on my todo list, but not at the top. (See
https://patchwork.ozlabs.org/project/linux-pwm/list/ for a part of my
todo list that I usually tackle from old to new.)

So please have some more patience. And FTR: Both email addresses reach
me just fine.

Best regards
Uwe