mbox series

[SRU,N,0/1] Fail to locate the LED of NVME disk behind Intel VMD Edit

Message ID 20241018011546.53185-1-michael.reed@canonical.com
Headers show
Series Fail to locate the LED of NVME disk behind Intel VMD Edit | expand

Message

Michael Reed Oct. 18, 2024, 1:15 a.m. UTC
From: Michael Reed <Michael.Reed@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/2077287

SRU Justification:

[Impact]
Failed to locate the LED of nvme device behing Intel VMD via below command
   # ledctl locate=/dev/nvme0n1 or ledctl locate=/dev/nvme0n1 --listed-only

[Test Plan]

1. Fresh install of Ubuntu server 24.04 on the Server with Intel VMD
2. Upgrade the kernel to 6.8.0-40 and install the ledmon package
3. Locate the LED of nvme device behind Intel VMD with the following command:
   # ledctl locate=/dev/nvme0n1 or ledctl locate=/dev/nvme0n1 --listed-only

[Fix]
After checking the source code, Lenovo noticed it ran into the issue from the kernel commit abaaac4845a0d6f39f83cbaba4c3b46ba5f93170. This patch (5560a612c20d3daacbf5da7913deefa5c31742f4) which is now upstream resolves this issue.

[Where problems could occur]

[Other Info]

https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/noble/+ref/lp_2077287_locate_led_nvme

Blazej Kucman (1):
  PCI: pciehp: Retain Power Indicator bits for userspace indicators

 drivers/pci/hotplug/pciehp_hpc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Guoqing Jiang Oct. 18, 2024, 2:29 a.m. UTC | #1
Acked-by: Guoqing Jiang <guoqing.jiang@canonical.com>

On 10/18/24 09:15, Michael Reed wrote:
> From: Michael Reed <Michael.Reed@canonical.com>
>
> BugLink: https://bugs.launchpad.net/bugs/2077287
>
> SRU Justification:
>
> [Impact]
> Failed to locate the LED of nvme device behing Intel VMD via below command
>     # ledctl locate=/dev/nvme0n1 or ledctl locate=/dev/nvme0n1 --listed-only
>
> [Test Plan]
>
> 1. Fresh install of Ubuntu server 24.04 on the Server with Intel VMD
> 2. Upgrade the kernel to 6.8.0-40 and install the ledmon package
> 3. Locate the LED of nvme device behind Intel VMD with the following command:
>     # ledctl locate=/dev/nvme0n1 or ledctl locate=/dev/nvme0n1 --listed-only
>
> [Fix]
> After checking the source code, Lenovo noticed it ran into the issue from the kernel commit abaaac4845a0d6f39f83cbaba4c3b46ba5f93170. This patch (5560a612c20d3daacbf5da7913deefa5c31742f4) which is now upstream resolves this issue.
>
> [Where problems could occur]
>
> [Other Info]
>
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/noble/+ref/lp_2077287_locate_led_nvme
>
> Blazej Kucman (1):
>    PCI: pciehp: Retain Power Indicator bits for userspace indicators
>
>   drivers/pci/hotplug/pciehp_hpc.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
ivanhu Oct. 18, 2024, 3:07 a.m. UTC | #2
Acked-by: Ivan Hu <ivan.hu@canonical.com>

On 2024/10/18 09:15, Michael Reed wrote:
> From: Michael Reed <Michael.Reed@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2077287
> 
> SRU Justification:
> 
> [Impact]
> Failed to locate the LED of nvme device behing Intel VMD via below command
>     # ledctl locate=/dev/nvme0n1 or ledctl locate=/dev/nvme0n1 --listed-only
> 
> [Test Plan]
> 
> 1. Fresh install of Ubuntu server 24.04 on the Server with Intel VMD
> 2. Upgrade the kernel to 6.8.0-40 and install the ledmon package
> 3. Locate the LED of nvme device behind Intel VMD with the following command:
>     # ledctl locate=/dev/nvme0n1 or ledctl locate=/dev/nvme0n1 --listed-only
> 
> [Fix]
> After checking the source code, Lenovo noticed it ran into the issue from the kernel commit abaaac4845a0d6f39f83cbaba4c3b46ba5f93170. This patch (5560a612c20d3daacbf5da7913deefa5c31742f4) which is now upstream resolves this issue.
> 
> [Where problems could occur]
> 
> [Other Info]
> 
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/noble/+ref/lp_2077287_locate_led_nvme
> 
> Blazej Kucman (1):
>    PCI: pciehp: Retain Power Indicator bits for userspace indicators
> 
>   drivers/pci/hotplug/pciehp_hpc.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
Roxana Nicolescu Oct. 18, 2024, 1:59 p.m. UTC | #3
On 18/10/2024 03:15, Michael Reed wrote:
> From: Michael Reed <Michael.Reed@canonical.com>
>
> BugLink: https://bugs.launchpad.net/bugs/2077287
>
> SRU Justification:
>
> [Impact]
> Failed to locate the LED of nvme device behing Intel VMD via below command
>     # ledctl locate=/dev/nvme0n1 or ledctl locate=/dev/nvme0n1 --listed-only
>
> [Test Plan]
>
> 1. Fresh install of Ubuntu server 24.04 on the Server with Intel VMD
> 2. Upgrade the kernel to 6.8.0-40 and install the ledmon package
> 3. Locate the LED of nvme device behind Intel VMD with the following command:
>     # ledctl locate=/dev/nvme0n1 or ledctl locate=/dev/nvme0n1 --listed-only
>
> [Fix]
> After checking the source code, Lenovo noticed it ran into the issue from the kernel commit abaaac4845a0d6f39f83cbaba4c3b46ba5f93170. This patch (5560a612c20d3daacbf5da7913deefa5c31742f4) which is now upstream resolves this issue.
>
> [Where problems could occur]
>
> [Other Info]
>
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/noble/+ref/lp_2077287_locate_led_nvme
>
> Blazej Kucman (1):
>    PCI: pciehp: Retain Power Indicator bits for userspace indicators
>
>   drivers/pci/hotplug/pciehp_hpc.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
Already applied here 
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2083488