[v2,12/12] ARM: dts: imx6ul: Align pin config nodes with bindings

Bindings expect pin configuration nodes in pinctrl to match certain
naming and not be part of another fake node:

pinctrl@30330000: '...' does not match any of the regexes: 'grp$', 'pinctrl-[0-9]+'

Drop the wrapping node and adjust the names to have "grp" prefix.
Diff looks big but this should have no functional impact, use e.g.
git show -w to view the diff.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Jacky Bai <ping.bai@nxp.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-gpio@vger.kernel.org
---
V2: New patch
---
 arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Marek,

Am 17.10.24 um 02:06 schrieb Marek Vasut:
> Bindings expect pin configuration nodes in pinctrl to match certain
> naming and not be part of another fake node:
>
> pinctrl@30330000: '...' does not match any of the regexes: 'grp$', 'pinctrl-[0-9]+'
>
> Drop the wrapping node and adjust the names to have "grp" prefix.
> Diff looks big but this should have no functional impact, use e.g.
> git show -w to view the diff.
thanks for addressing the YAML conversion, but this specific commit
message doesn't seems to match the change?
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Dong Aisheng <aisheng.dong@nxp.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Jacky Bai <ping.bai@nxp.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-gpio@vger.kernel.org
> ---
> V2: New patch
> ---
>   arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi
> index 118df2a457c95..4c09bb3126966 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi
> @@ -322,7 +322,7 @@ MX6UL_PAD_JTAG_TRST_B__SAI2_TX_DATA	0x120b0
>   		>;
>   	};
>
> -	pinctrl_stmpe: stmpegrp  {
> +	pinctrl_stmpe: stmpegrp {
>   		fsl,pins = <
>   			MX6UL_PAD_UART1_CTS_B__GPIO1_IO18 0x1b0b0
>   		>;

On 10/17/24 2:14 PM, Stefan Wahren wrote:
> Hi Marek,
> 
> Am 17.10.24 um 02:06 schrieb Marek Vasut:
>> Bindings expect pin configuration nodes in pinctrl to match certain
>> naming and not be part of another fake node:
>>
>> pinctrl@30330000: '...' does not match any of the regexes: 'grp$', 
>> 'pinctrl-[0-9]+'
>>
>> Drop the wrapping node and adjust the names to have "grp" prefix.
>> Diff looks big but this should have no functional impact, use e.g.
>> git show -w to view the diff.
> thanks for addressing the YAML conversion, but this specific commit
> message doesn't seems to match the change?
Uh, right, commit message replaced in V3 (or shall I send this patch 
separately?)

Thanks!

Am 17.10.24 um 14:30 schrieb Marek Vasut:
> On 10/17/24 2:14 PM, Stefan Wahren wrote:
>> Hi Marek,
>>
>> Am 17.10.24 um 02:06 schrieb Marek Vasut:
>>> Bindings expect pin configuration nodes in pinctrl to match certain
>>> naming and not be part of another fake node:
>>>
>>> pinctrl@30330000: '...' does not match any of the regexes: 'grp$',
>>> 'pinctrl-[0-9]+'
>>>
>>> Drop the wrapping node and adjust the names to have "grp" prefix.
>>> Diff looks big but this should have no functional impact, use e.g.
>>> git show -w to view the diff.
>> thanks for addressing the YAML conversion, but this specific commit
>> message doesn't seems to match the change?
> Uh, right, commit message replaced in V3 (or shall I send this patch
> separately?)
I don't have a strong opinion about that. Luckily this is the last
patch, so in theory the rest could by applied if there are no other
findings.
>
> Thanks!

On 10/17/24 7:04 PM, Stefan Wahren wrote:
> Am 17.10.24 um 14:30 schrieb Marek Vasut:
>> On 10/17/24 2:14 PM, Stefan Wahren wrote:
>>> Hi Marek,
>>>
>>> Am 17.10.24 um 02:06 schrieb Marek Vasut:
>>>> Bindings expect pin configuration nodes in pinctrl to match certain
>>>> naming and not be part of another fake node:
>>>>
>>>> pinctrl@30330000: '...' does not match any of the regexes: 'grp$',
>>>> 'pinctrl-[0-9]+'
>>>>
>>>> Drop the wrapping node and adjust the names to have "grp" prefix.
>>>> Diff looks big but this should have no functional impact, use e.g.
>>>> git show -w to view the diff.
>>> thanks for addressing the YAML conversion, but this specific commit
>>> message doesn't seems to match the change?
>> Uh, right, commit message replaced in V3 (or shall I send this patch
>> separately?)
> I don't have a strong opinion about that. Luckily this is the last
> patch, so in theory the rest could by applied if there are no other
> findings.
I expect findings, so V3 is coming anyway, I'll just let it on the ML 
for a bit for those findings to pour in.

Thanks for keeping an eye on this !