| Message ID | 2cbf2268a63174294d0425e6593ea6adc8fc0950.1729083275.git.alx@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] contrib/: Configure git-format-patch(1) to add To: gcc-patches@gcc.gnu.org | expand |
On Wed, Oct 16, 2024 at 8:55 AM Alejandro Colomar <alx@kernel.org> wrote: > > Just like we already do for git-send-email(1). In some cases, patches > are prepared with git-format-patch(1), but are sent with a different > program, or some flags to git-send-email(1) may accidentally inhibit the > configuration. By adding the TO in the email file, we make sure that > gcc-patches@ will receive the patch. > > contrib/ChangeLog: > > * gcc-git-customization.sh: Configure git-format-patch(1) to add > 'To: gcc-patches@gcc.gnu.org'. > > Signed-off-by: Alejandro Colomar <alx@kernel.org> > --- > contrib/gcc-git-customization.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/contrib/gcc-git-customization.sh b/contrib/gcc-git-customization.sh > index 54bd35ea1aa..1cd1b4472f0 100755 > --- a/contrib/gcc-git-customization.sh > +++ b/contrib/gcc-git-customization.sh > @@ -43,6 +43,7 @@ git config diff.md.xfuncname '^\(define.*$' > > # Tell git send-email where patches go. I'd update this comment, too, while you're at it. > # ??? Maybe also set sendemail.tocmd to guess from MAINTAINERS? > +git config format.to 'gcc-patches@gcc.gnu.org' > git config sendemail.to 'gcc-patches@gcc.gnu.org' > > set_user=$(git config --get "user.name") > -- > 2.45.2 >
On Wed, Oct 16, 2024 at 03:41:00PM GMT, Eric Gallager wrote: > On Wed, Oct 16, 2024 at 8:55 AM Alejandro Colomar <alx@kernel.org> wrote: > > > > Just like we already do for git-send-email(1). In some cases, patches > > are prepared with git-format-patch(1), but are sent with a different > > program, or some flags to git-send-email(1) may accidentally inhibit the > > configuration. By adding the TO in the email file, we make sure that > > gcc-patches@ will receive the patch. > > > > contrib/ChangeLog: > > > > * gcc-git-customization.sh: Configure git-format-patch(1) to add > > 'To: gcc-patches@gcc.gnu.org'. > > > > Signed-off-by: Alejandro Colomar <alx@kernel.org> > > --- > > contrib/gcc-git-customization.sh | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/contrib/gcc-git-customization.sh b/contrib/gcc-git-customization.sh > > index 54bd35ea1aa..1cd1b4472f0 100755 > > --- a/contrib/gcc-git-customization.sh > > +++ b/contrib/gcc-git-customization.sh > > @@ -43,6 +43,7 @@ git config diff.md.xfuncname '^\(define.*$' > > > > # Tell git send-email where patches go. > > I'd update this comment, too, while you're at it. Ok, will do. I was wondering if it was worth touching the line. :) Have a lovely night! Alex > > > # ??? Maybe also set sendemail.tocmd to guess from MAINTAINERS? > > +git config format.to 'gcc-patches@gcc.gnu.org' > > git config sendemail.to 'gcc-patches@gcc.gnu.org' > > > > set_user=$(git config --get "user.name") > > -- > > 2.45.2 > >
diff --git a/contrib/gcc-git-customization.sh b/contrib/gcc-git-customization.sh index 54bd35ea1aa..1cd1b4472f0 100755 --- a/contrib/gcc-git-customization.sh +++ b/contrib/gcc-git-customization.sh @@ -43,6 +43,7 @@ git config diff.md.xfuncname '^\(define.*$' # Tell git send-email where patches go. # ??? Maybe also set sendemail.tocmd to guess from MAINTAINERS? +git config format.to 'gcc-patches@gcc.gnu.org' git config sendemail.to 'gcc-patches@gcc.gnu.org' set_user=$(git config --get "user.name")
Just like we already do for git-send-email(1). In some cases, patches are prepared with git-format-patch(1), but are sent with a different program, or some flags to git-send-email(1) may accidentally inhibit the configuration. By adding the TO in the email file, we make sure that gcc-patches@ will receive the patch. contrib/ChangeLog: * gcc-git-customization.sh: Configure git-format-patch(1) to add 'To: gcc-patches@gcc.gnu.org'. Signed-off-by: Alejandro Colomar <alx@kernel.org> --- contrib/gcc-git-customization.sh | 1 + 1 file changed, 1 insertion(+)