mbox series

[0/1,SRU,Orauclar] Support for RTL8126A rev.b

Message ID 20241015105112.1617202-1-vicamo.yang@canonical.com
Headers show
Series Support for RTL8126A rev.b | expand

Message

You-Sheng Yang Oct. 15, 2024, 10:51 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2079017

[Impact]

Need driver support for Realtek RTL8126A rev.b 5Gbps ethernet.

  $ lspci -vvnn
  ...
  81:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. Device [10ec:8126] (rev 01)
          Subsystem: Dell Device [1028:0d09]

[Fix]

* kernel:
  - v6.12-rc1 commit 69cb89981c7a ("r8169: add support for RTL8126A rev.b").
* firmware:
  - commit d75c2bd6f ("rtl_nic: add firmware rtl8126a-3")

[Test Case]

Ethernet link up and available.

  $ dmesg
  ...
  r8169 0000:81:00.0: can't disable ASPM; OS doesn't have ASPM control
  r8169 0000:81:00.0 eth0: RTL8126A, d0:46:0c:93:eb:e2, XID 64a, IRQ 139
  r8169 0000:81:00.0 eth0: jumbo features [frames: 9194 bytes, tx checksumming: ko]
  r8169 0000:81:00.0 enp129s0: renamed from eth0
  RTL8251B 5Gbps PHY r8169-0-8100:00: attached PHY driver (mii_bus:phy_addr=r8169-0-8100:00, irq=MAC)
  r8169 0000:81:00.0 enp129s0: Link is Up

[Where problems could occur]

New device. Expect further updates.

[Other Info]

Targets v6.11+ kernels. Nominate for linux/o, oem-6.11/n, linux-firmware/n.

ChunHao Lin (1):
  r8169: add support for RTL8126A rev.b

 drivers/net/ethernet/realtek/r8169.h          |  1 +
 drivers/net/ethernet/realtek/r8169_main.c     | 42 ++++++++++++-------
 .../net/ethernet/realtek/r8169_phy_config.c   |  1 +
 3 files changed, 29 insertions(+), 15 deletions(-)

Comments

Guoqing Jiang Oct. 16, 2024, 5:53 a.m. UTC | #1 
On 10/15/24 18:51, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2079017
>
> [Impact]
>
> Need driver support for Realtek RTL8126A rev.b 5Gbps ethernet.
>
>    $ lspci -vvnn
>    ...
>    81:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. Device [10ec:8126] (rev 01)
>            Subsystem: Dell Device [1028:0d09]
>
> [Fix]
>
> * kernel:
>    - v6.12-rc1 commit 69cb89981c7a ("r8169: add support for RTL8126A rev.b").

I suppose the below commit is needed as well.

commit 3b067536daa4842adbf685accf47c899a26367d3
Author: Heiner Kallweit <hkallweit1@gmail.com>
Date:   Wed Sep 18 20:45:15 2024 +0200

     r8169: add missing MODULE_FIRMWARE entry for RTL8126A rev.b

     Add a missing MODULE_FIRMWARE entry.

     Fixes: 69cb89981c7a ("r8169: add support for RTL8126A rev.b")
     Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
     Link: 
https://patch.msgid.link/bb307611-d129-43f5-a7ff-bdb6b4044fce@gmail.com
     Signed-off-by: Paolo Abeni <pabeni@redhat.com>

Thanks,
Guoqing

> * firmware:
>    - commit d75c2bd6f ("rtl_nic: add firmware rtl8126a-3")
>
> [Test Case]
>
> Ethernet link up and available.
>
>    $ dmesg
>    ...
>    r8169 0000:81:00.0: can't disable ASPM; OS doesn't have ASPM control
>    r8169 0000:81:00.0 eth0: RTL8126A, d0:46:0c:93:eb:e2, XID 64a, IRQ 139
>    r8169 0000:81:00.0 eth0: jumbo features [frames: 9194 bytes, tx checksumming: ko]
>    r8169 0000:81:00.0 enp129s0: renamed from eth0
>    RTL8251B 5Gbps PHY r8169-0-8100:00: attached PHY driver (mii_bus:phy_addr=r8169-0-8100:00, irq=MAC)
>    r8169 0000:81:00.0 enp129s0: Link is Up
>
> [Where problems could occur]
>
> New device. Expect further updates.
>
> [Other Info]
>
> Targets v6.11+ kernels. Nominate for linux/o, oem-6.11/n, linux-firmware/n.
>
> ChunHao Lin (1):
>    r8169: add support for RTL8126A rev.b
>
>   drivers/net/ethernet/realtek/r8169.h          |  1 +
>   drivers/net/ethernet/realtek/r8169_main.c     | 42 ++++++++++++-------
>   .../net/ethernet/realtek/r8169_phy_config.c   |  1 +
>   3 files changed, 29 insertions(+), 15 deletions(-)
>
You-Sheng Yang Oct. 16, 2024, 10:03 a.m. UTC | #2 
To add v6.12-rc1 commit 3b067536daa4 ("r8169: add missing
MODULE_FIRMWARE entry for RTL8126A rev.b") per review comment.

On Tue, Oct 15, 2024 at 6:52 PM You-Sheng Yang
<vicamo.yang@canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2079017
>
> [Impact]
>
> Need driver support for Realtek RTL8126A rev.b 5Gbps ethernet.
>
>   $ lspci -vvnn
>   ...
>   81:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. Device [10ec:8126] (rev 01)
>           Subsystem: Dell Device [1028:0d09]
>
> [Fix]
>
> * kernel:
>   - v6.12-rc1 commit 69cb89981c7a ("r8169: add support for RTL8126A rev.b").
> * firmware:
>   - commit d75c2bd6f ("rtl_nic: add firmware rtl8126a-3")
>
> [Test Case]
>
> Ethernet link up and available.
>
>   $ dmesg
>   ...
>   r8169 0000:81:00.0: can't disable ASPM; OS doesn't have ASPM control
>   r8169 0000:81:00.0 eth0: RTL8126A, d0:46:0c:93:eb:e2, XID 64a, IRQ 139
>   r8169 0000:81:00.0 eth0: jumbo features [frames: 9194 bytes, tx checksumming: ko]
>   r8169 0000:81:00.0 enp129s0: renamed from eth0
>   RTL8251B 5Gbps PHY r8169-0-8100:00: attached PHY driver (mii_bus:phy_addr=r8169-0-8100:00, irq=MAC)
>   r8169 0000:81:00.0 enp129s0: Link is Up
>
> [Where problems could occur]
>
> New device. Expect further updates.
>
> [Other Info]
>
> Targets v6.11+ kernels. Nominate for linux/o, oem-6.11/n, linux-firmware/n.
>
> ChunHao Lin (1):
>   r8169: add support for RTL8126A rev.b
>
>  drivers/net/ethernet/realtek/r8169.h          |  1 +
>  drivers/net/ethernet/realtek/r8169_main.c     | 42 ++++++++++++-------
>  .../net/ethernet/realtek/r8169_phy_config.c   |  1 +
>  3 files changed, 29 insertions(+), 15 deletions(-)
>
> --
> 2.45.2
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
ivanhu Oct. 17, 2024, 3:01 a.m. UTC | #3 
There is a follow-up commit,
     r8169: add missing MODULE_FIRMWARE entry for RTL8126A rev.b
     
     Add a missing MODULE_FIRMWARE entry.
     
     Fixes: 69cb89981c7a ("r8169: add support for RTL8126A rev.b")
which I think should also be applied.


On 2024/10/15 18:51, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2079017
> 
> [Impact]
> 
> Need driver support for Realtek RTL8126A rev.b 5Gbps ethernet.
> 
>    $ lspci -vvnn
>    ...
>    81:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. Device [10ec:8126] (rev 01)
>            Subsystem: Dell Device [1028:0d09]
> 
> [Fix]
> 
> * kernel:
>    - v6.12-rc1 commit 69cb89981c7a ("r8169: add support for RTL8126A rev.b").
> * firmware:
>    - commit d75c2bd6f ("rtl_nic: add firmware rtl8126a-3")
> 
> [Test Case]
> 
> Ethernet link up and available.
> 
>    $ dmesg
>    ...
>    r8169 0000:81:00.0: can't disable ASPM; OS doesn't have ASPM control
>    r8169 0000:81:00.0 eth0: RTL8126A, d0:46:0c:93:eb:e2, XID 64a, IRQ 139
>    r8169 0000:81:00.0 eth0: jumbo features [frames: 9194 bytes, tx checksumming: ko]
>    r8169 0000:81:00.0 enp129s0: renamed from eth0
>    RTL8251B 5Gbps PHY r8169-0-8100:00: attached PHY driver (mii_bus:phy_addr=r8169-0-8100:00, irq=MAC)
>    r8169 0000:81:00.0 enp129s0: Link is Up
> 
> [Where problems could occur]
> 
> New device. Expect further updates.
> 
> [Other Info]
> 
> Targets v6.11+ kernels. Nominate for linux/o, oem-6.11/n, linux-firmware/n.
> 
> ChunHao Lin (1):
>    r8169: add support for RTL8126A rev.b
> 
>   drivers/net/ethernet/realtek/r8169.h          |  1 +
>   drivers/net/ethernet/realtek/r8169_main.c     | 42 ++++++++++++-------
>   .../net/ethernet/realtek/r8169_phy_config.c   |  1 +
>   3 files changed, 29 insertions(+), 15 deletions(-)
>