mbox series

[v1,0/2] Add Exynos990 pinctrl and chipid drivers

Message ID 20241015063010.713407-1-igor.belwon@mentallysanemainliners.org
Headers show
Series Add Exynos990 pinctrl and chipid drivers | expand

Message

Igor Belwon Oct. 15, 2024, 6:30 a.m. UTC 
Hi folks,

This series adds support for the drivers for the Exynos 990 SoC. It
consists of the pinctrl driver and the chipid driver. The product ID
of this chip for chipid is 0xe9830000. The pinctrl bank types are the
same as in the Exynos 850 chip.

Kind regards,
Igor

Igor Belwon (2):
  soc: samsung: exynos-chipid: Add support for Exynos 990 chipid
  pinctrl: samsung: Add support for Exynos990 pinctrl

 .../pinctrl/samsung/pinctrl-exynos-arm64.c    | 140 ++++++++++++++++++
 drivers/pinctrl/samsung/pinctrl-samsung.c     |   2 +
 drivers/pinctrl/samsung/pinctrl-samsung.h     |   1 +
 drivers/soc/samsung/exynos-chipid.c           |   1 +
 4 files changed, 144 insertions(+)

Comments

Krzysztof Kozlowski Oct. 15, 2024, 7:05 a.m. UTC | #1 
On 15/10/2024 08:30, Igor Belwon wrote:
> Hi folks,
> 
> This series adds support for the drivers for the Exynos 990 SoC. It
> consists of the pinctrl driver and the chipid driver. The product ID
> of this chip for chipid is 0xe9830000. The pinctrl bank types are the
> same as in the Exynos 850 chip.

You split your patchsets in odd way. Bindings always go with driver.

Anyway, organize it per subsystem. Subsystem is:
1. SoC
2. pinctrl

So two patchsets targeting two subsystems.

Best regards,
Krzysztof