mbox series

[v2,iwl-next,0/4] Fix E825 initialization

Message ID 20241009140223.1918687-1-karol.kolacinski@intel.com
Headers show
Series Fix E825 initialization | expand

Message

Karol Kolacinski Oct. 9, 2024, 1:59 p.m. UTC
E825 products have incorrect initialization procedure, which may lead to
initialization failures and register values.

Fix E825 products initialization by adding correct sync delay, checking the
PHY
revision only for current PHY and adding proper destination device when
reading
port/quad.

In addition, E825 uses PF ID for indexing per PF registers and as a primary
PHY
lane number, which is incorrect.


Karol Kolacinski (4):
  ice: Fix E825 initialization
  ice: Fix quad registers read on E825
  ice: Fix ETH56G FC-FEC Rx offset value
  ice: Add correct PHY lane assignment

 drivers/net/ethernet/intel/ice/ice_common.c   |  42 ++-
 drivers/net/ethernet/intel/ice/ice_common.h   |   1 +
 drivers/net/ethernet/intel/ice/ice_main.c     |   6 +-
 drivers/net/ethernet/intel/ice/ice_ptp.c      |  23 +-
 drivers/net/ethernet/intel/ice/ice_ptp.h      |   4 +-
 .../net/ethernet/intel/ice/ice_ptp_consts.h   |  77 +----
 drivers/net/ethernet/intel/ice/ice_ptp_hw.c   | 285 +++++++++---------
 drivers/net/ethernet/intel/ice/ice_ptp_hw.h   |  40 ++-
 drivers/net/ethernet/intel/ice/ice_sbq_cmd.h  |   7 +-
 drivers/net/ethernet/intel/ice/ice_type.h     |   2 -
 10 files changed, 243 insertions(+), 244 deletions(-)

V1 -> V2: Removed net-next hunks from "ice: Fix E825 initialization",
          whole "ice: Remove unnecessary offset calculation for PF
          scoped registers" patch and fixed kdoc in "ice: Fix quad
          registers read on E825"

base-commit: af8cac359cecaab37a171039fc82cfd1f7aca501

Comments

Maciej Fijalkowski Oct. 9, 2024, 2:48 p.m. UTC | #1
> 
> E825 products have incorrect initialization procedure, which may lead to
> initialization failures and register values.
> 
> Fix E825 products initialization by adding correct sync delay, checking the
> PHY
> revision only for current PHY and adding proper destination device when
> reading
> port/quad.
> 
> In addition, E825 uses PF ID for indexing per PF registers and as a primary
> PHY
> lane number, which is incorrect.
> 
> 
> Karol Kolacinski (4):
>   ice: Fix E825 initialization
>   ice: Fix quad registers read on E825
>   ice: Fix ETH56G FC-FEC Rx offset value
>   ice: Add correct PHY lane assignment
> 
>  drivers/net/ethernet/intel/ice/ice_common.c   |  42 ++-
>  drivers/net/ethernet/intel/ice/ice_common.h   |   1 +
>  drivers/net/ethernet/intel/ice/ice_main.c     |   6 +-
>  drivers/net/ethernet/intel/ice/ice_ptp.c      |  23 +-
>  drivers/net/ethernet/intel/ice/ice_ptp.h      |   4 +-
>  .../net/ethernet/intel/ice/ice_ptp_consts.h   |  77 +----
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.c   | 285 +++++++++---------
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.h   |  40 ++-
>  drivers/net/ethernet/intel/ice/ice_sbq_cmd.h  |   7 +-
>  drivers/net/ethernet/intel/ice/ice_type.h     |   2 -
>  10 files changed, 243 insertions(+), 244 deletions(-)
> 
> V1 -> V2: Removed net-next hunks from "ice: Fix E825 initialization",
>           whole "ice: Remove unnecessary offset calculation for PF
>           scoped registers" patch and fixed kdoc in "ice: Fix quad
>           registers read on E825"

You forgot to s/next/net in patch subjects. This is supposed to
be routed via net tree AFAICS.

> 
> base-commit: af8cac359cecaab37a171039fc82cfd1f7aca501
> --
> 2.46.2
>
Paul Menzel Oct. 10, 2024, 7:43 a.m. UTC | #2
Dear Karol,


Am 09.10.24 um 15:59 schrieb Karol Kolacinski:
> E825 products have incorrect initialization procedure, which may lead to
> initialization failures and register values.
> 
> Fix E825 products initialization by adding correct sync delay, checking the
> PHY
> revision only for current PHY and adding proper destination device when
> reading
> port/quad.
> 
> In addition, E825 uses PF ID for indexing per PF registers and as a primary
> PHY
> lane number, which is incorrect.

Just a note, that the lines were additionally wrapped by some part in 
the processing queue.


Kind regards,

Paul