mbox series

[v3,0/3] pinctrl: th1520: Improve code quality

Message ID 20241008-th1520-pinctrl-fixes-v3-0-5b60db446a49@tenstorrent.com
Headers show
Series pinctrl: th1520: Improve code quality | expand

Message

Drew Fustini Oct. 9, 2024, 1:16 a.m. UTC 
This series contains code quality improvements for the new TH1520
pinctrl driver [1]:

 - Fix smatch warning that the return value is not correctly set when an
   unknown pin error occurs
 - Linus suggested using guarded mutexs so I've converted the thp->mutex
   lock to that usage.
 - Linus also suggested using a scoped iterator for the DT for-each
   child node loop: for_each_available_child_of_node_scoped.

The series is based on the linusw devel branch [2].

[1] https://lore.kernel.org/lkml/CACRpkdavPAv2sPRREQhx_A7EtOj6Ld_n+NcO+vH0QCnfVedXKw@mail.gmail.com/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel

Changes in v3:
 - Remove declaration of 'child' in th1520_pinctrl_dt_node_to_map() as
   the macro for_each_available_child_of_node_scoped already includes the
   declaration of 'child'.
 - Link to v2: https://lore.kernel.org/r/20241006-th1520-pinctrl-fixes-v2-0-b1822ae3a6d7@tenstorrent.com

Changes in v2:
 - Move the scoped iterator conversion to a separate patch and remove the
   child put operations as they are no longer needed
 - Link to v1: https://lore.kernel.org/lkml/20241005-th1520-pinctrl-fixes-v1-0-5c65dffa0d00@tenstorrent.com/

---
Drew Fustini (3):
      pinctrl: th1520: Fix return value for unknown pin error
      pinctrl: th1520: Convert thp->mutex to guarded mutex
      pinctrl: th1520: Convert dt child node loop to scoped iterator

 drivers/pinctrl/pinctrl-th1520.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)
---
base-commit: 2694868880705e8f6bb61b24b1b25adc42a4a217
change-id: 20241005-th1520-pinctrl-fixes-d20db68387e6

Best regards,

Comments

Linus Walleij Oct. 9, 2024, 12:42 p.m. UTC | #1 
On Wed, Oct 9, 2024 at 3:17 AM Drew Fustini <dfustini@tenstorrent.com> wrote:

> This series contains code quality improvements for the new TH1520
> pinctrl driver [1]:
>
>  - Fix smatch warning that the return value is not correctly set when an
>    unknown pin error occurs
>  - Linus suggested using guarded mutexs so I've converted the thp->mutex
>    lock to that usage.
>  - Linus also suggested using a scoped iterator for the DT for-each
>    child node loop: for_each_available_child_of_node_scoped.
>
> The series is based on the linusw devel branch [2].

Thanks Drew all three patches applied, excellent work as usual!

Yours,
Linus Walleij