| Message ID | 9715605c232ce38a36a200204c14208b9d76cd83.1727694230.git.michal.simek@amd.com |
|---|---|
| State | Accepted |
| Commit | f346dd67d047ad19f076d901dcc5295a2eb0cdde |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | [1/2] arm64: versal: Remove description for USB1 | expand |
On 9/30/24 13:03, Michal Simek wrote: > For unknown reason USB host hasn't been described for distro boot that's > why wire it now. > > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- > > include/configs/xilinx_versal.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/configs/xilinx_versal.h b/include/configs/xilinx_versal.h > index 212dc9df2a2e..64f123424cf7 100644 > --- a/include/configs/xilinx_versal.h > +++ b/include/configs/xilinx_versal.h > @@ -48,6 +48,12 @@ > # define BOOT_TARGET_DEVICES_MMC(func) > #endif > > +#if defined(CONFIG_USB_STORAGE) > +# define BOOT_TARGET_DEVICES_USB(func) func(USB, usb, 0) > +#else > +# define BOOT_TARGET_DEVICES_USB(func) > +#endif > + > #if defined(CONFIG_CMD_PXE) && defined(CONFIG_CMD_DHCP) > # define BOOT_TARGET_DEVICES_PXE(func) func(PXE, pxe, na) > #else > @@ -118,6 +124,7 @@ > BOOT_TARGET_DEVICES_XSPI(func) \ > BOOT_TARGET_DEVICES_USB_DFU(func) \ > BOOT_TARGET_DEVICES_USB_THOR(func) \ > + BOOT_TARGET_DEVICES_USB(func) \ > BOOT_TARGET_DEVICES_PXE(func) \ > BOOT_TARGET_DEVICES_DHCP(func) > Applied. M
Hi Michal, On Mon, 30 Sept 2024 at 05:05, Michal Simek <michal.simek@amd.com> wrote: > > For unknown reason USB host hasn't been described for distro boot that's > why wire it now. > > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- > > include/configs/xilinx_versal.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/configs/xilinx_versal.h b/include/configs/xilinx_versal.h > index 212dc9df2a2e..64f123424cf7 100644 > --- a/include/configs/xilinx_versal.h > +++ b/include/configs/xilinx_versal.h > @@ -48,6 +48,12 @@ > # define BOOT_TARGET_DEVICES_MMC(func) > #endif > > +#if defined(CONFIG_USB_STORAGE) > +# define BOOT_TARGET_DEVICES_USB(func) func(USB, usb, 0) > +#else > +# define BOOT_TARGET_DEVICES_USB(func) > +#endif > + > #if defined(CONFIG_CMD_PXE) && defined(CONFIG_CMD_DHCP) > # define BOOT_TARGET_DEVICES_PXE(func) func(PXE, pxe, na) > #else > @@ -118,6 +124,7 @@ > BOOT_TARGET_DEVICES_XSPI(func) \ > BOOT_TARGET_DEVICES_USB_DFU(func) \ > BOOT_TARGET_DEVICES_USB_THOR(func) \ > + BOOT_TARGET_DEVICES_USB(func) \ > BOOT_TARGET_DEVICES_PXE(func) \ > BOOT_TARGET_DEVICES_DHCP(func) > > -- > 2.43.0 > I wonder if these could move to boostd? It would require implementing something for dfu and thor, though. Regards, Simon
On 10/9/24 03:56, Simon Glass wrote: > Hi Michal, > > On Mon, 30 Sept 2024 at 05:05, Michal Simek <michal.simek@amd.com> wrote: >> >> For unknown reason USB host hasn't been described for distro boot that's >> why wire it now. >> >> Signed-off-by: Michal Simek <michal.simek@amd.com> >> --- >> >> include/configs/xilinx_versal.h | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/include/configs/xilinx_versal.h b/include/configs/xilinx_versal.h >> index 212dc9df2a2e..64f123424cf7 100644 >> --- a/include/configs/xilinx_versal.h >> +++ b/include/configs/xilinx_versal.h >> @@ -48,6 +48,12 @@ >> # define BOOT_TARGET_DEVICES_MMC(func) >> #endif >> >> +#if defined(CONFIG_USB_STORAGE) >> +# define BOOT_TARGET_DEVICES_USB(func) func(USB, usb, 0) >> +#else >> +# define BOOT_TARGET_DEVICES_USB(func) >> +#endif >> + >> #if defined(CONFIG_CMD_PXE) && defined(CONFIG_CMD_DHCP) >> # define BOOT_TARGET_DEVICES_PXE(func) func(PXE, pxe, na) >> #else >> @@ -118,6 +124,7 @@ >> BOOT_TARGET_DEVICES_XSPI(func) \ >> BOOT_TARGET_DEVICES_USB_DFU(func) \ >> BOOT_TARGET_DEVICES_USB_THOR(func) \ >> + BOOT_TARGET_DEVICES_USB(func) \ >> BOOT_TARGET_DEVICES_PXE(func) \ >> BOOT_TARGET_DEVICES_DHCP(func) >> >> -- >> 2.43.0 >> > > I wonder if these could move to boostd? It would require implementing > something for dfu and thor, though. I will get to it in near future. M
diff --git a/include/configs/xilinx_versal.h b/include/configs/xilinx_versal.h index 212dc9df2a2e..64f123424cf7 100644 --- a/include/configs/xilinx_versal.h +++ b/include/configs/xilinx_versal.h @@ -48,6 +48,12 @@ # define BOOT_TARGET_DEVICES_MMC(func) #endif +#if defined(CONFIG_USB_STORAGE) +# define BOOT_TARGET_DEVICES_USB(func) func(USB, usb, 0) +#else +# define BOOT_TARGET_DEVICES_USB(func) +#endif + #if defined(CONFIG_CMD_PXE) && defined(CONFIG_CMD_DHCP) # define BOOT_TARGET_DEVICES_PXE(func) func(PXE, pxe, na) #else @@ -118,6 +124,7 @@ BOOT_TARGET_DEVICES_XSPI(func) \ BOOT_TARGET_DEVICES_USB_DFU(func) \ BOOT_TARGET_DEVICES_USB_THOR(func) \ + BOOT_TARGET_DEVICES_USB(func) \ BOOT_TARGET_DEVICES_PXE(func) \ BOOT_TARGET_DEVICES_DHCP(func)
For unknown reason USB host hasn't been described for distro boot that's why wire it now. Signed-off-by: Michal Simek <michal.simek@amd.com> --- include/configs/xilinx_versal.h | 7 +++++++ 1 file changed, 7 insertions(+)