mbox series

[0/1,SRU,O] Add Intel Arrow Lake-H LPSS PCI IDs

Message ID 20241008075144.1533505-1-acelan.kao@canonical.com
Headers show
Series Add Intel Arrow Lake-H LPSS PCI IDs | expand

Message

AceLan Kao Oct. 8, 2024, 7:51 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2083905

[Impact]
ARL-H system can't enter lower state

[Fix]
The commit in v6.12-rc1 is needed
6112597f5ba8 mfd: intel-lpss: Add Intel Arrow Lake-H LPSS PCI IDs

[Test]
Run `lspci -nnk` on ARL-H platform and the communcation controller should use the driver 'intel-lpss'
0000:00:1e.0 Communication controller [0780]: Intel Corporation Device [8086:7725]
        Subsystem: Dell Device [1028:0cf5]
        Kernel driver in use: intel-lpss
        Kernel modules: intel_lpss_pci

[Where problems could occur]
Low, it adds ARL-H IDs to the table.

Ilpo Järvinen (1):
  mfd: intel-lpss: Add Intel Arrow Lake-H LPSS PCI IDs

 drivers/mfd/intel-lpss-pci.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Guoqing Jiang Oct. 9, 2024, 1:45 a.m. UTC | #1
Acked-by: Guoqing Jiang <guoqing.jiang@canonical.com>

On 10/8/24 15:51, Chia-Lin Kao (AceLan) wrote:
> BugLink: https://bugs.launchpad.net/bugs/2083905
>
> [Impact]
> ARL-H system can't enter lower state
>
> [Fix]
> The commit in v6.12-rc1 is needed
> 6112597f5ba8 mfd: intel-lpss: Add Intel Arrow Lake-H LPSS PCI IDs
>
> [Test]
> Run `lspci -nnk` on ARL-H platform and the communcation controller should use the driver 'intel-lpss'
> 0000:00:1e.0 Communication controller [0780]: Intel Corporation Device [8086:7725]
>          Subsystem: Dell Device [1028:0cf5]
>          Kernel driver in use: intel-lpss
>          Kernel modules: intel_lpss_pci
>
> [Where problems could occur]
> Low, it adds ARL-H IDs to the table.
>
> Ilpo Järvinen (1):
>    mfd: intel-lpss: Add Intel Arrow Lake-H LPSS PCI IDs
>
>   drivers/mfd/intel-lpss-pci.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
ivanhu Oct. 9, 2024, 3:52 a.m. UTC | #2
Acked-by: Ivan Hu <ivan.hu@canonical.com>

On 10/8/24 15:51, Chia-Lin Kao (AceLan) wrote:
> BugLink: https://bugs.launchpad.net/bugs/2083905
> 
> [Impact]
> ARL-H system can't enter lower state
> 
> [Fix]
> The commit in v6.12-rc1 is needed
> 6112597f5ba8 mfd: intel-lpss: Add Intel Arrow Lake-H LPSS PCI IDs
> 
> [Test]
> Run `lspci -nnk` on ARL-H platform and the communcation controller should use the driver 'intel-lpss'
> 0000:00:1e.0 Communication controller [0780]: Intel Corporation Device [8086:7725]
>          Subsystem: Dell Device [1028:0cf5]
>          Kernel driver in use: intel-lpss
>          Kernel modules: intel_lpss_pci
> 
> [Where problems could occur]
> Low, it adds ARL-H IDs to the table.
> 
> Ilpo Järvinen (1):
>    mfd: intel-lpss: Add Intel Arrow Lake-H LPSS PCI IDs
> 
>   drivers/mfd/intel-lpss-pci.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
Stefan Bader Oct. 11, 2024, 1:46 p.m. UTC | #3
On 08.10.24 09:51, Chia-Lin Kao (AceLan) wrote:
> BugLink: https://bugs.launchpad.net/bugs/2083905
> 
> [Impact]
> ARL-H system can't enter lower state
> 
> [Fix]
> The commit in v6.12-rc1 is needed
> 6112597f5ba8 mfd: intel-lpss: Add Intel Arrow Lake-H LPSS PCI IDs
> 
> [Test]
> Run `lspci -nnk` on ARL-H platform and the communcation controller should use the driver 'intel-lpss'
> 0000:00:1e.0 Communication controller [0780]: Intel Corporation Device [8086:7725]
>          Subsystem: Dell Device [1028:0cf5]
>          Kernel driver in use: intel-lpss
>          Kernel modules: intel_lpss_pci
> 
> [Where problems could occur]
> Low, it adds ARL-H IDs to the table.
> 
> Ilpo Järvinen (1):
>    mfd: intel-lpss: Add Intel Arrow Lake-H LPSS PCI IDs
> 
>   drivers/mfd/intel-lpss-pci.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
@@ -424,6 +424,19 @@ static const struct pci_device_id 
intel_lpss_pci_ids[] = {
         { PCI_VDEVICE(INTEL, 0x5ac4), (kernel_ulong_t)&bxt_info },
         { PCI_VDEVICE(INTEL, 0x5ac6), (kernel_ulong_t)&bxt_info },

The two lines above have "(kernel_ulong_t)&bxt_info" in the current 
oracular code base instead of the "(kernel_ulong_t)&bxt_spi_info" in the 
patch you submitted. Could you double check whether that is ok or 
indicates something missing?

         { PCI_VDEVICE(INTEL, 0x5aee), (kernel_ulong_t)&bxt_uart_info },
+       /* ARL-H */
+       { PCI_VDEVICE(INTEL, 0x7725), (kernel_ulong_t)&bxt_uart_info },

The additional ARL-H lines have been applied with fuzz#2 to 
oracular:linux. Thanks.