| Message ID | 20241007155425.28710-2-pvalerio@redhat.com |
|---|---|
| State | Accepted |
| Commit | 44599183868f111d80e34b07fa69b66775df6aff |
| Delegated to: | aaron conole |
| Headers | show |
| Series | [ovs-dev,v4,1/2] system-traffic: Do not rely on conncount for already tracked packets. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On Mon, Oct 07, 2024 at 05:54:25PM +0200, Paolo Valerio wrote: > Currently, at every call of IPTABLES_ACCEPT() an iptables rule gets > added. Such rule is supposed to be removed on exit, but the current > syntax for deleting the rule is incorrect, resulting in a leftover > rule after execution. > > Fix it by correcting the deletion command. > > Fixes: 5e06e7ac99dc ("tests: Refactor the iptables accept rule.") > Signed-off-by: Paolo Valerio <pvalerio@redhat.com> > Reviewed-by: Aaron Conole <aconole@redhat.com> > Acked-by: Simon Horman <horms@ovn.org> > Acked-by: Eelco Chaudron <echaudro@redhat.com> FTR, this still looks good to me.
diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at index 06c978555..f1b8041fb 100644 --- a/tests/ovs-macros.at +++ b/tests/ovs-macros.at @@ -365,4 +365,4 @@ dnl to reject input traffic from bridges such as br-underlay. dnl Add a rule to always accept the traffic. m4_define([IPTABLES_ACCEPT], [AT_CHECK([iptables -I INPUT 1 -i $1 -j ACCEPT]) - on_exit 'iptables -D INPUT 1 -i $1']) + on_exit 'iptables -D INPUT 1'])
Currently, at every call of IPTABLES_ACCEPT() an iptables rule gets added. Such rule is supposed to be removed on exit, but the current syntax for deleting the rule is incorrect, resulting in a leftover rule after execution. Fix it by correcting the deletion command. Fixes: 5e06e7ac99dc ("tests: Refactor the iptables accept rule.") Signed-off-by: Paolo Valerio <pvalerio@redhat.com> Reviewed-by: Aaron Conole <aconole@redhat.com> Acked-by: Simon Horman <horms@ovn.org> Acked-by: Eelco Chaudron <echaudro@redhat.com> --- tests/ovs-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)