mbox series

[SRU,j/f:azure,0/1] Missing fix in linux kernel cifs/smb client module

Message ID 20240927193051.1552498-1-john.cabaj@canonical.com
Headers show
Series Missing fix in linux kernel cifs/smb client module | expand

Message

John Cabaj Sept. 27, 2024, 7:30 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2071744

SRU Justification

[Impact]

* Adding missing patch to avoid file size updates from readdir during read/write lease.

[Fix]

* Backport from linux upstream, e4b61f3b1c67: "cifs: prevent updating file size from server if we have a read/write lease"

[Test Plan]

* Compile tested
* Boot tested
* Tested by Microsoft

[Regression potential]

* Changes isolated, minimal regression risk. Changes already backported to 6.8 kernel.
* Changes add two function, is_size_safe_to_change() and cifs_fattr_to_inode()

[Other info]

* SF #00388888

Bharath SM (1):
  cifs: prevent updating file size from server if we have a read/write
    lease

 fs/cifs/cifsproto.h |  6 ++++--
 fs/cifs/file.c      |  8 +++++---
 fs/cifs/inode.c     | 17 +++++++++--------
 fs/cifs/readdir.c   |  2 +-
 4 files changed, 19 insertions(+), 14 deletions(-)

Comments

Guoqing Jiang Sept. 30, 2024, 1:40 a.m. UTC | #1
Acked-by: Guoqing Jiang <guoqing.jiang@canonical.com>

On 9/28/24 03:30, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2071744
>
> SRU Justification
>
> [Impact]
>
> * Adding missing patch to avoid file size updates from readdir during read/write lease.
>
> [Fix]
>
> * Backport from linux upstream, e4b61f3b1c67: "cifs: prevent updating file size from server if we have a read/write lease"
>
> [Test Plan]
>
> * Compile tested
> * Boot tested
> * Tested by Microsoft
>
> [Regression potential]
>
> * Changes isolated, minimal regression risk. Changes already backported to 6.8 kernel.
> * Changes add two function, is_size_safe_to_change() and cifs_fattr_to_inode()
>
> [Other info]
>
> * SF #00388888
>
> Bharath SM (1):
>    cifs: prevent updating file size from server if we have a read/write
>      lease
>
>   fs/cifs/cifsproto.h |  6 ++++--
>   fs/cifs/file.c      |  8 +++++---
>   fs/cifs/inode.c     | 17 +++++++++--------
>   fs/cifs/readdir.c   |  2 +-
>   4 files changed, 19 insertions(+), 14 deletions(-)
>
Magali Lemes Oct. 7, 2024, 9:37 p.m. UTC | #2
Acked-by: Magali Lemes <magali.lemes@canonical.com>

On 27/09/2024 16:30, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2071744
> 
> SRU Justification
> 
> [Impact]
> 
> * Adding missing patch to avoid file size updates from readdir during read/write lease.
> 
> [Fix]
> 
> * Backport from linux upstream, e4b61f3b1c67: "cifs: prevent updating file size from server if we have a read/write lease"
> 
> [Test Plan]
> 
> * Compile tested
> * Boot tested
> * Tested by Microsoft
> 
> [Regression potential]
> 
> * Changes isolated, minimal regression risk. Changes already backported to 6.8 kernel.
> * Changes add two function, is_size_safe_to_change() and cifs_fattr_to_inode()
> 
> [Other info]
> 
> * SF #00388888
> 
> Bharath SM (1):
>    cifs: prevent updating file size from server if we have a read/write
>      lease
> 
>   fs/cifs/cifsproto.h |  6 ++++--
>   fs/cifs/file.c      |  8 +++++---
>   fs/cifs/inode.c     | 17 +++++++++--------
>   fs/cifs/readdir.c   |  2 +-
>   4 files changed, 19 insertions(+), 14 deletions(-)
>
John Cabaj Oct. 7, 2024, 9:45 p.m. UTC | #3
On 9/27/24 2:30 PM, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2071744
> 
> SRU Justification
> 
> [Impact]
> 
> * Adding missing patch to avoid file size updates from readdir during read/write lease.
> 
> [Fix]
> 
> * Backport from linux upstream, e4b61f3b1c67: "cifs: prevent updating file size from server if we have a read/write lease"
> 
> [Test Plan]
> 
> * Compile tested
> * Boot tested
> * Tested by Microsoft
> 
> [Regression potential]
> 
> * Changes isolated, minimal regression risk. Changes already backported to 6.8 kernel.
> * Changes add two function, is_size_safe_to_change() and cifs_fattr_to_inode()
> 
> [Other info]
> 
> * SF #00388888
> 
> Bharath SM (1):
>    cifs: prevent updating file size from server if we have a read/write
>      lease
> 
>   fs/cifs/cifsproto.h |  6 ++++--
>   fs/cifs/file.c      |  8 +++++---
>   fs/cifs/inode.c     | 17 +++++++++--------
>   fs/cifs/readdir.c   |  2 +-
>   4 files changed, 19 insertions(+), 14 deletions(-)
> 

Applied to jammy/focal:linux-azure master-next branches.


Thanks,
John