diff mbox series

[ovs-dev] ci: Pin scapy version.

Message ID 20241001123156.375655-1-amusil@redhat.com
State Accepted
Headers show
Series [ovs-dev] ci: Pin scapy version. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Ales Musil Oct. 1, 2024, 12:31 p.m. UTC
The latest scapy version (2.6.0) fails to properly evaulate if
.config directory already exists [0]. Pin the version to 2.5.0
for the time being as that one was working without any issues.

[0] https://github.com/secdev/scapy/issues/4546
Signed-off-by: Ales Musil <amusil@redhat.com>
---
 utilities/containers/py-requirements.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Michelson Oct. 1, 2024, 12:58 p.m. UTC | #1
Thanks Ales.

Acked-by: Mark Michelson <mmichels@redhat.com>

Since this is causing CI failures, and the patch is so simple I pushed 
the change to all branches that have scapy in a py-requirements.txt 
file. That means I pushed the change to branch-23.03 up to main.

On 10/1/24 08:31, Ales Musil wrote:
> The latest scapy version (2.6.0) fails to properly evaulate if
> .config directory already exists [0]. Pin the version to 2.5.0
> for the time being as that one was working without any issues.
> 
> [0] https://github.com/secdev/scapy/issues/4546
> Signed-off-by: Ales Musil <amusil@redhat.com>
> ---
>   utilities/containers/py-requirements.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utilities/containers/py-requirements.txt b/utilities/containers/py-requirements.txt
> index 8a3e977aa..1b55042c8 100644
> --- a/utilities/containers/py-requirements.txt
> +++ b/utilities/containers/py-requirements.txt
> @@ -1,6 +1,6 @@
>   flake8>=6.1.0
>   meson>=1.4,<1.5
> -scapy
> +scapy==2.5.0
>   sphinx<8.0 # https://github.com/sphinx-doc/sphinx/issues/12711
>   setuptools
>   pyelftools
diff mbox series

Patch

diff --git a/utilities/containers/py-requirements.txt b/utilities/containers/py-requirements.txt
index 8a3e977aa..1b55042c8 100644
--- a/utilities/containers/py-requirements.txt
+++ b/utilities/containers/py-requirements.txt
@@ -1,6 +1,6 @@ 
 flake8>=6.1.0
 meson>=1.4,<1.5
-scapy
+scapy==2.5.0
 sphinx<8.0 # https://github.com/sphinx-doc/sphinx/issues/12711
 setuptools
 pyelftools