diff mbox series

[ovs-dev,v2,2/6] conntrack: Add zone limit coverage counter.

Message ID 20240930205034.65484-2-pvalerio@redhat.com
State Accepted
Commit 8ec7d55bfcccddc6dcc8d2652d10bcc2163d5091
Delegated to: aaron conole
Headers show
Series [ovs-dev,v2,1/6] conntrack: Correctly annotate conntrack member. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

Paolo Valerio Sept. 30, 2024, 8:50 p.m. UTC
Similarly to what it's done for conntrack_full, add
conntrack_zone_full increased when new entries are not added due to
reaching the zone limit.

Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
---
 lib/conntrack.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Aaron Conole Oct. 1, 2024, 12:54 p.m. UTC | #1
Paolo Valerio <pvalerio@redhat.com> writes:

> Similarly to what it's done for conntrack_full, add
> conntrack_zone_full increased when new entries are not added due to
> reaching the zone limit.
>
> Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>

>  lib/conntrack.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> index e96779e68..8cf200e06 100644
> --- a/lib/conntrack.c
> +++ b/lib/conntrack.c
> @@ -50,6 +50,7 @@ COVERAGE_DEFINE(conntrack_full);
>  COVERAGE_DEFINE(conntrack_l3csum_err);
>  COVERAGE_DEFINE(conntrack_l4csum_err);
>  COVERAGE_DEFINE(conntrack_lookup_natted_miss);
> +COVERAGE_DEFINE(conntrack_zone_full);
>  
>  struct conn_lookup_ctx {
>      struct conn_key key;
> @@ -918,6 +919,7 @@ conn_not_found(struct conntrack *ct, struct dp_packet *pkt,
>          struct zone_limit *zl = zone_limit_lookup_or_default(ct,
>                                                               ctx->key.zone);
>          if (zl && atomic_count_get(&zl->czl.count) >= zl->czl.limit) {
> +            COVERAGE_INC(conntrack_zone_full);
>              return nc;
>          }
diff mbox series

Patch

diff --git a/lib/conntrack.c b/lib/conntrack.c
index e96779e68..8cf200e06 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -50,6 +50,7 @@  COVERAGE_DEFINE(conntrack_full);
 COVERAGE_DEFINE(conntrack_l3csum_err);
 COVERAGE_DEFINE(conntrack_l4csum_err);
 COVERAGE_DEFINE(conntrack_lookup_natted_miss);
+COVERAGE_DEFINE(conntrack_zone_full);
 
 struct conn_lookup_ctx {
     struct conn_key key;
@@ -918,6 +919,7 @@  conn_not_found(struct conntrack *ct, struct dp_packet *pkt,
         struct zone_limit *zl = zone_limit_lookup_or_default(ct,
                                                              ctx->key.zone);
         if (zl && atomic_count_get(&zl->czl.count) >= zl->czl.limit) {
+            COVERAGE_INC(conntrack_zone_full);
             return nc;
         }