diff mbox series

[linux,v2,12/20] dt-bindings: net: cdns,macb: Add PIC64GX compatibility

Message ID 20240930095449.1813195-13-pierre-henry.moussay@microchip.com
State Handled Elsewhere
Headers show
Series [linux,v2,01/20] dt-bindings: can: mpfs: add PIC64GX CAN compatibility | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

pierre-henry.moussay@microchip.com Sept. 30, 2024, 9:54 a.m. UTC 
From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>

PIC64GX uses cdns,macb IP, without additional vendor features

Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
---
 Documentation/devicetree/bindings/net/cdns,macb.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Conor Dooley Sept. 30, 2024, 1:52 p.m. UTC | #1 
On Mon, Sep 30, 2024 at 10:54:41AM +0100, pierre-henry.moussay@microchip.com wrote:
> From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> 
> PIC64GX uses cdns,macb IP, without additional vendor features

That's not really true. There's a mpfs specific match data structure in
the driver which the pic64gx also needs to use.

> 
> Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> ---
>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 3c30dd23cd4e..25ca7f5a7357 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -38,7 +38,10 @@ properties:
>                - cdns,sam9x60-macb     # Microchip sam9x60 SoC
>                - microchip,mpfs-macb   # Microchip PolarFire SoC
>            - const: cdns,macb          # Generic
> -
> +      - items:
> +          - const: microchip,pic64gx-macb # Microchip PIC64GX SoC
> +          - const: microchip,mpfs-macb    # Microchip PolarFire SoC
> +          - const: cdns,macb              # Generic
>        - items:
>            - enum:
>                - atmel,sama5d3-macb    # 10/100Mbit IP on Atmel sama5d3 SoCs
> -- 
> 2.30.2
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
index 3c30dd23cd4e..25ca7f5a7357 100644
--- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
+++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
@@ -38,7 +38,10 @@  properties:
               - cdns,sam9x60-macb     # Microchip sam9x60 SoC
               - microchip,mpfs-macb   # Microchip PolarFire SoC
           - const: cdns,macb          # Generic
-
+      - items:
+          - const: microchip,pic64gx-macb # Microchip PIC64GX SoC
+          - const: microchip,mpfs-macb    # Microchip PolarFire SoC
+          - const: cdns,macb              # Generic
       - items:
           - enum:
               - atmel,sama5d3-macb    # 10/100Mbit IP on Atmel sama5d3 SoCs