| Message ID | 20240928123626.31170-1-aconole@redhat.com |
|---|---|
| State | Accepted |
| Commit | 84ea72fcc7e8e6cf74b6ac88d9fc7a7d64cdcb56 |
| Delegated to: | aaron conole |
| Headers | show |
| Series | [ovs-dev] Revert "ci: Use sarif-tools v3.0.1 due to issues in earlier versions." | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 28 Sep 2024, at 14:36, Aaron Conole wrote: > It seems that the sarif-tools package version 3.0+ cause some kind > of instability with the build system. Until it has a proper root > cause, we shouldn't try to apply any fixes. > > This reverts commit f2ab45c66e2fe536e98f7f45d107d9f8c3209437. > > Signed-off-by: Aaron Conole <aconole@redhat.com> Sound good to me, and sorry for all this hassle :( //Eelco Acked-by: Eelco Chaudron <echaudro@redhat.com> > --- > .ci/linux-prepare.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh > index b537163b8e..5f8a1db6af 100755 > --- a/.ci/linux-prepare.sh > +++ b/.ci/linux-prepare.sh > @@ -23,7 +23,7 @@ cd .. > # https://github.com/pypa/pip/issues/10655 > pip3 install --disable-pip-version-check --user wheel > pip3 install --disable-pip-version-check --user \ > - flake8 netaddr pyparsing sarif-tools>=3.0.1 sphinx setuptools > + flake8 netaddr pyparsing sarif-tools==2.0.0 sphinx setuptools > > # Install python test dependencies > pip3 install -r python/test_requirements.txt > -- > 2.46.1
On 9/28/24 14:36, Aaron Conole wrote: > It seems that the sarif-tools package version 3.0+ cause some kind > of instability with the build system. Until it has a proper root > cause, we shouldn't try to apply any fixes. > > This reverts commit f2ab45c66e2fe536e98f7f45d107d9f8c3209437. > > Signed-off-by: Aaron Conole <aconole@redhat.com> > --- > .ci/linux-prepare.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh > index b537163b8e..5f8a1db6af 100755 > --- a/.ci/linux-prepare.sh > +++ b/.ci/linux-prepare.sh > @@ -23,7 +23,7 @@ cd .. > # https://github.com/pypa/pip/issues/10655 > pip3 install --disable-pip-version-check --user wheel > pip3 install --disable-pip-version-check --user \ > - flake8 netaddr pyparsing sarif-tools>=3.0.1 sphinx setuptools > + flake8 netaddr pyparsing sarif-tools==2.0.0 sphinx setuptools > > # Install python test dependencies > pip3 install -r python/test_requirements.txt Thanks, Aaron! Acked-by: Ilya Maximets <i.maximets@ovn.org> The fix should be released somewhere soon, but I think we'll need a bit more testing before bringing 3.0.3 (or whatever it will be named) into CI. Best regards, Ilya Maximets.
Ilya Maximets <i.maximets@ovn.org> writes: > On 9/28/24 14:36, Aaron Conole wrote: >> It seems that the sarif-tools package version 3.0+ cause some kind >> of instability with the build system. Until it has a proper root >> cause, we shouldn't try to apply any fixes. >> >> This reverts commit f2ab45c66e2fe536e98f7f45d107d9f8c3209437. >> >> Signed-off-by: Aaron Conole <aconole@redhat.com> >> --- >> .ci/linux-prepare.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh >> index b537163b8e..5f8a1db6af 100755 >> --- a/.ci/linux-prepare.sh >> +++ b/.ci/linux-prepare.sh >> @@ -23,7 +23,7 @@ cd .. >> # https://github.com/pypa/pip/issues/10655 >> pip3 install --disable-pip-version-check --user wheel >> pip3 install --disable-pip-version-check --user \ >> - flake8 netaddr pyparsing sarif-tools>=3.0.1 sphinx setuptools >> + flake8 netaddr pyparsing sarif-tools==2.0.0 sphinx setuptools >> >> # Install python test dependencies >> pip3 install -r python/test_requirements.txt > > Thanks, Aaron! > > Acked-by: Ilya Maximets <i.maximets@ovn.org> > > The fix should be released somewhere soon, but I think we'll need > a bit more testing before bringing 3.0.3 (or whatever it will be > named) into CI. Agreed, and I've applied this patch to the tree. Thanks Eelco, and Ilya. > Best regards, Ilya Maximets.
diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh index b537163b8e..5f8a1db6af 100755 --- a/.ci/linux-prepare.sh +++ b/.ci/linux-prepare.sh @@ -23,7 +23,7 @@ cd .. # https://github.com/pypa/pip/issues/10655 pip3 install --disable-pip-version-check --user wheel pip3 install --disable-pip-version-check --user \ - flake8 netaddr pyparsing sarif-tools>=3.0.1 sphinx setuptools + flake8 netaddr pyparsing sarif-tools==2.0.0 sphinx setuptools # Install python test dependencies pip3 install -r python/test_requirements.txt
It seems that the sarif-tools package version 3.0+ cause some kind of instability with the build system. Until it has a proper root cause, we shouldn't try to apply any fixes. This reverts commit f2ab45c66e2fe536e98f7f45d107d9f8c3209437. Signed-off-by: Aaron Conole <aconole@redhat.com> --- .ci/linux-prepare.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)