mbox series

[GIT,PULL] i2c-host-fixes for v6.12-rc1

Message ID auogjhzhbs2w45ptdkl5ceyxsm7apyfi5wmfv3iwuzfh47pl6f@4nnrnpqqlum2
State Superseded
Headers show
Series [GIT,PULL] i2c-host-fixes for v6.12-rc1 | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git tags/i2c-host-fixes-6.12-rc1

Message

Andi Shyti Sept. 27, 2024, 10:09 a.m. UTC
Hi Wolfram,

Here’s the first pull request for the new 6.12 cycle. I hope
the tag description is good this time.

My i2c/i2c-host-fixes branch is based on Linus's merge commit
of the i2c stable patches.

I wish you a great weekend!
Andi

The following changes since commit 4e2c9cd7dce6c7480f236c3ead196ff4e92ed597:

  Merge tag 'i2c-for-6.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux (2024-09-23 14:34:19 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git tags/i2c-host-fixes-6.12-rc1

for you to fetch changes up to 0c8d604dea437b69a861479b413d629bc9b3da70:

  i2c: xiic: Fix pm_runtime_set_suspended() with runtime pm enabled (2024-09-27 11:48:21 +0200)

----------------------------------------------------------------
The DesignWare driver now has the correct ENABLE-ABORT sequence,
ensuring ABORT can always be sent when needed.

In the SynQuacer controller we now check for PCLK as an optional
clock, allowing ACPI to directly provide the clock rate.

The recent KEBA driver required a dependency fix in Kconfig.

The XIIC driver now has a corrected power suspend sequence.

----------------------------------------------------------------
Ard Biesheuvel (1):
      i2c: synquacer: Deal with optional PCLK correctly

Geert Uytterhoeven (1):
      i2c: keba: I2C_KEBA should depend on KEBA_CP500

Jinjie Ruan (1):
      i2c: xiic: Fix pm_runtime_set_suspended() with runtime pm enabled

Kimriver Liu (1):
      i2c: designware: fix controller is holding SCL low while ENABLE bit is disabled

 drivers/i2c/busses/Kconfig                 |  1 +
 drivers/i2c/busses/i2c-designware-common.c | 14 ++++++++++++++
 drivers/i2c/busses/i2c-designware-core.h   |  1 +
 drivers/i2c/busses/i2c-designware-master.c | 38 ++++++++++++++++++++++++++++++++++++++
 drivers/i2c/busses/i2c-synquacer.c         |  5 +++--
 drivers/i2c/busses/i2c-xiic.c              |  2 +-
 6 files changed, 58 insertions(+), 3 deletions(-)

Comments

Andy Shevchenko Sept. 27, 2024, 3:45 p.m. UTC | #1
On Fri, Sep 27, 2024 at 12:09:36PM +0200, Andi Shyti wrote:

...

> ----------------------------------------------------------------
> The DesignWare driver now has the correct ENABLE-ABORT sequence,
> ensuring ABORT can always be sent when needed.
> 
> In the SynQuacer controller we now check for PCLK as an optional
> clock, allowing ACPI to directly provide the clock rate.
> 
> The recent KEBA driver required a dependency fix in Kconfig.
> 
> The XIIC driver now has a corrected power suspend sequence.

While tag message looks nice here, I think it still has to follow the
same (as in the commit message) pattern, i.e.

$SUMMARY
...blank line...
$DESCRIPTION

Why? Because the Web representation of the message looks weird on the
Web. Compare
https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/intel.git/tag/?h=intel-pinctrl-v6.12-1
and yours
https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git/tag/?h=i2c-host-fixes-6.12-rc1
Andi Shyti Sept. 27, 2024, 4:01 p.m. UTC | #2
Hi Andy,

On Fri, Sep 27, 2024 at 06:45:06PM GMT, Andy Shevchenko wrote:
> On Fri, Sep 27, 2024 at 12:09:36PM +0200, Andi Shyti wrote:
> 
> ...
> 
> > ----------------------------------------------------------------
> > The DesignWare driver now has the correct ENABLE-ABORT sequence,
> > ensuring ABORT can always be sent when needed.
> > 
> > In the SynQuacer controller we now check for PCLK as an optional
> > clock, allowing ACPI to directly provide the clock rate.
> > 
> > The recent KEBA driver required a dependency fix in Kconfig.
> > 
> > The XIIC driver now has a corrected power suspend sequence.
> 
> While tag message looks nice here, I think it still has to follow the
> same (as in the commit message) pattern, i.e.
> 
> $SUMMARY
> ...blank line...
> $DESCRIPTION
> 
> Why? Because the Web representation of the message looks weird on the
> Web. Compare
> https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/intel.git/tag/?h=intel-pinctrl-v6.12-1
> and yours
> https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git/tag/?h=i2c-host-fixes-6.12-rc1

I've been looking at many git tag descriptions and I haven't seen
a rule being enforced as it is for the commits.

In any case, thanks a lot for looking into my tag description, I
can defeinitely adopt your way.

I will resend this pull request with a proper formatting.

Thanks,
Andi