| Message ID | 7cebb9b5496959f3a0e00429719274d8d0a28c6e.1727337290.git.echaudro@redhat.com |
|---|---|
| State | Accepted |
| Commit | f2ab45c66e2fe536e98f7f45d107d9f8c3209437 |
| Headers | show |
| Series | [ovs-dev] ci: Use sarif-tools v3.0.1 due to issues in earlier versions. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
Eelco Chaudron <echaudro@redhat.com> writes: > Sarif-tools v3.0 introduced an issue that has been resolved in v3.0.1. > Ensure that v3.0.1 or higher is installed via pip. > > Fixes: 234e626198a4 ("ci: Use previous sarif-tools release due to > issue in latest release.") > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> > --- Thanks, Eelco. Applied and backported to branch-3.4 and branch-3.3.
On 27 Sep 2024, at 14:51, Aaron Conole wrote: > Eelco Chaudron <echaudro@redhat.com> writes: > >> Sarif-tools v3.0 introduced an issue that has been resolved in v3.0.1. >> Ensure that v3.0.1 or higher is installed via pip. >> >> Fixes: 234e626198a4 ("ci: Use previous sarif-tools release due to >> issue in latest release.") >> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >> --- > > Thanks, Eelco. Applied and backported to branch-3.4 and branch-3.3. Thanks Aaron for applying and doing the backport. //Eelco
On 9/27/24 15:41, Eelco Chaudron wrote: > > > On 27 Sep 2024, at 14:51, Aaron Conole wrote: > >> Eelco Chaudron <echaudro@redhat.com> writes: >> >>> Sarif-tools v3.0 introduced an issue that has been resolved in v3.0.1. >>> Ensure that v3.0.1 or higher is installed via pip. >>> >>> Fixes: 234e626198a4 ("ci: Use previous sarif-tools release due to >>> issue in latest release.") >>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >>> --- >> >> Thanks, Eelco. Applied and backported to branch-3.4 and branch-3.3. > > Thanks Aaron for applying and doing the backport. Hi, Eelco and Aaron. There is something wrong with it still. The check failed on both main and branch-3.4 (3.3 is fine): Check: exiting with return code 2 due to increase in issues at or above note severity error level: +0 -0 no changes warning level: +2 -2 New issue "core.NullDereference ..." (36 occurrences) file:///home/runner/work/ovs/ovs/include/openvswitch/hmap.h:319 file:///home/runner/work/ovs/ovs/include/openvswitch/list.h:262 file:///home/runner/work/ovs/ovs/include/openvswitch/nsh.h:287 ... New issue "core.UndefinedBinaryOperatorResult The left operand of ' ..." (4 occurrences) file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:946 file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:963 file:///home/runner/work/ovs/ovs/lib/netlink-socket.c:240 ... Eliminated issue "core.NullDereference Access to field ' ..." Eliminated issue "core.UndefinedBinaryOperatorResult The ..." note level: +0 -0 no changes all levels: +2 -2 Best regards, Ilya Maximets.
Ilya Maximets <i.maximets@ovn.org> writes: > On 9/27/24 15:41, Eelco Chaudron wrote: >> >> >> On 27 Sep 2024, at 14:51, Aaron Conole wrote: >> >>> Eelco Chaudron <echaudro@redhat.com> writes: >>> >>>> Sarif-tools v3.0 introduced an issue that has been resolved in v3.0.1. >>>> Ensure that v3.0.1 or higher is installed via pip. >>>> >>>> Fixes: 234e626198a4 ("ci: Use previous sarif-tools release due to >>>> issue in latest release.") >>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >>>> --- >>> >>> Thanks, Eelco. Applied and backported to branch-3.4 and branch-3.3. >> >> Thanks Aaron for applying and doing the backport. > > Hi, Eelco and Aaron. There is something wrong with it still. > > The check failed on both main and branch-3.4 (3.3 is fine): O_O Well, I applied based on: https://github.com/ovsrobot/ovs/actions/runs/11048312854 So looks like Sarif recent versions could be unstable, maybe? > Check: exiting with return code 2 due to increase in issues at or above note severity > error level: +0 -0 no changes > warning level: +2 -2 > New issue "core.NullDereference ..." (36 occurrences) > file:///home/runner/work/ovs/ovs/include/openvswitch/hmap.h:319 > file:///home/runner/work/ovs/ovs/include/openvswitch/list.h:262 > file:///home/runner/work/ovs/ovs/include/openvswitch/nsh.h:287 > ... > New issue "core.UndefinedBinaryOperatorResult The left operand of ' ..." (4 occurrences) > file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:946 > file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:963 > file:///home/runner/work/ovs/ovs/lib/netlink-socket.c:240 > ... > Eliminated issue "core.NullDereference Access to field ' ..." > Eliminated issue "core.UndefinedBinaryOperatorResult The ..." > note level: +0 -0 no changes > all levels: +2 -2 > > Best regards, Ilya Maximets.
On 9/27/24 21:27, Aaron Conole wrote: > Ilya Maximets <i.maximets@ovn.org> writes: > >> On 9/27/24 15:41, Eelco Chaudron wrote: >>> >>> >>> On 27 Sep 2024, at 14:51, Aaron Conole wrote: >>> >>>> Eelco Chaudron <echaudro@redhat.com> writes: >>>> >>>>> Sarif-tools v3.0 introduced an issue that has been resolved in v3.0.1. >>>>> Ensure that v3.0.1 or higher is installed via pip. >>>>> >>>>> Fixes: 234e626198a4 ("ci: Use previous sarif-tools release due to >>>>> issue in latest release.") >>>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >>>>> --- >>>> >>>> Thanks, Eelco. Applied and backported to branch-3.4 and branch-3.3. >>> >>> Thanks Aaron for applying and doing the backport. >> >> Hi, Eelco and Aaron. There is something wrong with it still. >> >> The check failed on both main and branch-3.4 (3.3 is fine): > > O_O > > Well, I applied based on: > https://github.com/ovsrobot/ovs/actions/runs/11048312854 > > So looks like Sarif recent versions could be unstable, maybe? Yeah, I did a couple re-runs in my fork and it seem to fail randomly, i.e. one re-run without any code changes can fail or succeed. Should the change be reverted back to 2.0.0 ? Also, sarif-tools>=3.0.1 in a shell command means "re-direct the output to the file named '=3.0.1'", so the patch itself is not correct. Best regards, Ilya Maximets. > >> Check: exiting with return code 2 due to increase in issues at or above note severity >> error level: +0 -0 no changes >> warning level: +2 -2 >> New issue "core.NullDereference ..." (36 occurrences) >> file:///home/runner/work/ovs/ovs/include/openvswitch/hmap.h:319 >> file:///home/runner/work/ovs/ovs/include/openvswitch/list.h:262 >> file:///home/runner/work/ovs/ovs/include/openvswitch/nsh.h:287 >> ... >> New issue "core.UndefinedBinaryOperatorResult The left operand of ' ..." (4 occurrences) >> file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:946 >> file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:963 >> file:///home/runner/work/ovs/ovs/lib/netlink-socket.c:240 >> ... >> Eliminated issue "core.NullDereference Access to field ' ..." >> Eliminated issue "core.UndefinedBinaryOperatorResult The ..." >> note level: +0 -0 no changes >> all levels: +2 -2 >> >> Best regards, Ilya Maximets. >
On 9/27/24 21:31, Ilya Maximets wrote: > On 9/27/24 21:27, Aaron Conole wrote: >> Ilya Maximets <i.maximets@ovn.org> writes: >> >>> On 9/27/24 15:41, Eelco Chaudron wrote: >>>> >>>> >>>> On 27 Sep 2024, at 14:51, Aaron Conole wrote: >>>> >>>>> Eelco Chaudron <echaudro@redhat.com> writes: >>>>> >>>>>> Sarif-tools v3.0 introduced an issue that has been resolved in v3.0.1. >>>>>> Ensure that v3.0.1 or higher is installed via pip. >>>>>> >>>>>> Fixes: 234e626198a4 ("ci: Use previous sarif-tools release due to >>>>>> issue in latest release.") >>>>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >>>>>> --- >>>>> >>>>> Thanks, Eelco. Applied and backported to branch-3.4 and branch-3.3. >>>> >>>> Thanks Aaron for applying and doing the backport. >>> >>> Hi, Eelco and Aaron. There is something wrong with it still. >>> >>> The check failed on both main and branch-3.4 (3.3 is fine): >> >> O_O >> >> Well, I applied based on: >> https://github.com/ovsrobot/ovs/actions/runs/11048312854 >> >> So looks like Sarif recent versions could be unstable, maybe? > > Yeah, I did a couple re-runs in my fork and it seem to fail randomly, > i.e. one re-run without any code changes can fail or succeed. > > Should the change be reverted back to 2.0.0 ? > > Also, sarif-tools>=3.0.1 in a shell command means "re-direct the output > to the file named '=3.0.1'", so the patch itself is not correct. Note: it installs the latest 3.0.2, so it's not the cause of the failures. > > Best regards, Ilya Maximets. > >> >>> Check: exiting with return code 2 due to increase in issues at or above note severity >>> error level: +0 -0 no changes >>> warning level: +2 -2 >>> New issue "core.NullDereference ..." (36 occurrences) >>> file:///home/runner/work/ovs/ovs/include/openvswitch/hmap.h:319 >>> file:///home/runner/work/ovs/ovs/include/openvswitch/list.h:262 >>> file:///home/runner/work/ovs/ovs/include/openvswitch/nsh.h:287 >>> ... >>> New issue "core.UndefinedBinaryOperatorResult The left operand of ' ..." (4 occurrences) >>> file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:946 >>> file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:963 >>> file:///home/runner/work/ovs/ovs/lib/netlink-socket.c:240 >>> ... >>> Eliminated issue "core.NullDereference Access to field ' ..." >>> Eliminated issue "core.UndefinedBinaryOperatorResult The ..." >>> note level: +0 -0 no changes >>> all levels: +2 -2 >>> >>> Best regards, Ilya Maximets. >> >
On 9/27/24 21:32, Ilya Maximets wrote: > On 9/27/24 21:31, Ilya Maximets wrote: >> On 9/27/24 21:27, Aaron Conole wrote: >>> Ilya Maximets <i.maximets@ovn.org> writes: >>> >>>> On 9/27/24 15:41, Eelco Chaudron wrote: >>>>> >>>>> >>>>> On 27 Sep 2024, at 14:51, Aaron Conole wrote: >>>>> >>>>>> Eelco Chaudron <echaudro@redhat.com> writes: >>>>>> >>>>>>> Sarif-tools v3.0 introduced an issue that has been resolved in v3.0.1. >>>>>>> Ensure that v3.0.1 or higher is installed via pip. >>>>>>> >>>>>>> Fixes: 234e626198a4 ("ci: Use previous sarif-tools release due to >>>>>>> issue in latest release.") >>>>>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >>>>>>> --- >>>>>> >>>>>> Thanks, Eelco. Applied and backported to branch-3.4 and branch-3.3. >>>>> >>>>> Thanks Aaron for applying and doing the backport. >>>> >>>> Hi, Eelco and Aaron. There is something wrong with it still. >>>> >>>> The check failed on both main and branch-3.4 (3.3 is fine): >>> >>> O_O >>> >>> Well, I applied based on: >>> https://github.com/ovsrobot/ovs/actions/runs/11048312854 >>> >>> So looks like Sarif recent versions could be unstable, maybe? >> >> Yeah, I did a couple re-runs in my fork and it seem to fail randomly, >> i.e. one re-run without any code changes can fail or succeed. >> >> Should the change be reverted back to 2.0.0 ? >> >> Also, sarif-tools>=3.0.1 in a shell command means "re-direct the output >> to the file named '=3.0.1'", so the patch itself is not correct. > > Note: it installs the latest 3.0.2, so it's not the cause of the failures. I opened an issue for now: https://github.com/microsoft/sarif-tools/issues/68 > >> >> Best regards, Ilya Maximets. >> >>> >>>> Check: exiting with return code 2 due to increase in issues at or above note severity >>>> error level: +0 -0 no changes >>>> warning level: +2 -2 >>>> New issue "core.NullDereference ..." (36 occurrences) >>>> file:///home/runner/work/ovs/ovs/include/openvswitch/hmap.h:319 >>>> file:///home/runner/work/ovs/ovs/include/openvswitch/list.h:262 >>>> file:///home/runner/work/ovs/ovs/include/openvswitch/nsh.h:287 >>>> ... >>>> New issue "core.UndefinedBinaryOperatorResult The left operand of ' ..." (4 occurrences) >>>> file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:946 >>>> file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:963 >>>> file:///home/runner/work/ovs/ovs/lib/netlink-socket.c:240 >>>> ... >>>> Eliminated issue "core.NullDereference Access to field ' ..." >>>> Eliminated issue "core.UndefinedBinaryOperatorResult The ..." >>>> note level: +0 -0 no changes >>>> all levels: +2 -2 >>>> >>>> Best regards, Ilya Maximets. >>> >> >
Ilya Maximets <i.maximets@ovn.org> writes: > On 9/27/24 21:32, Ilya Maximets wrote: >> On 9/27/24 21:31, Ilya Maximets wrote: >>> On 9/27/24 21:27, Aaron Conole wrote: >>>> Ilya Maximets <i.maximets@ovn.org> writes: >>>> >>>>> On 9/27/24 15:41, Eelco Chaudron wrote: >>>>>> >>>>>> >>>>>> On 27 Sep 2024, at 14:51, Aaron Conole wrote: >>>>>> >>>>>>> Eelco Chaudron <echaudro@redhat.com> writes: >>>>>>> >>>>>>>> Sarif-tools v3.0 introduced an issue that has been resolved in v3.0.1. >>>>>>>> Ensure that v3.0.1 or higher is installed via pip. >>>>>>>> >>>>>>>> Fixes: 234e626198a4 ("ci: Use previous sarif-tools release due to >>>>>>>> issue in latest release.") >>>>>>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >>>>>>>> --- >>>>>>> >>>>>>> Thanks, Eelco. Applied and backported to branch-3.4 and branch-3.3. >>>>>> >>>>>> Thanks Aaron for applying and doing the backport. >>>>> >>>>> Hi, Eelco and Aaron. There is something wrong with it still. >>>>> >>>>> The check failed on both main and branch-3.4 (3.3 is fine): >>>> >>>> O_O >>>> >>>> Well, I applied based on: >>>> https://github.com/ovsrobot/ovs/actions/runs/11048312854 >>>> >>>> So looks like Sarif recent versions could be unstable, maybe? >>> >>> Yeah, I did a couple re-runs in my fork and it seem to fail randomly, >>> i.e. one re-run without any code changes can fail or succeed. >>> >>> Should the change be reverted back to 2.0.0 ? >>> >>> Also, sarif-tools>=3.0.1 in a shell command means "re-direct the output >>> to the file named '=3.0.1'", so the patch itself is not correct. >> >> Note: it installs the latest 3.0.2, so it's not the cause of the failures. > > I opened an issue for now: https://github.com/microsoft/sarif-tools/issues/68 Thanks. I think a revert is appropriate. I will send one out. >> >>> >>> Best regards, Ilya Maximets. >>> >>>> >>>>> Check: exiting with return code 2 due to increase in issues at or above note severity >>>>> error level: +0 -0 no changes >>>>> warning level: +2 -2 >>>>> New issue "core.NullDereference ..." (36 occurrences) >>>>> file:///home/runner/work/ovs/ovs/include/openvswitch/hmap.h:319 >>>>> file:///home/runner/work/ovs/ovs/include/openvswitch/list.h:262 >>>>> file:///home/runner/work/ovs/ovs/include/openvswitch/nsh.h:287 >>>>> ... >>>>> New issue "core.UndefinedBinaryOperatorResult The left operand of ' ..." (4 occurrences) >>>>> file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:946 >>>>> file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:963 >>>>> file:///home/runner/work/ovs/ovs/lib/netlink-socket.c:240 >>>>> ... >>>>> Eliminated issue "core.NullDereference Access to field ' ..." >>>>> Eliminated issue "core.UndefinedBinaryOperatorResult The ..." >>>>> note level: +0 -0 no changes >>>>> all levels: +2 -2 >>>>> >>>>> Best regards, Ilya Maximets. >>>> >>> >>
diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh index 5f8a1db6a..b537163b8 100755 --- a/.ci/linux-prepare.sh +++ b/.ci/linux-prepare.sh @@ -23,7 +23,7 @@ cd .. # https://github.com/pypa/pip/issues/10655 pip3 install --disable-pip-version-check --user wheel pip3 install --disable-pip-version-check --user \ - flake8 netaddr pyparsing sarif-tools==2.0.0 sphinx setuptools + flake8 netaddr pyparsing sarif-tools>=3.0.1 sphinx setuptools # Install python test dependencies pip3 install -r python/test_requirements.txt
Sarif-tools v3.0 introduced an issue that has been resolved in v3.0.1. Ensure that v3.0.1 or higher is installed via pip. Fixes: 234e626198a4 ("ci: Use previous sarif-tools release due to issue in latest release.") Signed-off-by: Eelco Chaudron <echaudro@redhat.com> --- .ci/linux-prepare.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)