| Message ID | 20240924070214.1300142-1-roid@nvidia.com |
|---|---|
| State | Accepted |
| Commit | f27a1a0811c349df59eddcd6d87d270a85042b28 |
| Delegated to: | Eelco Chaudron |
| Headers | show |
| Series | [ovs-dev,1/2] tests: ovsdb: Update missing ovsdb keywords. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 24 Sep 2024, at 9:02, Roi Dayan via dev wrote: > Some ovsdb tests were missing keywords that exists in all > other ovsdb tests. Thanks Roi for cleaning this up. The patch looks good to me. Acked-by: Eelco Chaudron <echaudro@redhat.com>
On Tue, Sep 24, 2024 at 10:02:13AM +0300, Roi Dayan via dev wrote: > Some ovsdb tests were missing keywords that exists in all > other ovsdb tests. > > Signed-off-by: Roi Dayan <roid@nvidia.com> Reviewed-by: Simon Horman <horms@kernel.org>
On Tue, Sep 24, 2024 at 03:46:24PM +0100, Simon Horman wrote: > On Tue, Sep 24, 2024 at 10:02:13AM +0300, Roi Dayan via dev wrote: > > Some ovsdb tests were missing keywords that exists in all > > other ovsdb tests. > > > > Signed-off-by: Roi Dayan <roid@nvidia.com> > > Reviewed-by: Simon Horman <horms@kernel.org> Oops, I meant; Acked-by: Simon Horman <horms@ovn.org>
On 24 Sep 2024, at 9:02, Roi Dayan via dev wrote: > Some ovsdb tests were missing keywords that exists in all > other ovsdb tests. > > Signed-off-by: Roi Dayan <roid@nvidia.com> Thanks Roi for the patches, and Simon for the review. Series applied to main.
diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at index 74ccaccdd2e9..b8952c869f41 100644 --- a/tests/ovsdb-idl.at +++ b/tests/ovsdb-idl.at @@ -2811,7 +2811,7 @@ OVSDB_CHECK_IDL_TRACK([track, insert and delete, refs to link2], m4_define([OVSDB_CHECK_IDL_PERS_UUID_INSERT_C], [AT_SETUP([$1 - C]) - AT_KEYWORDS([idl persistent uuid insert]) + AT_KEYWORDS([ovsdb server idl persistent uuid insert]) OVSDB_START_IDLTEST([], ["$abs_srcdir/idltest.ovsschema"]) AT_CHECK([test-ovsdb '-vPATTERN:console:test-ovsdb|%c|%m' -vjsonrpc -t10 idl unix:socket $2], [0], [stdout], [stderr]) @@ -2823,7 +2823,7 @@ m4_define([OVSDB_CHECK_IDL_PERS_UUID_INSERT_C], m4_define([OVSDB_CHECK_IDL_PERS_UUID_INSERT_PY], [AT_SETUP([$1 - Python3]) - AT_KEYWORDS([idl python persistent uuid insert]) + AT_KEYWORDS([ovsdb server idl python persistent uuid insert]) OVSDB_START_IDLTEST([], ["$abs_srcdir/idltest.ovsschema"]) AT_CHECK([$PYTHON3 $srcdir/test-ovsdb.py -t10 idl $srcdir/idltest.ovsschema unix:socket $2], [0], [stdout], [stderr]) diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at index ce6d32aee1df..4af386058a7c 100644 --- a/tests/ovsdb-server.at +++ b/tests/ovsdb-server.at @@ -1420,6 +1420,7 @@ ovsdb_check_online_conversion cluster AT_CLEANUP AT_SETUP([ovsdb-server combines updates on backlogged connections]) +AT_KEYWORDS([ovsdb server]) on_exit 'kill `cat *.pid`' # The maximum socket receive buffer size is important for this test, which @@ -1518,6 +1519,7 @@ OVSDB_SERVER_SHUTDOWN AT_CLEANUP AT_SETUP([ovsdb-server transaction history size]) +AT_KEYWORDS([ovsdb server transaction]) on_exit 'kill `cat *.pid`' dnl Start an ovsdb-server with the clustered vswitchd schema.
Some ovsdb tests were missing keywords that exists in all other ovsdb tests. Signed-off-by: Roi Dayan <roid@nvidia.com> --- tests/ovsdb-idl.at | 4 ++-- tests/ovsdb-server.at | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-)