| Message ID | 20240920070242.20884-9-tien.fong.chee@intel.com |
|---|---|
| State | New |
| Delegated to: | TIEN FONG CHEE |
| Headers | show |
| Series | SoCFPGA: Add Boot Support for Agilex 5 in U-Boot | expand |
On 9/20/24 9:02 AM, tien.fong.chee@intel.com wrote: > From: Tien Fong Chee <tien.fong.chee@intel.com> > > Enable XGMAC for SoCFPGA Agilex5 devkit. > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > --- > .../arm/dts/socfpga_agilex5_socdk-u-boot.dtsi | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > index 9eb21d65428..75ab05031bc 100644 > --- a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > +++ b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > @@ -122,3 +122,36 @@ > bootph-all; > }; > > +&gmac0 { > + status = "okay"; > + phy-mode = "rgmii"; > + phy-handle = <&emac0_phy0>; Shouldn't this be part of Linux DT already ?
Hi, > -----Original Message----- > From: Marek Vasut <marex@denx.de> > Sent: Saturday, September 21, 2024 9:51 PM > To: Chee, Tien Fong <tien.fong.chee@intel.com>; u-boot@lists.denx.de > Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>; Meng, Tingting > <tingting.meng@intel.com>; Yuslaimi, Alif Zakuan > <alif.zakuan.yuslaimi@intel.com>; Hea, Kok Kiang > <kok.kiang.hea@intel.com> > Subject: Re: [PATCH v1 08/20] arm: dts: agilex5: Enable XGMAC > > On 9/20/24 9:02 AM, tien.fong.chee@intel.com wrote: > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > Enable XGMAC for SoCFPGA Agilex5 devkit. > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > --- > > .../arm/dts/socfpga_agilex5_socdk-u-boot.dtsi | 33 > +++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > > index 9eb21d65428..75ab05031bc 100644 > > --- a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > > +++ b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > > @@ -122,3 +122,36 @@ > > bootph-all; > > }; > > > > +&gmac0 { > > + status = "okay"; > > + phy-mode = "rgmii"; > > + phy-handle = <&emac0_phy0>; > Shouldn't this be part of Linux DT already ? This enablement not yet in Linux DT, I believe our Linux team is still working on it. Regards, Tien Fong
On 9/24/24 8:02 AM, Chee, Tien Fong wrote: > Hi, Hi, >>> diff --git a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi >> b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi >>> index 9eb21d65428..75ab05031bc 100644 >>> --- a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi >>> +++ b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi >>> @@ -122,3 +122,36 @@ >>> bootph-all; >>> }; >>> >>> +&gmac0 { >>> + status = "okay"; >>> + phy-mode = "rgmii"; >>> + phy-handle = <&emac0_phy0>; >> Shouldn't this be part of Linux DT already ? > > This enablement not yet in Linux DT, I believe our Linux team is still working on it. Is there at least a patch posted upstream ?
Hi, > -----Original Message----- > From: Marek Vasut <marex@denx.de> > Sent: Wednesday, September 25, 2024 2:36 AM > To: Chee, Tien Fong <tien.fong.chee@intel.com>; u-boot@lists.denx.de > Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>; Meng, Tingting > <tingting.meng@intel.com>; Yuslaimi, Alif Zakuan > <alif.zakuan.yuslaimi@intel.com>; Hea, Kok Kiang > <kok.kiang.hea@intel.com> > Subject: Re: [PATCH v1 08/20] arm: dts: agilex5: Enable XGMAC > > On 9/24/24 8:02 AM, Chee, Tien Fong wrote: > > Hi, > > Hi, > > >>> diff --git a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > >> b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > >>> index 9eb21d65428..75ab05031bc 100644 > >>> --- a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > >>> +++ b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > >>> @@ -122,3 +122,36 @@ > >>> bootph-all; > >>> }; > >>> > >>> +&gmac0 { > >>> + status = "okay"; > >>> + phy-mode = "rgmii"; > >>> + phy-handle = <&emac0_phy0>; > >> Shouldn't this be part of Linux DT already ? > > > > This enablement not yet in Linux DT, I believe our Linux team is still working > on it. > Is there at least a patch posted upstream ? Having two patches posted now in Linux mainline, but gmac device is still not yet added into these dt. https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts I think we can do a cleanup if the duplicated found in U-Boot later. Thanks. Regards, Tien Fong
On 9/25/24 8:13 AM, Chee, Tien Fong wrote: > Hi, > >> -----Original Message----- >> From: Marek Vasut <marex@denx.de> >> Sent: Wednesday, September 25, 2024 2:36 AM >> To: Chee, Tien Fong <tien.fong.chee@intel.com>; u-boot@lists.denx.de >> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>; Meng, Tingting >> <tingting.meng@intel.com>; Yuslaimi, Alif Zakuan >> <alif.zakuan.yuslaimi@intel.com>; Hea, Kok Kiang >> <kok.kiang.hea@intel.com> >> Subject: Re: [PATCH v1 08/20] arm: dts: agilex5: Enable XGMAC >> >> On 9/24/24 8:02 AM, Chee, Tien Fong wrote: >>> Hi, >> >> Hi, >> >>>>> diff --git a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi >>>> b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi >>>>> index 9eb21d65428..75ab05031bc 100644 >>>>> --- a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi >>>>> +++ b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi >>>>> @@ -122,3 +122,36 @@ >>>>> bootph-all; >>>>> }; >>>>> >>>>> +&gmac0 { >>>>> + status = "okay"; >>>>> + phy-mode = "rgmii"; >>>>> + phy-handle = <&emac0_phy0>; >>>> Shouldn't this be part of Linux DT already ? >>> >>> This enablement not yet in Linux DT, I believe our Linux team is still working >> on it. >> Is there at least a patch posted upstream ? > > Having two patches posted now in Linux mainline, but gmac device is still not yet added into these dt. > https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi > https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts > > I think we can do a cleanup if the duplicated found in U-Boot later. At least reference the two patches (lore links) in the V2 of this patch.
Hi, > -----Original Message----- > From: Marek Vasut <marex@denx.de> > Sent: Wednesday, September 25, 2024 8:51 PM > To: Chee, Tien Fong <tien.fong.chee@intel.com>; u-boot@lists.denx.de > Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>; Meng, Tingting > <tingting.meng@intel.com>; Yuslaimi, Alif Zakuan > <alif.zakuan.yuslaimi@intel.com>; Hea, Kok Kiang > <kok.kiang.hea@intel.com> > Subject: Re: [PATCH v1 08/20] arm: dts: agilex5: Enable XGMAC > > On 9/25/24 8:13 AM, Chee, Tien Fong wrote: > > Hi, > > > >> -----Original Message----- > >> From: Marek Vasut <marex@denx.de> > >> Sent: Wednesday, September 25, 2024 2:36 AM > >> To: Chee, Tien Fong <tien.fong.chee@intel.com>; u-boot@lists.denx.de > >> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>; Meng, > >> Tingting <tingting.meng@intel.com>; Yuslaimi, Alif Zakuan > >> <alif.zakuan.yuslaimi@intel.com>; Hea, Kok Kiang > >> <kok.kiang.hea@intel.com> > >> Subject: Re: [PATCH v1 08/20] arm: dts: agilex5: Enable XGMAC > >> > >> On 9/24/24 8:02 AM, Chee, Tien Fong wrote: > >>> Hi, > >> > >> Hi, > >> > >>>>> diff --git a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > >>>> b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > >>>>> index 9eb21d65428..75ab05031bc 100644 > >>>>> --- a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > >>>>> +++ b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi > >>>>> @@ -122,3 +122,36 @@ > >>>>> bootph-all; > >>>>> }; > >>>>> > >>>>> +&gmac0 { > >>>>> + status = "okay"; > >>>>> + phy-mode = "rgmii"; > >>>>> + phy-handle = <&emac0_phy0>; > >>>> Shouldn't this be part of Linux DT already ? > >>> > >>> This enablement not yet in Linux DT, I believe our Linux team is > >>> still working > >> on it. > >> Is there at least a patch posted upstream ? > > > > Having two patches posted now in Linux mainline, but gmac device is still > not yet added into these dt. > > https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/inte > > l/socfpga_agilex5.dtsi > > https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/inte > > l/socfpga_agilex5_socdk.dts > > > > I think we can do a cleanup if the duplicated found in U-Boot later. > At least reference the two patches (lore links) in the V2 of this patch. Noted. Will do. Thanks. Regards, Tien Fong
diff --git a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi index 9eb21d65428..75ab05031bc 100644 --- a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi +++ b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi @@ -122,3 +122,36 @@ bootph-all; }; +&gmac0 { + status = "okay"; + phy-mode = "rgmii"; + phy-handle = <&emac0_phy0>; + + max-frame-size = <9000>; + + mdio0 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "snps,dwxgmac-mdio"; + emac0_phy0: ethernet-phy@0 { + reg = <0>; + }; + }; +}; + +&gmac2 { + status = "okay"; + phy-mode = "rgmii"; + phy-handle = <&emac2_phy0>; + + max-frame-size = <9000>; + + mdio0 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "snps,dwxgmac-mdio"; + emac2_phy0: ethernet-phy@0 { + reg = <0>; + }; + }; +};