mbox series

[v4,0/3] Add support for imx8ulp's SIM

Message ID 20240915114311.75496-1-laurentiu.mihalcea@nxp.com
Headers show
Series Add support for imx8ulp's SIM | expand

Message

Laurentiu Mihalcea Sept. 15, 2024, 11:43 a.m. UTC 
i.MX8ULP's SIM (System Integration Module) allows
control and configuration of certain components
form the domain it's assigned to. Add DT node
and schema for it. Its child shall also be
included.

---
Changes in v4:
- Addressed Rob and Krzysztof's comments
- Link to v3: https://lore.kernel.org/all/20240715164514.8718-1-laurentiumihalcea111@gmail.com/

Changes in v3:
- Addressed Krzysztof's comments
- The "reset: add driver for imx8ulp SIM reset controller" patch might generate conflict when
applied to Rob and Shawn Guo's trees (for-next branch). Tested all patches with linux-next,
next-20240715 tag and no conflicts.
- Link to v2: https://lore.kernel.org/all/20240609125901.76274-1-laurentiumihalcea111@gmail.com/

Changes in v2:
- Reset controller is now also a syscon provider.
- Changed vendor prefix to nxp.
- Link to v1: https://lore.kernel.org/all/20240516204031.171920-1-laurentiumihalcea111@gmail.com/

---
Laurentiu Mihalcea (3):
  dt-bindings: reset: add schema for imx8ulp SIM reset
  reset: add driver for imx8ulp SIM reset controller
  arm64: dts: imx8ulp: add AVD-SIM node

 .../reset/nxp,imx8ulp-avd-sim-reset.yaml      |  58 ++++++++++
 arch/arm64/boot/dts/freescale/imx8ulp.dtsi    |  13 +++
 drivers/reset/Kconfig                         |   7 ++
 drivers/reset/Makefile                        |   1 +
 drivers/reset/reset-imx8ulp-sim.c             | 106 ++++++++++++++++++
 5 files changed, 185 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/reset/nxp,imx8ulp-avd-sim-reset.yaml
 create mode 100644 drivers/reset/reset-imx8ulp-sim.c

Comments

Daniel Baluta Sept. 24, 2024, 11:11 a.m. UTC | #1 
On Sun, Sep 15, 2024 at 2:45 PM Laurentiu Mihalcea
<laurentiumihalcea111@gmail.com> wrote:
>
> Certain components can be reset via the SIM module.
> Add reset controller driver for the SIM module to
> allow drivers for said components to control the
> reset signal(s).
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Fabio Estevam Sept. 24, 2024, 11:16 a.m. UTC | #2 
On Sun, Sep 15, 2024 at 8:45 AM Laurentiu Mihalcea
<laurentiumihalcea111@gmail.com> wrote:
>
> Certain components can be reset via the SIM module.
> Add reset controller driver for the SIM module to
> allow drivers for said components to control the
> reset signal(s).
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

Who is the original author?

In the NXP kernel, the author is Liu Ying.

If that's still the case the Author field should contain Liu Ying's name.

Please double-check.
Fabio Estevam Sept. 24, 2024, 11:18 a.m. UTC | #3 
On Tue, Sep 24, 2024 at 8:16 AM Fabio Estevam <festevam@gmail.com> wrote:

> Who is the original author?
>
> In the NXP kernel, the author is Liu Ying.
>
> If that's still the case the Author field should contain Liu Ying's name.
>
> Please double-check.

Also, even if you are the author, there is still something wrong
as reported by checkpatch:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Laurentiu
Mihalcea <laurentiumihalcea111@gmail.com>' != 'Signed-off-by:
Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>'