| Message ID | 20240923074333.29552-1-sunyang.wu@jaguarmicro.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev,v3] netdev-offload: Fix incorrect comments. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 23 Sep 2024, at 9:43, Sunyang Wu via dev wrote: > This patch fixes incorrect comments. > > Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com> Thanks for the v3, however, there are two problems. - You are using tabs, and you should use spaces. - The lines are too long (if you replace the tabs with spaces). Please run ./utilities/checkpatch.py before submitting the next rev of the patch. Cheers, Eelco > --- > lib/netdev-offload.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lib/netdev-offload.h b/lib/netdev-offload.h > index 47f8e6f48..3c0130c7f 100644 > --- a/lib/netdev-offload.h > +++ b/lib/netdev-offload.h > @@ -46,11 +46,11 @@ struct ovs_action_push_tnl; > > /* Offload-capable (HW) netdev information */ > struct netdev_hw_info { > - bool oor; /* Out of Offload Resources ? */ > - atomic_bool miss_api_supported; /* hw_miss_packet_recover() supported.*/ > - int offload_count; /* Pending (non-offloaded) flow count */ > - int pending_count; /* Offloaded flow count */ > - OVSRCU_TYPE(void *) offload_data; /* Offload metadata. */ > + bool oor; /* Out of Offload Resources ? */ > + atomic_bool miss_api_supported; /* hw_miss_packet_recover() supported.*/ > + int offload_count; /* Offloaded flow count */ > + int pending_count; /* Pending (non-offloaded) flow count */ > + OVSRCU_TYPE(void *) offload_data; /* Offload metadata. */ > }; > > enum hw_info_type { > -- > 2.19.0.rc0.windows.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/lib/netdev-offload.h b/lib/netdev-offload.h index 47f8e6f48..3c0130c7f 100644 --- a/lib/netdev-offload.h +++ b/lib/netdev-offload.h @@ -46,11 +46,11 @@ struct ovs_action_push_tnl; /* Offload-capable (HW) netdev information */ struct netdev_hw_info { - bool oor; /* Out of Offload Resources ? */ - atomic_bool miss_api_supported; /* hw_miss_packet_recover() supported.*/ - int offload_count; /* Pending (non-offloaded) flow count */ - int pending_count; /* Offloaded flow count */ - OVSRCU_TYPE(void *) offload_data; /* Offload metadata. */ + bool oor; /* Out of Offload Resources ? */ + atomic_bool miss_api_supported; /* hw_miss_packet_recover() supported.*/ + int offload_count; /* Offloaded flow count */ + int pending_count; /* Pending (non-offloaded) flow count */ + OVSRCU_TYPE(void *) offload_data; /* Offload metadata. */ }; enum hw_info_type {
This patch fixes incorrect comments. Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com> --- lib/netdev-offload.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)