| Message ID | 20240923090000.36428-1-sunyang.wu@jaguarmicro.com |
|---|---|
| State | Rejected |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev,v3] netdev-linux: Fix the bug when sending packets with multi segments. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
References: <20240923090000.36428-1-sunyang.wu@jaguarmicro.com>
Bleep bloop. Greetings Sunyang Wu, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: "Fixes" tag is malformed.
Use the following format:
git log -1 --pretty=format:"Fixes: %h (\"%s\")" --abbrev=12 COMMIT_REF
11: Fixes: d19cf8bb798ff ("Replace sendmsg with sendmmsg in netdev_linux_send")
Lines checked: 111, Warnings: 0, Errors: 1
Please check this out. If you feel there has been an error, please email aconole@redhat.com
Thanks,
0-day Robot
On 9/23/24 11:00, Sunyang Wu via dev wrote: > When sending a packet with multiple segments, we use the length of the > entire message as the transmission length and the base address of the > first segment as the base address for the entire message. As a result, > the packet sent to the network device is incorrect, containing only the > content of the first segment. Hi, Sunyang Wu. There should be no way for a packet with multiple segments to enter OVS. How do you get such a packet? In general, multi-segment mbufs are not supported in OVS and many other parts of the code would need changes otherwise. Best regards, Ilya Maximets.
diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 4afbbe722..10ae91145 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -699,6 +699,24 @@ dp_packet_size(const struct dp_packet *b) return b->mbuf.pkt_len; } +static inline uint16_t +dp_packet_nb_segs(const struct dp_packet *b) +{ + return b->mbuf.nb_segs; +} + +static inline uint16_t +dp_packet_data_size(const struct dp_packet *b) +{ + return b->mbuf.data_len; +} + +static inline struct dp_packet * +dp_packet_next(const struct dp_packet *b ) +{ + return (struct dp_packet *)(b->mbuf.next); +} + static inline void dp_packet_set_size(struct dp_packet *b, uint32_t v) { @@ -778,6 +796,27 @@ dp_packet_size(const struct dp_packet *b) return b->size_; } +static inline uint16_t +dp_packet_nb_segs(const struct dp_packet *b) +{ + return 1; +} + +static inline struct dp_packet * +dp_packet_next(const struct dp_packet *b ) +{ + return NULL; +} + +/* + only for compile +*/ +static inline uint16_t +dp_packet_data_size(const struct dp_packet *b) +{ + return b->size_; +} + static inline void dp_packet_set_size(struct dp_packet *b, uint32_t v) { diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 0cd0850a3..ee4db2b5d 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -1690,8 +1690,25 @@ netdev_linux_tap_batch_send(struct netdev *netdev_, int mtu, size = dp_packet_size(packet); do { - retval = write(netdev->tap_fd, dp_packet_data(packet), size); - error = retval < 0 ? errno : 0; + if (dp_packet_nb_segs(packet) > 1) { + int data_size = 0; + void *buf = NULL; + + buf = xmalloc(size); + while (packet) { + memcpy(buf + data_size, + dp_packet_data(packet), + dp_packet_data_size(packet)); + data_size += dp_packet_data_size(packet); + packet = dp_packet_next(packet); + } + retval = write(netdev->tap_fd, buf, data_size); + error = retval < 0 ? errno : 0; + free(buf); + } else { + retval = write(netdev->tap_fd, dp_packet_data(packet), size); + error = retval < 0 ? errno : 0; + } } while (error == EINTR); if (error) {
When sending a packet with multiple segments, we use the length of the entire message as the transmission length and the base address of the first segment as the base address for the entire message. As a result, the packet sent to the network device is incorrect, containing only the content of the first segment. Fixes: d19cf8bb798ff ("Replace sendmsg with sendmmsg in netdev_linux_send") Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com> --- lib/dp-packet.h | 39 +++++++++++++++++++++++++++++++++++++++ lib/netdev-linux.c | 21 +++++++++++++++++++-- 2 files changed, 58 insertions(+), 2 deletions(-)