| Message ID | 1726282358-30995-1-git-send-email-junwang01@cestc.cn |
|---|---|
| State | Accepted |
| Commit | 2bf609f70b3b1c9fd4e2d8bf1ae04bc39ab08176 |
| Delegated to: | Eelco Chaudron |
| Headers | show |
| Series | [ovs-dev,v1] netdev-dpdk: Disable outer udp checksum offload for txgbe driver. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On Sat, Sep 14, 2024 at 5:06 AM Jun Wang <junwang01@cestc.cn> wrote: > > Fixing the issue of incorrect outer UDP checksum in packets sent by > the wangxun network card (driver is txgbe), we disabled > RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM. I don't have the hw, so I'll trust you on the topic :-). > > Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") > Reported-by: Jun Wang <junwang01@cestc.cn> > Nit: no need for an extra line here. > Signed-off-by: Jun Wang <junwang01@cestc.cn> Acked-by: David Marchand <david.marchand@redhat.com>
On 14 Sep 2024, at 4:52, Jun Wang wrote: > Fixing the issue of incorrect outer UDP checksum in packets sent by > the wangxun network card (driver is txgbe), we disabled > RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM. > > Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") > Reported-by: Jun Wang <junwang01@cestc.cn> > > Signed-off-by: Jun Wang <junwang01@cestc.cn> Thanks for the patch Jun, Like David mentioned, you do not need the extra new line, and if you are the fixer and finder of the bug, the Signed-off-by is enough. I also do not have the specific hardware to test, so will leave the patch in the queue till the end of the week, maybe someone who has the hardware can double check… Cheers, Eelco
On 16 Sep 2024, at 12:03, Eelco Chaudron wrote: > On 14 Sep 2024, at 4:52, Jun Wang wrote: > >> Fixing the issue of incorrect outer UDP checksum in packets sent by >> the wangxun network card (driver is txgbe), we disabled >> RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM. >> >> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") >> Reported-by: Jun Wang <junwang01@cestc.cn> >> >> Signed-off-by: Jun Wang <junwang01@cestc.cn> > > Thanks for the patch Jun, > > Like David mentioned, you do not need the extra new line, and if you are the fixer and finder of the bug, the Signed-off-by is enough. > > I also do not have the specific hardware to test, so will leave the patch in the queue till the end of the week, maybe someone who has the hardware can double check… Forgot to add my ACK :) Acked-by: Eelco Chaudron <echaudro@redhat.com>
On Sat, Sep 14, 2024 at 10:52:38AM +0800, Jun Wang wrote: > Fixing the issue of incorrect outer UDP checksum in packets sent by > the wangxun network card (driver is txgbe), we disabled > RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM. > > Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") > Reported-by: Jun Wang <junwang01@cestc.cn> > > Signed-off-by: Jun Wang <junwang01@cestc.cn> Modulo the minor feedback from others, which I assume can be addressed when applying the patch, this looks good to me. Acked-by: Simon Horman <horms@ovn.org>
On 9/16/24 12:08, Eelco Chaudron wrote: > > > On 16 Sep 2024, at 12:03, Eelco Chaudron wrote: > >> On 14 Sep 2024, at 4:52, Jun Wang wrote: >> >>> Fixing the issue of incorrect outer UDP checksum in packets sent by >>> the wangxun network card (driver is txgbe), we disabled >>> RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM. >>> >>> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") >>> Reported-by: Jun Wang <junwang01@cestc.cn> >>> >>> Signed-off-by: Jun Wang <junwang01@cestc.cn> >> >> Thanks for the patch Jun, >> >> Like David mentioned, you do not need the extra new line, and if you are the fixer and finder of the bug, the Signed-off-by is enough. >> >> I also do not have the specific hardware to test, so will leave the patch in the queue till the end of the week, maybe someone who has the hardware can double check… > > Forgot to add my ACK :) > > Acked-by: Eelco Chaudron <echaudro@redhat.com> > Hi, Eelco. I see you applied the patch, but you didn't reply to the list. Also, any reason why you didn't backport it? It sounds like it should go at least down to 3.3. Best regards, Ilya Maximets.
On 20 Sep 2024, at 19:12, Ilya Maximets wrote: > On 9/16/24 12:08, Eelco Chaudron wrote: >> >> >> On 16 Sep 2024, at 12:03, Eelco Chaudron wrote: >> >>> On 14 Sep 2024, at 4:52, Jun Wang wrote: >>> >>>> Fixing the issue of incorrect outer UDP checksum in packets sent by >>>> the wangxun network card (driver is txgbe), we disabled >>>> RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM. >>>> >>>> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") >>>> Reported-by: Jun Wang <junwang01@cestc.cn> >>>> >>>> Signed-off-by: Jun Wang <junwang01@cestc.cn> >>> >>> Thanks for the patch Jun, >>> >>> Like David mentioned, you do not need the extra new line, and if you are the fixer and finder of the bug, the Signed-off-by is enough. >>> >>> I also do not have the specific hardware to test, so will leave the patch in the queue till the end of the week, maybe someone who has the hardware can double check… >> >> Forgot to add my ACK :) >> >> Acked-by: Eelco Chaudron <echaudro@redhat.com> >> > > Hi, Eelco. I see you applied the patch, but you didn't reply to the list. > > Also, any reason why you didn't backport it? It sounds like it should > go at least down to 3.3. I was planning on doing this after Kevin committed his patches on Friday, but it slipped my mind. Will do it today and report back once it’s done… //Eelco
On 23 Sep 2024, at 8:18, Eelco Chaudron wrote: > On 20 Sep 2024, at 19:12, Ilya Maximets wrote: > >> On 9/16/24 12:08, Eelco Chaudron wrote: >>> >>> >>> On 16 Sep 2024, at 12:03, Eelco Chaudron wrote: >>> >>>> On 14 Sep 2024, at 4:52, Jun Wang wrote: >>>> >>>>> Fixing the issue of incorrect outer UDP checksum in packets sent by >>>>> the wangxun network card (driver is txgbe), we disabled >>>>> RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM. >>>>> >>>>> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") >>>>> Reported-by: Jun Wang <junwang01@cestc.cn> >>>>> >>>>> Signed-off-by: Jun Wang <junwang01@cestc.cn> >>>> >>>> Thanks for the patch Jun, >>>> >>>> Like David mentioned, you do not need the extra new line, and if you are the fixer and finder of the bug, the Signed-off-by is enough. >>>> >>>> I also do not have the specific hardware to test, so will leave the patch in the queue till the end of the week, maybe someone who has the hardware can double check… >>> >>> Forgot to add my ACK :) >>> >>> Acked-by: Eelco Chaudron <echaudro@redhat.com> >>> >> >> Hi, Eelco. I see you applied the patch, but you didn't reply to the list. >> >> Also, any reason why you didn't backport it? It sounds like it should >> go at least down to 3.3. > > I was planning on doing this after Kevin committed his patches on Friday, but it slipped my mind. > > Will do it today and report back once it’s done… Patch has been applied to main, and backported to 3.3 and 3.4. Cheers, Eelco
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index a3878d2..e454a4a 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1355,12 +1355,13 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev) if (!strcmp(info.driver_name, "net_ice") || !strcmp(info.driver_name, "net_i40e") - || !strcmp(info.driver_name, "net_iavf")) { + || !strcmp(info.driver_name, "net_iavf") + || !strcmp(info.driver_name, "net_txgbe")) { /* FIXME: Driver advertises the capability but doesn't seem * to actually support it correctly. Can remove this once * the driver is fixed on DPDK side. */ VLOG_INFO("%s: disabled Tx outer udp checksum offloads for a " - "net/ice, net/i40e or net/iavf port.", + "net/ice, net/i40e, net/iavf or net/txgbe port.", netdev_get_name(&dev->up)); info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; }
Fixing the issue of incorrect outer UDP checksum in packets sent by the wangxun network card (driver is txgbe), we disabled RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM. Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") Reported-by: Jun Wang <junwang01@cestc.cn> Signed-off-by: Jun Wang <junwang01@cestc.cn> --- lib/netdev-dpdk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)