| Message ID | 7d0c7283-1a62-4c19-b5a1-43e09ab38af9@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | rs6000, Fix test builtins-1-p10-runnable.c | expand |
GCC maintainers: Please ignore this patch. Attached the wrong patch to the message. Sorry for the noise. Carl On 9/19/24 4:40 PM, Carl Love wrote: > GCC maintainers: > > This patch removes an expected value change that was made to verify > the error checking for the test was working. Apparently, it didn't > get removed from the final patch. > > The patch fixes the single test error in the builtins-1-10-runnable.c > test. > > The patch was run on a Power 10. > > Please let me know if the patch is acceptable for mainline. Thanks. > > Carl Love > > ----------------------------------------------------------------- > rs6000, Fix test builtins-1-p10-runnable.c > > The first element of the expected result was apparently changed > for testing purposes. The change didn't get removed before the > commit. > > The issue was introduced in commit: > > commit f1ad419ebfdcfaf26117e069b10bd1b154276049 > Author: Carl Love <cel@us.ibm.com> > Date: Fri Sep 4 19:24:22 2020 -0500 > > rs6000, vector integer multiply/divide/modulo instructions > > Remove the test input. > > gcc/testsuite/ChangeLog: > > * gcc.target/powerpc/builtins-1-p10-runnable.c: Remove > expected value for testing. Uncomment correct expected > result. > --- > gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git > a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c > b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c > index 222c8b3a409..5402852f82b 100644 > --- a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c > +++ b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c > @@ -281,8 +281,7 @@ int main() > /* Signed word multiply high */ > i_arg1 = (vector int){ 2147483648, 2147483648, 2147483648, > 2147483648 }; > i_arg2 = (vector int){ 2, 3, 4, 5}; > - // vec_i_expected = (vector int){-1, -2, -2, -3}; > - vec_i_expected = (vector int){1, -2, -2, -3}; > + vec_i_expected = (vector int){-1, -2, -2, -3}; > > vec_i_result = vec_mulh (i_arg1, i_arg2); >
diff --git a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c index 222c8b3a409..5402852f82b 100644 --- a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c +++ b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c @@ -281,8 +281,7 @@ int main() /* Signed word multiply high */ i_arg1 = (vector int){ 2147483648, 2147483648, 2147483648, 2147483648 }; i_arg2 = (vector int){ 2, 3, 4, 5}; - // vec_i_expected = (vector int){-1, -2, -2, -3}; - vec_i_expected = (vector int){1, -2, -2, -3}; + vec_i_expected = (vector int){-1, -2, -2, -3}; vec_i_result = vec_mulh (i_arg1, i_arg2);