| Message ID | 20240916091039.3584505-2-ryan_chen@aspeedtech.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for AST2700 clk driver | expand |
On 16/09/2024 11:10, Ryan Chen wrote: > Add compatible support for AST2700 clk, reset, pinctrl, silicon-id for AST2700 scu. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > --- > .../devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > index 86ee69c0f45b..127a357051cd 100644 > --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > @@ -9,6 +9,8 @@ title: Aspeed System Control Unit > description: > The Aspeed System Control Unit manages the global behaviour of the SoC, > configuring elements such as clocks, pinmux, and reset. > + In AST2700 SOC which has two soc connection, each soc have its own scu > + register control, ast2700-scu0 for soc0, ast2700-scu1 for soc1. > > maintainers: > - Joel Stanley <joel@jms.id.au> > @@ -21,6 +23,8 @@ properties: > - aspeed,ast2400-scu > - aspeed,ast2500-scu > - aspeed,ast2600-scu > + - aspeed,ast2700-scu0 > + - aspeed,ast2700-scu1 > - const: syscon > - const: simple-mfd > > @@ -30,10 +34,12 @@ properties: > ranges: true > > '#address-cells': > - const: 1 > + minimum: 1 > + maximum: 2 > > '#size-cells': > - const: 1 > + minimum: 1 > + maximum: 2 Why do the children have 64 bit addressing? > > '#clock-cells': > const: 1 > @@ -56,6 +62,8 @@ patternProperties: > - aspeed,ast2400-pinctrl > - aspeed,ast2500-pinctrl > - aspeed,ast2600-pinctrl > + - aspeed,ast2700-soc0-pinctrl > + - aspeed,ast2700-soc1-pinctrl Are these devices different? Where is this binding documented (fully)? Provide link to lore patch in the changelog. > > required: > - compatible > @@ -76,6 +84,7 @@ patternProperties: > - aspeed,ast2400-silicon-id > - aspeed,ast2500-silicon-id > - aspeed,ast2600-silicon-id > + - aspeed,ast2700-silicon-id This one is fine. > - const: aspeed,silicon-id > > reg: Best regards, Krzysztof
> Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: aspeed: support for AST2700 > > On 16/09/2024 11:10, Ryan Chen wrote: > > Add compatible support for AST2700 clk, reset, pinctrl, silicon-id for AST2700 > scu. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/sub > mitting-patches.rst#L597 Will update it. > > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > --- > > .../devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml | 13 > > +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > > b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > > index 86ee69c0f45b..127a357051cd 100644 > > --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > > +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > > @@ -9,6 +9,8 @@ title: Aspeed System Control Unit > > description: > > The Aspeed System Control Unit manages the global behaviour of the > SoC, > > configuring elements such as clocks, pinmux, and reset. > > + In AST2700 SOC which has two soc connection, each soc have its own > > + scu register control, ast2700-scu0 for soc0, ast2700-scu1 for soc1. > > > > maintainers: > > - Joel Stanley <joel@jms.id.au> > > @@ -21,6 +23,8 @@ properties: > > - aspeed,ast2400-scu > > - aspeed,ast2500-scu > > - aspeed,ast2600-scu > > + - aspeed,ast2700-scu0 > > + - aspeed,ast2700-scu1 > > - const: syscon > > - const: simple-mfd > > > > @@ -30,10 +34,12 @@ properties: > > ranges: true > > > > '#address-cells': > > - const: 1 > > + minimum: 1 > > + maximum: 2 > > > > '#size-cells': > > - const: 1 > > + minimum: 1 > > + maximum: 2 > > Why do the children have 64 bit addressing? AST2700 is 64bit address, so it also. It is children example for pinctrl. syscon1: syscon@14c02000 { compatible = "aspeed,ast2700-scu1", "syscon", "simple-mfd"; reg = <0x0 0x14c02000 0x0 0x1000>; ranges = <0x0 0x0 0x0 0x14c02000 0x0 0x1000>; #address-cells = <2>; #size-cells = <2>; #clock-cells = <1>; #reset-cells = <1>; pinctrl1: pinctrl@400 { compatible = "aspeed,ast2700-soc1-pinctrl"; reg = <0x0 0x400 0x0 0x100>; }; }; > > > > > '#clock-cells': > > const: 1 > > @@ -56,6 +62,8 @@ patternProperties: > > - aspeed,ast2400-pinctrl > > - aspeed,ast2500-pinctrl > > - aspeed,ast2600-pinctrl > > + - aspeed,ast2700-soc0-pinctrl > > + - aspeed,ast2700-soc1-pinctrl > > Are these devices different? > > Where is this binding documented (fully)? Provide link to lore patch in the > changelog. I will remove it in next submit. It will add in another pinctrl submit patch. > > > > > required: > > - compatible > > @@ -76,6 +84,7 @@ patternProperties: > > - aspeed,ast2400-silicon-id > > - aspeed,ast2500-silicon-id > > - aspeed,ast2600-silicon-id > > + - aspeed,ast2700-silicon-id > > This one is fine. Thanks. > > > - const: aspeed,silicon-id > > > > reg: > > Best regards, > Krzysztof
On 19/09/2024 08:05, Ryan Chen wrote: >>> diff --git >>> a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml >>> b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml >>> index 86ee69c0f45b..127a357051cd 100644 >>> --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml >>> +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml >>> @@ -9,6 +9,8 @@ title: Aspeed System Control Unit >>> description: >>> The Aspeed System Control Unit manages the global behaviour of the >> SoC, >>> configuring elements such as clocks, pinmux, and reset. >>> + In AST2700 SOC which has two soc connection, each soc have its own >>> + scu register control, ast2700-scu0 for soc0, ast2700-scu1 for soc1. >>> >>> maintainers: >>> - Joel Stanley <joel@jms.id.au> >>> @@ -21,6 +23,8 @@ properties: >>> - aspeed,ast2400-scu >>> - aspeed,ast2500-scu >>> - aspeed,ast2600-scu >>> + - aspeed,ast2700-scu0 >>> + - aspeed,ast2700-scu1 >>> - const: syscon >>> - const: simple-mfd >>> >>> @@ -30,10 +34,12 @@ properties: >>> ranges: true >>> >>> '#address-cells': >>> - const: 1 >>> + minimum: 1 >>> + maximum: 2 >>> >>> '#size-cells': >>> - const: 1 >>> + minimum: 1 >>> + maximum: 2 >> >> Why do the children have 64 bit addressing? > > AST2700 is 64bit address, so it also. But why do they need it? Best regards, Krzysztof
> Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: aspeed: support for AST2700 > > On 19/09/2024 08:05, Ryan Chen wrote: > >>> diff --git > >>> a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > >>> b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > >>> index 86ee69c0f45b..127a357051cd 100644 > >>> --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > >>> +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > >>> @@ -9,6 +9,8 @@ title: Aspeed System Control Unit > >>> description: > >>> The Aspeed System Control Unit manages the global behaviour of > >>> the > >> SoC, > >>> configuring elements such as clocks, pinmux, and reset. > >>> + In AST2700 SOC which has two soc connection, each soc have its > >>> + own scu register control, ast2700-scu0 for soc0, ast2700-scu1 for > soc1. > >>> > >>> maintainers: > >>> - Joel Stanley <joel@jms.id.au> > >>> @@ -21,6 +23,8 @@ properties: > >>> - aspeed,ast2400-scu > >>> - aspeed,ast2500-scu > >>> - aspeed,ast2600-scu > >>> + - aspeed,ast2700-scu0 > >>> + - aspeed,ast2700-scu1 > >>> - const: syscon > >>> - const: simple-mfd > >>> > >>> @@ -30,10 +34,12 @@ properties: > >>> ranges: true > >>> > >>> '#address-cells': > >>> - const: 1 > >>> + minimum: 1 > >>> + maximum: 2 > >>> > >>> '#size-cells': > >>> - const: 1 > >>> + minimum: 1 > >>> + maximum: 2 > >> > >> Why do the children have 64 bit addressing? > > > > AST2700 is 64bit address, so it also. > > But why do they need it? > Sorry, I may not understand your point. Since address-cell = <2>, Do you mean size-cell still 1? If yes. I do the dts check it need size-cells=<2>, when I do address-cells = <2> > > Best regards, > Krzysztof
On 19/09/2024 09:13, Ryan Chen wrote: >> Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: aspeed: support for AST2700 >> >> On 19/09/2024 08:05, Ryan Chen wrote: >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml >>>>> b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml >>>>> index 86ee69c0f45b..127a357051cd 100644 >>>>> --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml >>>>> +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml >>>>> @@ -9,6 +9,8 @@ title: Aspeed System Control Unit >>>>> description: >>>>> The Aspeed System Control Unit manages the global behaviour of >>>>> the >>>> SoC, >>>>> configuring elements such as clocks, pinmux, and reset. >>>>> + In AST2700 SOC which has two soc connection, each soc have its >>>>> + own scu register control, ast2700-scu0 for soc0, ast2700-scu1 for >> soc1. >>>>> >>>>> maintainers: >>>>> - Joel Stanley <joel@jms.id.au> >>>>> @@ -21,6 +23,8 @@ properties: >>>>> - aspeed,ast2400-scu >>>>> - aspeed,ast2500-scu >>>>> - aspeed,ast2600-scu >>>>> + - aspeed,ast2700-scu0 >>>>> + - aspeed,ast2700-scu1 >>>>> - const: syscon >>>>> - const: simple-mfd >>>>> >>>>> @@ -30,10 +34,12 @@ properties: >>>>> ranges: true >>>>> >>>>> '#address-cells': >>>>> - const: 1 >>>>> + minimum: 1 >>>>> + maximum: 2 >>>>> >>>>> '#size-cells': >>>>> - const: 1 >>>>> + minimum: 1 >>>>> + maximum: 2 >>>> >>>> Why do the children have 64 bit addressing? >>> >>> AST2700 is 64bit address, so it also. >> >> But why do they need it? >> > Sorry, I may not understand your point. I asked why do you think children require 64-bit addressing, instead of working with existing 32-bit address. > Since address-cell = <2>, Do you mean size-cell still 1? No... although that's another point, how bug address size is there? For the children? > If yes. I do the dts check it need size-cells=<2>, when I do address-cells = <2> Well, I talk about bus and children addressing. It's kind of obvious that changing one property means using different reg... Best regards, Krzysztof
> Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: aspeed: support for AST2700 > > On 19/09/2024 09:13, Ryan Chen wrote: > >> Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: aspeed: support for > >> AST2700 > >> > >> On 19/09/2024 08:05, Ryan Chen wrote: > >>>>> diff --git > >>>>> a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > >>>>> b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > >>>>> index 86ee69c0f45b..127a357051cd 100644 > >>>>> --- > >>>>> a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > >>>>> +++ > b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yam > >>>>> +++ l > >>>>> @@ -9,6 +9,8 @@ title: Aspeed System Control Unit > >>>>> description: > >>>>> The Aspeed System Control Unit manages the global behaviour of > >>>>> the > >>>> SoC, > >>>>> configuring elements such as clocks, pinmux, and reset. > >>>>> + In AST2700 SOC which has two soc connection, each soc have its > >>>>> + own scu register control, ast2700-scu0 for soc0, ast2700-scu1 > >>>>> + for > >> soc1. > >>>>> > >>>>> maintainers: > >>>>> - Joel Stanley <joel@jms.id.au> @@ -21,6 +23,8 @@ properties: > >>>>> - aspeed,ast2400-scu > >>>>> - aspeed,ast2500-scu > >>>>> - aspeed,ast2600-scu > >>>>> + - aspeed,ast2700-scu0 > >>>>> + - aspeed,ast2700-scu1 > >>>>> - const: syscon > >>>>> - const: simple-mfd > >>>>> > >>>>> @@ -30,10 +34,12 @@ properties: > >>>>> ranges: true > >>>>> > >>>>> '#address-cells': > >>>>> - const: 1 > >>>>> + minimum: 1 > >>>>> + maximum: 2 > >>>>> > >>>>> '#size-cells': > >>>>> - const: 1 > >>>>> + minimum: 1 > >>>>> + maximum: 2 > >>>> > >>>> Why do the children have 64 bit addressing? > >>> > >>> AST2700 is 64bit address, so it also. > >> > >> But why do they need it? > >> > > Sorry, I may not understand your point. > > I asked why do you think children require 64-bit addressing, instead of working > with existing 32-bit address. > > > Since address-cell = <2>, Do you mean size-cell still 1? > > No... although that's another point, how bug address size is there? For the > children? > > > If yes. I do the dts check it need size-cells=<2>, when I do > > address-cells = <2> > > Well, I talk about bus and children addressing. It's kind of obvious that > changing one property means using different reg... > Understood your point, I don’t use so much for size, size-cell = <1> is enough, will keep <1> > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml index 86ee69c0f45b..127a357051cd 100644 --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml @@ -9,6 +9,8 @@ title: Aspeed System Control Unit description: The Aspeed System Control Unit manages the global behaviour of the SoC, configuring elements such as clocks, pinmux, and reset. + In AST2700 SOC which has two soc connection, each soc have its own scu + register control, ast2700-scu0 for soc0, ast2700-scu1 for soc1. maintainers: - Joel Stanley <joel@jms.id.au> @@ -21,6 +23,8 @@ properties: - aspeed,ast2400-scu - aspeed,ast2500-scu - aspeed,ast2600-scu + - aspeed,ast2700-scu0 + - aspeed,ast2700-scu1 - const: syscon - const: simple-mfd @@ -30,10 +34,12 @@ properties: ranges: true '#address-cells': - const: 1 + minimum: 1 + maximum: 2 '#size-cells': - const: 1 + minimum: 1 + maximum: 2 '#clock-cells': const: 1 @@ -56,6 +62,8 @@ patternProperties: - aspeed,ast2400-pinctrl - aspeed,ast2500-pinctrl - aspeed,ast2600-pinctrl + - aspeed,ast2700-soc0-pinctrl + - aspeed,ast2700-soc1-pinctrl required: - compatible @@ -76,6 +84,7 @@ patternProperties: - aspeed,ast2400-silicon-id - aspeed,ast2500-silicon-id - aspeed,ast2600-silicon-id + - aspeed,ast2700-silicon-id - const: aspeed,silicon-id reg:
Add compatible support for AST2700 clk, reset, pinctrl, silicon-id for AST2700 scu. Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- .../devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)