| Message ID | 20240821055146.46029-1-ende.tan@starfivetech.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/libkcapi: update site path | expand |
En De, All, Thanks for this patch. On 2024-08-21 13:51 +0800, ende.tan@starfivetech.com spake thusly: > From: Tan En De <ende.tan@starfivetech.com> > > Update the site path to reflect the recent organizational changes on the > chronox.de website. The way they reorganised the releases is a bit annoying. Indeed, only the latest release is available with the new URL format, while older releases are all only available with another format, e.g.: http://www.chronox.de/libkcapi/releases/1.5.0/libkcapi-1.5.0.tar.xz http://www.chronox.de/libkcapi/releases/historic/libkcap-1.4.0.tqr.xz This is annoying, because t means the URL we use is wrong as soon as a newer release is cut and published, and thus all previous Buildroot versions suddenly stop being able to download the libkcapi version they knew about... I would suggest we switch to using their GitHub repo as the source, and using git for the download. > Fixes: > - http://autobuild.buildroot.org/results/77243633783ac2d037d15d7e9c01384781fe700e > > Signed-off-by: Tan En De <ende.tan@starfivetech.com> In the meantime, applied to master, thanks. Regards, Yann E. MORIN. > --- > package/libkcapi/libkcapi.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/libkcapi/libkcapi.mk b/package/libkcapi/libkcapi.mk > index 11462d6e2a..7a79dd55ae 100644 > --- a/package/libkcapi/libkcapi.mk > +++ b/package/libkcapi/libkcapi.mk > @@ -6,7 +6,7 @@ > > LIBKCAPI_VERSION = 1.5.0 > LIBKCAPI_SOURCE = libkcapi-$(LIBKCAPI_VERSION).tar.xz > -LIBKCAPI_SITE = http://www.chronox.de/libkcapi > +LIBKCAPI_SITE = http://www.chronox.de/libkcapi/releases/$(LIBKCAPI_VERSION) > LIBKCAPI_AUTORECONF = YES > LIBKCAPI_INSTALL_STAGING = YES > LIBKCAPI_LICENSE = BSD-3-Clause (library), BSD-3-Clause or GPL-2.0 (programs) > -- > 2.34.1 >
Stephan, All, On 2024-08-21 10:18 +0200, Stephan Mueller spake thusly: > Am Mittwoch, 21. August 2024, 09:29:15 MESZ schrieb Yann E. MORIN: > > On 2024-08-21 13:51 +0800, ende.tan@starfivetech.com spake thusly: > > > From: Tan En De <ende.tan@starfivetech.com> > > > Update the site path to reflect the recent organizational changes on the > > > chronox.de website. [--SNIP--] > > This is annoying, because t means the URL we use is wrong as soon as a > > newer release is cut and published, and thus all previous Buildroot > > versions suddenly stop being able to download the libkcapi version they > > knew about... > Ok do you want me to make the old versions available also with the the > versioning schema? That would be awesome if you could provide stable URLs, indeed! > > I would suggest we switch to using their GitHub repo as the source, and > > using git for the download. > That would work too. I am open for suggestions. If you can provide stable URLs, that would be better. Thanks a lot for the feedback, and for considering our needs! 👍 Regards, Yann E. MORIN. > > > Fixes: > > > - > > > http://autobuild.buildroot.org/results/77243633783ac2d037d15d7e9c01384781 > > > fe700e > > > > > > Signed-off-by: Tan En De <ende.tan@starfivetech.com> > > > > In the meantime, applied to master, thanks. > > > > Regards, > > Yann E. MORIN. > > > > > --- > > > > > > package/libkcapi/libkcapi.mk | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/package/libkcapi/libkcapi.mk b/package/libkcapi/libkcapi.mk > > > index 11462d6e2a..7a79dd55ae 100644 > > > --- a/package/libkcapi/libkcapi.mk > > > +++ b/package/libkcapi/libkcapi.mk > > > @@ -6,7 +6,7 @@ > > > > > > LIBKCAPI_VERSION = 1.5.0 > > > LIBKCAPI_SOURCE = libkcapi-$(LIBKCAPI_VERSION).tar.xz > > > > > > -LIBKCAPI_SITE = http://www.chronox.de/libkcapi > > > +LIBKCAPI_SITE = > > > http://www.chronox.de/libkcapi/releases/$(LIBKCAPI_VERSION)> > > > LIBKCAPI_AUTORECONF = YES > > > LIBKCAPI_INSTALL_STAGING = YES > > > LIBKCAPI_LICENSE = BSD-3-Clause (library), BSD-3-Clause or GPL-2.0 > > > (programs) > > > Ciao > Stephan > >
Stephan, All, On 2024-08-21 11:26 +0200, Stephan Mueller spake thusly: > Am Mittwoch, 21. August 2024, 11:06:40 MESZ schrieb Yann E. MORIN: > > That would be awesome if you could provide stable URLs, indeed! > Ok, that is what I will do then - I will reply later today once I moved it. Fantastic, thanks a lot! :-) [--SNIP--] > Sorry for the mess, but I wanted to make my web site nicer and the web site > tool did not work well with the old versioning schema. Thus the switch. Basically, we need things to be stable and reproducible: once we know where to fetch something, it is important that is stays in the same place in the foreseeable future. > Anyhow, as I may not know all the needs of distro management, open an issue if > you have other such issues :-) Thank you! :-) Regards, Yann E. MORIN.
Stephan, All, On 2024-08-21 13:35 +0200, Stephan Müller spake thusly: > Have a look now. Although I have not updated the HTML pages, the different > releases are now available at: > http://www.chronox.de/libkcapi/releases/VERSION/libkcapi-VERSION.tar.xz[.asc] Yes, it works. Thanks a lot for adapting your site. :-) Regards, Yann E. MORIN.
>>>>> "ende" == ende tan <ende.tan@starfivetech.com> writes: > From: Tan En De <ende.tan@starfivetech.com> > Update the site path to reflect the recent organizational changes on the > chronox.de website. > Fixes: > - http://autobuild.buildroot.org/results/77243633783ac2d037d15d7e9c01384781fe700e > Signed-off-by: Tan En De <ende.tan@starfivetech.com> Committed to 2024.02.x, thanks.
diff --git a/package/libkcapi/libkcapi.mk b/package/libkcapi/libkcapi.mk index 11462d6e2a..7a79dd55ae 100644 --- a/package/libkcapi/libkcapi.mk +++ b/package/libkcapi/libkcapi.mk @@ -6,7 +6,7 @@ LIBKCAPI_VERSION = 1.5.0 LIBKCAPI_SOURCE = libkcapi-$(LIBKCAPI_VERSION).tar.xz -LIBKCAPI_SITE = http://www.chronox.de/libkcapi +LIBKCAPI_SITE = http://www.chronox.de/libkcapi/releases/$(LIBKCAPI_VERSION) LIBKCAPI_AUTORECONF = YES LIBKCAPI_INSTALL_STAGING = YES LIBKCAPI_LICENSE = BSD-3-Clause (library), BSD-3-Clause or GPL-2.0 (programs)