| Message ID | 20240913121110.1611340-1-Shyam-sundar.S-k@amd.com |
|---|---|
| Headers | show |
| Series | Introduce initial AMD ASF Controller driver support | expand |
On Fri, Sep 13, 2024 at 05:41:02PM +0530, Shyam Sundar S K wrote: > The AMD ASF (Alert Standard Format) function block is essentially an SMBus > controller with built-in ASF functionality. It features two pins SCL1 and > SDA1 that facilitate communication with other SMBus devices. This dual > capability allows the ASF controller to issue generic SMBus packets and > communicate with the DASH controller using MCTP over ASF. Additionally, > the ASF controller supports remote commands defined by the ASF > specification, such as shutdown, reset, power-up, and power-down, without > requiring any software interaction. > > The concept is to enable a remote system to communicate with the target > system over the network. The local network controller, such as an Ethernet > MAC, receives remote packets and relays the commands to the FCH > (Fusion Controller Hub) through the ASF. Examples of these commands > include shutdown and reset. Since ASF uses the SMBus protocol, this > controller can be configured as a secondary SMBus controller. > > This series of updates focuses on extending the i2c-piix4 driver to > support the ASF driver by exporting several functions from the i2c-piix4 > driver, allowing the AMD ASF driver to leverage existing functionalities. > Additionally, this change incorporates core ASF functionality, including > ACPI integration and the implementation of i2c_algorithm callbacks for ASF > operations. ACPI code is much better now, but can be even better. See my individual comments.
On 9/14/2024 00:50, Andy Shevchenko wrote: > On Fri, Sep 13, 2024 at 05:41:02PM +0530, Shyam Sundar S K wrote: >> The AMD ASF (Alert Standard Format) function block is essentially an SMBus >> controller with built-in ASF functionality. It features two pins SCL1 and >> SDA1 that facilitate communication with other SMBus devices. This dual >> capability allows the ASF controller to issue generic SMBus packets and >> communicate with the DASH controller using MCTP over ASF. Additionally, >> the ASF controller supports remote commands defined by the ASF >> specification, such as shutdown, reset, power-up, and power-down, without >> requiring any software interaction. >> >> The concept is to enable a remote system to communicate with the target >> system over the network. The local network controller, such as an Ethernet >> MAC, receives remote packets and relays the commands to the FCH >> (Fusion Controller Hub) through the ASF. Examples of these commands >> include shutdown and reset. Since ASF uses the SMBus protocol, this >> controller can be configured as a secondary SMBus controller. >> >> This series of updates focuses on extending the i2c-piix4 driver to >> support the ASF driver by exporting several functions from the i2c-piix4 >> driver, allowing the AMD ASF driver to leverage existing functionalities. >> Additionally, this change incorporates core ASF functionality, including >> ACPI integration and the implementation of i2c_algorithm callbacks for ASF >> operations. > > ACPI code is much better now, but can be even better. > See my individual comments. > Thank you for the feedback and apologies for the delay. I have few questions that needs a bit of clarity. Please see the individual patches. Thanks, Shyam
The AMD ASF (Alert Standard Format) function block is essentially an SMBus controller with built-in ASF functionality. It features two pins SCL1 and SDA1 that facilitate communication with other SMBus devices. This dual capability allows the ASF controller to issue generic SMBus packets and communicate with the DASH controller using MCTP over ASF. Additionally, the ASF controller supports remote commands defined by the ASF specification, such as shutdown, reset, power-up, and power-down, without requiring any software interaction. The concept is to enable a remote system to communicate with the target system over the network. The local network controller, such as an Ethernet MAC, receives remote packets and relays the commands to the FCH (Fusion Controller Hub) through the ASF. Examples of these commands include shutdown and reset. Since ASF uses the SMBus protocol, this controller can be configured as a secondary SMBus controller. This series of updates focuses on extending the i2c-piix4 driver to support the ASF driver by exporting several functions from the i2c-piix4 driver, allowing the AMD ASF driver to leverage existing functionalities. Additionally, this change incorporates core ASF functionality, including ACPI integration and the implementation of i2c_algorithm callbacks for ASF operations. v5: ---- - use platform_get_resource to the ACPI resources of ASF device - add relavant headers - remove unnecessary headers - use devm_* wherever applicable - update commit messages to patch 1 and 3 in series v4 v4: ---- - Carve out a separate _HID driver for ASF - Export i2c_piix4 driver functions as library - Make function signature changes within i2c-pixx4 driver - Use dev_err_probe() in probe() - Address other remarks from Andy. v3: ---- - Fix LKP reported issue by adding 'depends on X86' - Drop callback when using acpi_dev_get_resources() - Address other remarks from Andy on v2. v2: ---- - Change function signature from u8 to enum - Use default case in switch - Use acpi_dev_get_resources() and drop devm_kzalloc() usage - Fix LKP reported issues - Address other minor remarks from Andy and Andi Shyti Shyam Sundar S K (8): i2c: piix4: Change the parameter list of piix4_transaction function i2c: piix4: Move i2c_piix4 macros and structures to common header i2c: piix4: Export i2c_piix4 driver functions as library i2c: amd-asf: Add ACPI support for AMD ASF Controller i2c: amd-asf: Add i2c_algorithm operations to support AMD ASF with SMBus i2c: amd-asf: Add routine to handle the ASF slave process i2c: amd-asf: Clear remote IRR bit to get successive interrupt MAINTAINERS: Add AMD ASF driver entry MAINTAINERS | 8 +- drivers/i2c/busses/Kconfig | 17 ++ drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-amd-asf-plat.c | 372 ++++++++++++++++++++++++++ drivers/i2c/busses/i2c-piix4.c | 56 ++-- drivers/i2c/busses/i2c-piix4.h | 45 ++++ 6 files changed, 465 insertions(+), 34 deletions(-) create mode 100644 drivers/i2c/busses/i2c-amd-asf-plat.c create mode 100644 drivers/i2c/busses/i2c-piix4.h