| Message ID | 20240912-sitaraupstream-v2-3-2101323d3fa5@baylibre.com |
|---|---|
| State | Accepted |
| Commit | ce68e2be7e2318d7982da965fa1be1c3a1a1eb3a |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Add Android 14 bootflow support for AM62X and AM62P board | expand |
Hi Guillaume! On September 12, 2024 thus sayeth Guillaume La Roque: > From: Mattijs Korpershoek <mkorpershoek@baylibre.com> > > When CONFIG_BOOTMETH_ANDROID is set, enable Android boot flow support. > > To build for AM62Px for Android, we can re-use > the am62x_a53_android.config fragment when building A53 bootloaders: > > $ make am62px_evm_a53_defconfig > $ make am62x_a53_android.config > $ make > > Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> > --- > board/ti/am62px/am62px.env | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/board/ti/am62px/am62px.env b/board/ti/am62px/am62px.env > index f8b6aff2c2fd..7ef54079aa8d 100644 > --- a/board/ti/am62px/am62px.env > +++ b/board/ti/am62px/am62px.env > @@ -13,3 +13,8 @@ mmcdev=1 > bootpart=1:2 > bootdir=/boot > rd_spec=- > + > +#if CONFIG_BOOTMETH_ANDROID > +#include <env/ti/android.env> > +adtb_idx=3 > +#endif > \ No newline at end of file It's odd that checkpatch.pl didn't complain about this. Or maybe it has never complained about newlines? my git hook script didn't complain so IDK. Anywho just wanted to point out the nitpick ;) ~Bryan
Hi Bryan, Le 16/09/2024 à 15:27, Bryan Brattlof a écrit : > Hi Guillaume! > > On September 12, 2024 thus sayeth Guillaume La Roque: >> From: Mattijs Korpershoek <mkorpershoek@baylibre.com> >> >> When CONFIG_BOOTMETH_ANDROID is set, enable Android boot flow support. >> >> To build for AM62Px for Android, we can re-use >> the am62x_a53_android.config fragment when building A53 bootloaders: >> >> $ make am62px_evm_a53_defconfig >> $ make am62x_a53_android.config >> $ make >> >> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> >> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> >> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> >> --- >> board/ti/am62px/am62px.env | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/board/ti/am62px/am62px.env b/board/ti/am62px/am62px.env >> index f8b6aff2c2fd..7ef54079aa8d 100644 >> --- a/board/ti/am62px/am62px.env >> +++ b/board/ti/am62px/am62px.env >> @@ -13,3 +13,8 @@ mmcdev=1 >> bootpart=1:2 >> bootdir=/boot >> rd_spec=- >> + >> +#if CONFIG_BOOTMETH_ANDROID >> +#include <env/ti/android.env> >> +adtb_idx=3 >> +#endif >> \ No newline at end of file > It's odd that checkpatch.pl didn't complain about this. Or maybe it has > never complained about newlines? my git hook script didn't complain so > IDK. Anywho just wanted to point out the nitpick ;) i run checkpatch with b4 tool and script not return any error on this. i will change settings to not add this for the future . thanks to point me this . Guillaume > ~Bryan
diff --git a/board/ti/am62px/am62px.env b/board/ti/am62px/am62px.env index f8b6aff2c2fd..7ef54079aa8d 100644 --- a/board/ti/am62px/am62px.env +++ b/board/ti/am62px/am62px.env @@ -13,3 +13,8 @@ mmcdev=1 bootpart=1:2 bootdir=/boot rd_spec=- + +#if CONFIG_BOOTMETH_ANDROID +#include <env/ti/android.env> +adtb_idx=3 +#endif \ No newline at end of file