diff mbox series

[1/2] dt-bindings: phy: bcm-ns-usb2-phy: drop deprecated variant

Message ID 20240913044557.28315-1-zajec5@gmail.com
State Handled Elsewhere
Headers show
Series [1/2] dt-bindings: phy: bcm-ns-usb2-phy: drop deprecated variant | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Rafał Miłecki Sept. 13, 2024, 4:45 a.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

The old binding variant (the one covering whole DMU block) was
deprecated 3 years ago. Linux kernel was warning when using it for
similar amount of time.

There aren't any known Northstar devices with bootloader providing DT to
operating system. Actually OpenWrt seems to be the only project using
this binding and it always appends DTB to kernel. It has switched to the
non-deprecated binding years ago.

Given there is close to zero chance this breaks anyone's setup it should
more than safe to drop this binding variant after 3 years.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 .../bindings/phy/bcm-ns-usb2-phy.yaml         | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

Comments

Conor Dooley Sept. 13, 2024, 6:24 p.m. UTC | #1 
On Fri, Sep 13, 2024 at 06:45:56AM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> The old binding variant (the one covering whole DMU block) was
> deprecated 3 years ago. Linux kernel was warning when using it for
> similar amount of time.
> 
> There aren't any known Northstar devices with bootloader providing DT to
> operating system. Actually OpenWrt seems to be the only project using
> this binding and it always appends DTB to kernel. It has switched to the
> non-deprecated binding years ago.
> 
> Given there is close to zero chance this breaks anyone's setup it should
> more than safe to drop this binding variant after 3 years.

I love a commit message like this.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Vinod Koul Oct. 22, 2024, 5:32 a.m. UTC | #2 
On Fri, 13 Sep 2024 06:45:56 +0200, Rafał Miłecki wrote:
> The old binding variant (the one covering whole DMU block) was
> deprecated 3 years ago. Linux kernel was warning when using it for
> similar amount of time.
> 
> There aren't any known Northstar devices with bootloader providing DT to
> operating system. Actually OpenWrt seems to be the only project using
> this binding and it always appends DTB to kernel. It has switched to the
> non-deprecated binding years ago.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: phy: bcm-ns-usb2-phy: drop deprecated variant
      commit: c3639d423d76c935b58827296a124e8f13d79b4b
[2/2] phy: bcm-ns-usb2: drop support for old binding variant
      commit: 0175a673e478eed99a86fc094e7d91ed2f3d5a34

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.yaml
index 426101530a21..d72c02ab55ae 100644
--- a/Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/bcm-ns-usb2-phy.yaml
@@ -18,16 +18,8 @@  properties:
     const: brcm,ns-usb2-phy
 
   reg:
-    anyOf:
-      - maxItems: 1
-        description: PHY control register
-      - maxItems: 1
-        description: iomem address range of DMU (Device Management Unit)
-        deprecated: true
-
-  reg-names:
-    items:
-      - const: dmu
+    maxItems: 1
+    description: PHY control register
 
   brcm,syscon-clkset:
     description: phandle to syscon for clkset register
@@ -50,12 +42,7 @@  required:
   - clocks
   - clock-names
   - "#phy-cells"
-
-oneOf:
-  - required:
-      - brcm,syscon-clkset
-  - required:
-      - reg-names
+  - brcm,syscon-clkset
 
 additionalProperties: false