| Message ID | 53ab1a4229410b9cbf7d11a125b98b2ecdeccd01.1726080141.git.echaudro@redhat.com |
|---|---|
| State | Accepted |
| Commit | 234e626198a4d99b6839061ca7e123f5c31c5ebe |
| Headers | show |
| Series | [ovs-dev] ci: Use previous sarif-tools release due to issue in latest release. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
Eelco Chaudron <echaudro@redhat.com> writes: > The just released v3.0 of the sarif tools do not work as > expected when comparing results. Temporarily force pip > to install the 2.0 release until this is fixes. > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> > --- Ugh.... LGTM Acked-by: Aaron Conole <aconole@redhat.com> > .ci/linux-prepare.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh > index 2a191b57f..5f8a1db6a 100755 > --- a/.ci/linux-prepare.sh > +++ b/.ci/linux-prepare.sh > @@ -23,7 +23,7 @@ cd .. > # https://github.com/pypa/pip/issues/10655 > pip3 install --disable-pip-version-check --user wheel > pip3 install --disable-pip-version-check --user \ > - flake8 netaddr pyparsing sarif-tools sphinx setuptools > + flake8 netaddr pyparsing sarif-tools==2.0.0 sphinx setuptools > > # Install python test dependencies > pip3 install -r python/test_requirements.txt
On Wed, Sep 11, 2024 at 08:42:21PM +0200, Eelco Chaudron wrote: > The just released v3.0 of the sarif tools do not work as > expected when comparing results. Temporarily force pip > to install the 2.0 release until this is fixes. > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> Acked-by: Simon Horman <horms@ovn.org> ...
On 11 Sep 2024, at 20:42, Eelco Chaudron wrote: > The just released v3.0 of the sarif tools do not work as > expected when comparing results. Temporarily force pip > to install the 2.0 release until this is fixes. > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> Thanks Aaron and Simon for the review. Patch applied.
diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh index 2a191b57f..5f8a1db6a 100755 --- a/.ci/linux-prepare.sh +++ b/.ci/linux-prepare.sh @@ -23,7 +23,7 @@ cd .. # https://github.com/pypa/pip/issues/10655 pip3 install --disable-pip-version-check --user wheel pip3 install --disable-pip-version-check --user \ - flake8 netaddr pyparsing sarif-tools sphinx setuptools + flake8 netaddr pyparsing sarif-tools==2.0.0 sphinx setuptools # Install python test dependencies pip3 install -r python/test_requirements.txt
The just released v3.0 of the sarif tools do not work as expected when comparing results. Temporarily force pip to install the 2.0 release until this is fixes. Signed-off-by: Eelco Chaudron <echaudro@redhat.com> --- .ci/linux-prepare.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)