diff mbox series

[ovs-dev] ovn-ctl: Add run_sb_relay_ovsdb subcommand.

Message ID 41E9B8B7-53B0-4BDC-A266-08D68039EFE4@gmail.com
State Accepted
Headers show
Series [ovs-dev] ovn-ctl: Add run_sb_relay_ovsdb subcommand. | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Michał Nasiadka Sept. 11, 2024, 10:50 a.m. UTC 
This patch adds missing subcommand for running SB Relay in foreground.

Signed-Off-By: Michal Nasiadka <mnasiadka@gmail.com>
---
 utilities/ovn-ctl | 8 ++++++++
 1 file changed, 8 insertions(+)

--
2.34.1

Comments

0-day Robot Sept. 11, 2024, 11:01 a.m. UTC | #1 
Bleep bloop.  Greetings Michał Nasiadka, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Michał Nasiadka <mnasiadka@gmail.com> needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Michal Nasiadka <mnasiadka@gmail.com>
Lines checked: 42, Warnings: 1, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
Michał Nasiadka Sept. 11, 2024, 11:19 a.m. UTC | #2 
This patch adds missing subcommand for running SB Relay in foreground.

Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com <mailto:mnasiadka@gmail.com>>
---
utilities/ovn-ctl | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
index d7ca9e758..c0b797273 100755
--- a/utilities/ovn-ctl
+++ b/utilities/ovn-ctl
@@ -499,6 +499,11 @@ run_sb_ovsdb() {
    start_sb_ovsdb
}

+run_sb_relay_ovsdb() {
+    DB_SB_RELAY_DETACH=no
+    start_sb_relay_ovsdb
+}
+
run_ic_nb_ovsdb() {
    DB_IC_NB_DETACH=no
    start_ic_nb_ovsdb
@@ -1469,6 +1474,9 @@ case $command in
    run_sb_ovsdb)
        run_sb_ovsdb
        ;;
+    run_sb_relay_ovsdb)
+        run_sb_relay_ovsdb
+        ;;
    run_ic_nb_ovsdb)
        run_ic_nb_ovsdb
        ;;
--
2.34.1

> On 11 Sep 2024, at 13:01, 0-day Robot <robot@bytheb.org> wrote:
> 
> Bleep bloop.  Greetings Michał Nasiadka, I am a robot and I have tried out your patch.
> Thanks for your contribution.
> 
> I encountered some error that I wasn't expecting.  See the details below.
> 
> 
> checkpatch:
> ERROR: Author Michał Nasiadka <mnasiadka@gmail.com> needs to sign off.
> WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Michal Nasiadka <mnasiadka@gmail.com>
> Lines checked: 42, Warnings: 1, Errors: 1
> 
> 
> Please check this out.  If you feel there has been an error, please email aconole@redhat.com
> 
> Thanks,
> 0-day Robot
Michał Nasiadka Sept. 11, 2024, 12:51 p.m. UTC | #3 
This patch adds missing subcommand for running SB Relay in foreground.

Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com <mailto:mnasiadka@gmail.com>>
---
utilities/ovn-ctl | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
index d7ca9e758..c0b797273 100755
--- a/utilities/ovn-ctl
+++ b/utilities/ovn-ctl
@@ -499,6 +499,11 @@ run_sb_ovsdb() {
    start_sb_ovsdb
}

+run_sb_relay_ovsdb() {
+    DB_SB_RELAY_DETACH=no
+    start_sb_relay_ovsdb
+}
+
run_ic_nb_ovsdb() {
    DB_IC_NB_DETACH=no
    start_ic_nb_ovsdb
@@ -1469,6 +1474,9 @@ case $command in
    run_sb_ovsdb)
        run_sb_ovsdb
        ;;
+    run_sb_relay_ovsdb)
+        run_sb_relay_ovsdb
+        ;;
    run_ic_nb_ovsdb)
        run_ic_nb_ovsdb
        ;;
--
2.34.1
Michał Nasiadka Sept. 12, 2024, 10:56 a.m. UTC | #4 
This patch adds missing subcommand for running SB Relay in foreground.

Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com <mailto:mnasiadka@gmail.com>>
---
utilities/ovn-ctl | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
index d7ca9e758..c0b797273 100755
--- a/utilities/ovn-ctl
+++ b/utilities/ovn-ctl
@@ -499,6 +499,11 @@ run_sb_ovsdb() {
    start_sb_ovsdb
}

+run_sb_relay_ovsdb() {
+    DB_SB_RELAY_DETACH=no
+    start_sb_relay_ovsdb
+}
+
run_ic_nb_ovsdb() {
    DB_IC_NB_DETACH=no
    start_ic_nb_ovsdb
@@ -1469,6 +1474,9 @@ case $command in
    run_sb_ovsdb)
        run_sb_ovsdb
        ;;
+    run_sb_relay_ovsdb)
+        run_sb_relay_ovsdb
+        ;;
    run_ic_nb_ovsdb)
        run_ic_nb_ovsdb
        ;;
--
2.34.1

> On 11 Sep 2024, at 14:51, Michał Nasiadka <mnasiadka@gmail.com> wrote:
> 
> This patch adds missing subcommand for running SB Relay in foreground.
> 
> Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com <mailto:mnasiadka@gmail.com>>
> ---
> utilities/ovn-ctl | 8 ++++++++
> 1 file changed, 8 insertions(+)
> 
> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
> index d7ca9e758..c0b797273 100755
> --- a/utilities/ovn-ctl
> +++ b/utilities/ovn-ctl
> @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>     start_sb_ovsdb
> }
> 
> +run_sb_relay_ovsdb() {
> +    DB_SB_RELAY_DETACH=no
> +    start_sb_relay_ovsdb
> +}
> +
> run_ic_nb_ovsdb() {
>     DB_IC_NB_DETACH=no
>     start_ic_nb_ovsdb
> @@ -1469,6 +1474,9 @@ case $command in
>     run_sb_ovsdb)
>         run_sb_ovsdb
>         ;;
> +    run_sb_relay_ovsdb)
> +        run_sb_relay_ovsdb
> +        ;;
>     run_ic_nb_ovsdb)
>         run_ic_nb_ovsdb
>         ;;
> --
> 2.34.1
Aaron Conole Sept. 27, 2024, 7:49 p.m. UTC | #5 
Michał Nasiadka <mnasiadka@gmail.com> writes:

> This patch adds missing subcommand for running SB Relay in foreground.
>
> Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com>
> ---

Seems these were done as top-post replied to the robot.  Was there any
reason why?

> utilities/ovn-ctl | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
> index d7ca9e758..c0b797273 100755
> --- a/utilities/ovn-ctl
> +++ b/utilities/ovn-ctl
> @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>     start_sb_ovsdb
> }
>
> +run_sb_relay_ovsdb() {
> +    DB_SB_RELAY_DETACH=no
> +    start_sb_relay_ovsdb
> +}
> +
> run_ic_nb_ovsdb() {
>     DB_IC_NB_DETACH=no
>     start_ic_nb_ovsdb
> @@ -1469,6 +1474,9 @@ case $command in
>     run_sb_ovsdb)
>         run_sb_ovsdb
>         ;;
> +    run_sb_relay_ovsdb)
> +        run_sb_relay_ovsdb
> +        ;;
>     run_ic_nb_ovsdb)
>         run_ic_nb_ovsdb
>         ;;
> --
> 2.34.1
>
>  On 11 Sep 2024, at 14:51, Michał Nasiadka <mnasiadka@gmail.com> wrote:
>
>  This patch adds missing subcommand for running SB Relay in foreground.
>
>  Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com>
>  ---
>  utilities/ovn-ctl | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
>  diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
>  index d7ca9e758..c0b797273 100755
>  --- a/utilities/ovn-ctl
>  +++ b/utilities/ovn-ctl
>  @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>      start_sb_ovsdb
>  }
>
>  +run_sb_relay_ovsdb() {
>  +    DB_SB_RELAY_DETACH=no
>  +    start_sb_relay_ovsdb
>  +}
>  +
>  run_ic_nb_ovsdb() {
>      DB_IC_NB_DETACH=no
>      start_ic_nb_ovsdb
>  @@ -1469,6 +1474,9 @@ case $command in
>      run_sb_ovsdb)
>          run_sb_ovsdb
>          ;;
>  +    run_sb_relay_ovsdb)
>  +        run_sb_relay_ovsdb
>  +        ;;
>      run_ic_nb_ovsdb)
>          run_ic_nb_ovsdb
>          ;;
>  --
>  2.34.1
Michał Nasiadka Oct. 9, 2024, 5:49 a.m. UTC | #6 
It was just my first patch and didn’t know what I should do with those robot posted failures (basically missing signed-off-by).
What should I do now to get that moved forward please?

Best regards,

Michal

> On 27 Sep 2024, at 21:49, Aaron Conole <aconole@redhat.com> wrote:
> 
> Michał Nasiadka <mnasiadka@gmail.com> writes:
> 
>> This patch adds missing subcommand for running SB Relay in foreground.
>> 
>> Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com>
>> ---
> 
> Seems these were done as top-post replied to the robot.  Was there any
> reason why?
> 
>> utilities/ovn-ctl | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>> 
>> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
>> index d7ca9e758..c0b797273 100755
>> --- a/utilities/ovn-ctl
>> +++ b/utilities/ovn-ctl
>> @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>>    start_sb_ovsdb
>> }
>> 
>> +run_sb_relay_ovsdb() {
>> +    DB_SB_RELAY_DETACH=no
>> +    start_sb_relay_ovsdb
>> +}
>> +
>> run_ic_nb_ovsdb() {
>>    DB_IC_NB_DETACH=no
>>    start_ic_nb_ovsdb
>> @@ -1469,6 +1474,9 @@ case $command in
>>    run_sb_ovsdb)
>>        run_sb_ovsdb
>>        ;;
>> +    run_sb_relay_ovsdb)
>> +        run_sb_relay_ovsdb
>> +        ;;
>>    run_ic_nb_ovsdb)
>>        run_ic_nb_ovsdb
>>        ;;
>> --
>> 2.34.1
>> 
>> On 11 Sep 2024, at 14:51, Michał Nasiadka <mnasiadka@gmail.com> wrote:
>> 
>> This patch adds missing subcommand for running SB Relay in foreground.
>> 
>> Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com>
>> ---
>> utilities/ovn-ctl | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>> 
>> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
>> index d7ca9e758..c0b797273 100755
>> --- a/utilities/ovn-ctl
>> +++ b/utilities/ovn-ctl
>> @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>>     start_sb_ovsdb
>> }
>> 
>> +run_sb_relay_ovsdb() {
>> +    DB_SB_RELAY_DETACH=no
>> +    start_sb_relay_ovsdb
>> +}
>> +
>> run_ic_nb_ovsdb() {
>>     DB_IC_NB_DETACH=no
>>     start_ic_nb_ovsdb
>> @@ -1469,6 +1474,9 @@ case $command in
>>     run_sb_ovsdb)
>>         run_sb_ovsdb
>>         ;;
>> +    run_sb_relay_ovsdb)
>> +        run_sb_relay_ovsdb
>> +        ;;
>>     run_ic_nb_ovsdb)
>>         run_ic_nb_ovsdb
>>         ;;
>> --
>> 2.34.1
>
Aaron Conole Oct. 10, 2024, 4:22 p.m. UTC | #7 
Michał Nasiadka <mnasiadka@gmail.com> writes:

> It was just my first patch and didn’t know what I should do with those
> robot posted failures (basically missing signed-off-by).
> What should I do now to get that moved forward please?

It would be best to repost (v2) with the correct signed-off-by line, I
think.  Replying with a new signoff will have patchwork include both.

But an OVN maintainer may have a different opinion.

> Best regards,
>
> Michal
>
>> On 27 Sep 2024, at 21:49, Aaron Conole <aconole@redhat.com> wrote:
>> 
>> Michał Nasiadka <mnasiadka@gmail.com> writes:
>> 
>>> This patch adds missing subcommand for running SB Relay in foreground.
>>> 
>>> Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com>
>>> ---
>> 
>> Seems these were done as top-post replied to the robot.  Was there any
>> reason why?
>> 
>>> utilities/ovn-ctl | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>> 
>>> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
>>> index d7ca9e758..c0b797273 100755
>>> --- a/utilities/ovn-ctl
>>> +++ b/utilities/ovn-ctl
>>> @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>>>    start_sb_ovsdb
>>> }
>>> 
>>> +run_sb_relay_ovsdb() {
>>> +    DB_SB_RELAY_DETACH=no
>>> +    start_sb_relay_ovsdb
>>> +}
>>> +
>>> run_ic_nb_ovsdb() {
>>>    DB_IC_NB_DETACH=no
>>>    start_ic_nb_ovsdb
>>> @@ -1469,6 +1474,9 @@ case $command in
>>>    run_sb_ovsdb)
>>>        run_sb_ovsdb
>>>        ;;
>>> +    run_sb_relay_ovsdb)
>>> +        run_sb_relay_ovsdb
>>> +        ;;
>>>    run_ic_nb_ovsdb)
>>>        run_ic_nb_ovsdb
>>>        ;;
>>> --
>>> 2.34.1
>>> 
>>> On 11 Sep 2024, at 14:51, Michał Nasiadka <mnasiadka@gmail.com> wrote:
>>> 
>>> This patch adds missing subcommand for running SB Relay in foreground.
>>> 
>>> Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com>
>>> ---
>>> utilities/ovn-ctl | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>> 
>>> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
>>> index d7ca9e758..c0b797273 100755
>>> --- a/utilities/ovn-ctl
>>> +++ b/utilities/ovn-ctl
>>> @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>>>     start_sb_ovsdb
>>> }
>>> 
>>> +run_sb_relay_ovsdb() {
>>> +    DB_SB_RELAY_DETACH=no
>>> +    start_sb_relay_ovsdb
>>> +}
>>> +
>>> run_ic_nb_ovsdb() {
>>>     DB_IC_NB_DETACH=no
>>>     start_ic_nb_ovsdb
>>> @@ -1469,6 +1474,9 @@ case $command in
>>>     run_sb_ovsdb)
>>>         run_sb_ovsdb
>>>         ;;
>>> +    run_sb_relay_ovsdb)
>>> +        run_sb_relay_ovsdb
>>> +        ;;
>>>     run_ic_nb_ovsdb)
>>>         run_ic_nb_ovsdb
>>>         ;;
>>> --
>>> 2.34.1
>>
Mark Michelson Oct. 16, 2024, 7:45 p.m. UTC | #8 
On 10/10/24 12:22, Aaron Conole wrote:
> Michał Nasiadka <mnasiadka@gmail.com> writes:
> 
>> It was just my first patch and didn’t know what I should do with those
>> robot posted failures (basically missing signed-off-by).
>> What should I do now to get that moved forward please?
> 
> It would be best to repost (v2) with the correct signed-off-by line, I
> think.  Replying with a new signoff will have patchwork include both.
> 
> But an OVN maintainer may have a different opinion.

Aaron is correct here. To send a new version, send a new email with "v2" 
in the subject line:

[PATCH ovn v2] ovn-ctl: Add run_sb_relay_ovsdb_subcommand

That's the typical way to get a new version of a patch posted, whether 
due to review comments or because the bot spots something that breaks 
guidelines.

Now, having said that, this is a small patch, so I think we can skip all 
that this time.

Acked-by: Mark Michelson <mmichels@redhat.com>

I'll make sure the sign-off is correct and get this merged. Thanks for 
contributing!

> 
>> Best regards,
>>
>> Michal
>>
>>> On 27 Sep 2024, at 21:49, Aaron Conole <aconole@redhat.com> wrote:
>>>
>>> Michał Nasiadka <mnasiadka@gmail.com> writes:
>>>
>>>> This patch adds missing subcommand for running SB Relay in foreground.
>>>>
>>>> Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com>
>>>> ---
>>>
>>> Seems these were done as top-post replied to the robot.  Was there any
>>> reason why?
>>>
>>>> utilities/ovn-ctl | 8 ++++++++
>>>> 1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
>>>> index d7ca9e758..c0b797273 100755
>>>> --- a/utilities/ovn-ctl
>>>> +++ b/utilities/ovn-ctl
>>>> @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>>>>     start_sb_ovsdb
>>>> }
>>>>
>>>> +run_sb_relay_ovsdb() {
>>>> +    DB_SB_RELAY_DETACH=no
>>>> +    start_sb_relay_ovsdb
>>>> +}
>>>> +
>>>> run_ic_nb_ovsdb() {
>>>>     DB_IC_NB_DETACH=no
>>>>     start_ic_nb_ovsdb
>>>> @@ -1469,6 +1474,9 @@ case $command in
>>>>     run_sb_ovsdb)
>>>>         run_sb_ovsdb
>>>>         ;;
>>>> +    run_sb_relay_ovsdb)
>>>> +        run_sb_relay_ovsdb
>>>> +        ;;
>>>>     run_ic_nb_ovsdb)
>>>>         run_ic_nb_ovsdb
>>>>         ;;
>>>> --
>>>> 2.34.1
>>>>
>>>> On 11 Sep 2024, at 14:51, Michał Nasiadka <mnasiadka@gmail.com> wrote:
>>>>
>>>> This patch adds missing subcommand for running SB Relay in foreground.
>>>>
>>>> Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com>
>>>> ---
>>>> utilities/ovn-ctl | 8 ++++++++
>>>> 1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
>>>> index d7ca9e758..c0b797273 100755
>>>> --- a/utilities/ovn-ctl
>>>> +++ b/utilities/ovn-ctl
>>>> @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>>>>      start_sb_ovsdb
>>>> }
>>>>
>>>> +run_sb_relay_ovsdb() {
>>>> +    DB_SB_RELAY_DETACH=no
>>>> +    start_sb_relay_ovsdb
>>>> +}
>>>> +
>>>> run_ic_nb_ovsdb() {
>>>>      DB_IC_NB_DETACH=no
>>>>      start_ic_nb_ovsdb
>>>> @@ -1469,6 +1474,9 @@ case $command in
>>>>      run_sb_ovsdb)
>>>>          run_sb_ovsdb
>>>>          ;;
>>>> +    run_sb_relay_ovsdb)
>>>> +        run_sb_relay_ovsdb
>>>> +        ;;
>>>>      run_ic_nb_ovsdb)
>>>>          run_ic_nb_ovsdb
>>>>          ;;
>>>> --
>>>> 2.34.1
>>>
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Mark Michelson Oct. 16, 2024, 8:05 p.m. UTC | #9 
On 10/16/24 15:45, Mark Michelson wrote:
> On 10/10/24 12:22, Aaron Conole wrote:
>> Michał Nasiadka <mnasiadka@gmail.com> writes:
>>
>>> It was just my first patch and didn’t know what I should do with those
>>> robot posted failures (basically missing signed-off-by).
>>> What should I do now to get that moved forward please?
>>
>> It would be best to repost (v2) with the correct signed-off-by line, I
>> think.  Replying with a new signoff will have patchwork include both.
>>
>> But an OVN maintainer may have a different opinion.
> 
> Aaron is correct here. To send a new version, send a new email with "v2" 
> in the subject line:
> 
> [PATCH ovn v2] ovn-ctl: Add run_sb_relay_ovsdb_subcommand
> 
> That's the typical way to get a new version of a patch posted, whether 
> due to review comments or because the bot spots something that breaks 
> guidelines.
> 
> Now, having said that, this is a small patch, so I think we can skip all 
> that this time.
> 
> Acked-by: Mark Michelson <mmichels@redhat.com>
> 
> I'll make sure the sign-off is correct and get this merged. Thanks for 
> contributing!
> 

I pushed this to main. Thanks again!

>>
>>> Best regards,
>>>
>>> Michal
>>>
>>>> On 27 Sep 2024, at 21:49, Aaron Conole <aconole@redhat.com> wrote:
>>>>
>>>> Michał Nasiadka <mnasiadka@gmail.com> writes:
>>>>
>>>>> This patch adds missing subcommand for running SB Relay in foreground.
>>>>>
>>>>> Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com>
>>>>> ---
>>>>
>>>> Seems these were done as top-post replied to the robot.  Was there any
>>>> reason why?
>>>>
>>>>> utilities/ovn-ctl | 8 ++++++++
>>>>> 1 file changed, 8 insertions(+)
>>>>>
>>>>> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
>>>>> index d7ca9e758..c0b797273 100755
>>>>> --- a/utilities/ovn-ctl
>>>>> +++ b/utilities/ovn-ctl
>>>>> @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>>>>>     start_sb_ovsdb
>>>>> }
>>>>>
>>>>> +run_sb_relay_ovsdb() {
>>>>> +    DB_SB_RELAY_DETACH=no
>>>>> +    start_sb_relay_ovsdb
>>>>> +}
>>>>> +
>>>>> run_ic_nb_ovsdb() {
>>>>>     DB_IC_NB_DETACH=no
>>>>>     start_ic_nb_ovsdb
>>>>> @@ -1469,6 +1474,9 @@ case $command in
>>>>>     run_sb_ovsdb)
>>>>>         run_sb_ovsdb
>>>>>         ;;
>>>>> +    run_sb_relay_ovsdb)
>>>>> +        run_sb_relay_ovsdb
>>>>> +        ;;
>>>>>     run_ic_nb_ovsdb)
>>>>>         run_ic_nb_ovsdb
>>>>>         ;;
>>>>> -- 
>>>>> 2.34.1
>>>>>
>>>>> On 11 Sep 2024, at 14:51, Michał Nasiadka <mnasiadka@gmail.com> wrote:
>>>>>
>>>>> This patch adds missing subcommand for running SB Relay in foreground.
>>>>>
>>>>> Signed-off-by: Michał Nasiadka <mnasiadka@gmail.com>
>>>>> ---
>>>>> utilities/ovn-ctl | 8 ++++++++
>>>>> 1 file changed, 8 insertions(+)
>>>>>
>>>>> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
>>>>> index d7ca9e758..c0b797273 100755
>>>>> --- a/utilities/ovn-ctl
>>>>> +++ b/utilities/ovn-ctl
>>>>> @@ -499,6 +499,11 @@ run_sb_ovsdb() {
>>>>>      start_sb_ovsdb
>>>>> }
>>>>>
>>>>> +run_sb_relay_ovsdb() {
>>>>> +    DB_SB_RELAY_DETACH=no
>>>>> +    start_sb_relay_ovsdb
>>>>> +}
>>>>> +
>>>>> run_ic_nb_ovsdb() {
>>>>>      DB_IC_NB_DETACH=no
>>>>>      start_ic_nb_ovsdb
>>>>> @@ -1469,6 +1474,9 @@ case $command in
>>>>>      run_sb_ovsdb)
>>>>>          run_sb_ovsdb
>>>>>          ;;
>>>>> +    run_sb_relay_ovsdb)
>>>>> +        run_sb_relay_ovsdb
>>>>> +        ;;
>>>>>      run_ic_nb_ovsdb)
>>>>>          run_ic_nb_ovsdb
>>>>>          ;;
>>>>> -- 
>>>>> 2.34.1
>>>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox series

Patch

diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
index d7ca9e758..c0b797273 100755
--- a/utilities/ovn-ctl
+++ b/utilities/ovn-ctl
@@ -499,6 +499,11 @@  run_sb_ovsdb() {
     start_sb_ovsdb
 }

+run_sb_relay_ovsdb() {
+    DB_SB_RELAY_DETACH=no
+    start_sb_relay_ovsdb
+}
+
 run_ic_nb_ovsdb() {
     DB_IC_NB_DETACH=no
     start_ic_nb_ovsdb
@@ -1469,6 +1474,9 @@  case $command in
     run_sb_ovsdb)
         run_sb_ovsdb
         ;;
+    run_sb_relay_ovsdb)
+        run_sb_relay_ovsdb
+        ;;
     run_ic_nb_ovsdb)
         run_ic_nb_ovsdb
         ;;