| Message ID | 20240906174932.772682-1-vinicius.peixoto@canonical.com |
|---|---|
| Headers | show |
| Series | net: mana: Fix RX buf alloc_size alignment and atomic op panic | expand |
On 06-09-2024 19:49, Vinicius Peixoto wrote: > BugLink: https://bugs.launchpad.net/bugs/2079854 > > [Impact] > > Microsoft has requested us to backport the following bugfix: > > 32316f676b4e ("net: mana: Fix RX buf alloc_size alignment and atomic op panic") > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=32316f676b4e > > [Fix] > > Clean-cherry pick to the trees (oracular/noble/jammy) containing the > following break commit: > 80f6215b450e ("net: mana: Add support for jumbo frame") > > [Test plan] > > Compile tested only. > > [Where problems could occur] > > This is a minor adjustment to the allocated size for MANA RX buffers, > fixing the alignment of the resulting SKB in order to improve performance > and avoid alignment faults during atomic operations on ARM64. As such, > the regression risk seems to be low (especially considering the allocated > size for the buffer will end up being bigger, not smaller), but any issues > here would impact the reception of network packets in MANA. > > [Other info] > > SF #00394982 > > Haiyang Zhang (1): > net: mana: Fix RX buf alloc_size alignment and atomic op panic > > drivers/net/ethernet/microsoft/mana/mana_en.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > v2 sent. -- Thibault
BugLink: https://bugs.launchpad.net/bugs/2079854 [Impact] Microsoft has requested us to backport the following bugfix: 32316f676b4e ("net: mana: Fix RX buf alloc_size alignment and atomic op panic") https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=32316f676b4e [Fix] Clean-cherry pick to the trees (oracular/noble/jammy) containing the following break commit: 80f6215b450e ("net: mana: Add support for jumbo frame") [Test plan] Compile tested only. [Where problems could occur] This is a minor adjustment to the allocated size for MANA RX buffers, fixing the alignment of the resulting SKB in order to improve performance and avoid alignment faults during atomic operations on ARM64. As such, the regression risk seems to be low (especially considering the allocated size for the buffer will end up being bigger, not smaller), but any issues here would impact the reception of network packets in MANA. [Other info] SF #00394982 Haiyang Zhang (1): net: mana: Fix RX buf alloc_size alignment and atomic op panic drivers/net/ethernet/microsoft/mana/mana_en.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)