| Message ID | 20240905201217.3815113-1-quic_nkela@quicinc.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v3] dt-bindings: firmware: arm,scmi: allow multiple virtual instances | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
> Subject: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple > virtual instances Just wonder, what do you mean virtual? Thanks, Peng. > > This change extends scmi node name so as to allow multiple virtual > SCMI instances. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> > --- > > Changes in v3: > - Added Reviewed-by tag > - Removed the patch from original series[1] > > Changes in v2: > - Fixed scmi nodename pattern > > [1]: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > lore.kernel.org%2Fall%2F20240903220240.2594102-1- > quic_nkela%40quicinc.com%2F&data=05%7C02%7Cpeng.fan%40nxp.c > om%7C350f57ac3042490bed0808dccde71b35%7C686ea1d3bc2b4c6f > a92cd99c5c301635%7C0%7C0%7C638611639683033003%7CUnknow > n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI > 6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=zYYNSdVovTG > h5BBUqW%2BRNyxoO7EXrUtTppk4MiywowU%3D&reserved=0 > --- > Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 54d7d11bfed4..5d79b15a1610 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -27,7 +27,7 @@ anyOf: > > properties: > $nodename: > - const: scmi > + pattern: '^scmi(-[0-9]+)?$' > > compatible: > oneOf: > -- > 2.34.1 >
On 9/5/2024 5:25 PM, Peng Fan wrote: >> Subject: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple >> virtual instances > Just wonder, what do you mean virtual? Just a term to indicate that these are different SCMI instances within the same OS. In one of the series from Cristian, he used the term 'virtual SCMI instances' so I used the same term here. Thanks, -Nikunj > > Thanks, > Peng. > >> This change extends scmi node name so as to allow multiple virtual >> SCMI instances. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> >> --- >> >> Changes in v3: >> - Added Reviewed-by tag >> - Removed the patch from original series[1] >> >> Changes in v2: >> - Fixed scmi nodename pattern >> >> [1]: >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F >> lore.kernel.org%2Fall%2F20240903220240.2594102-1- >> quic_nkela%40quicinc.com%2F&data=05%7C02%7Cpeng.fan%40nxp.c >> om%7C350f57ac3042490bed0808dccde71b35%7C686ea1d3bc2b4c6f >> a92cd99c5c301635%7C0%7C0%7C638611639683033003%7CUnknow >> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI >> 6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=zYYNSdVovTG >> h5BBUqW%2BRNyxoO7EXrUtTppk4MiywowU%3D&reserved=0 >> --- >> Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >> b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >> index 54d7d11bfed4..5d79b15a1610 100644 >> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >> @@ -27,7 +27,7 @@ anyOf: >> >> properties: >> $nodename: >> - const: scmi >> + pattern: '^scmi(-[0-9]+)?$' >> >> compatible: >> oneOf: >> -- >> 2.34.1 >>
On Thu, Sep 05, 2024 at 05:33:04PM -0700, Nikunj Kela wrote: > > On 9/5/2024 5:25 PM, Peng Fan wrote: > >> Subject: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple > >> virtual instances > > Just wonder, what do you mean virtual? > > Just a term to indicate that these are different SCMI instances within > the same OS. In one of the series from Cristian, he used the term > 'virtual SCMI instances' so I used the same term here. That's indeed confusing. Virtual means not a real thing... Best regards, Krzysztof
On 9/6/2024 12:32 AM, Krzysztof Kozlowski wrote: > On Thu, Sep 05, 2024 at 05:33:04PM -0700, Nikunj Kela wrote: >> On 9/5/2024 5:25 PM, Peng Fan wrote: >>>> Subject: [PATCH v3] dt-bindings: firmware: arm,scmi: allow multiple >>>> virtual instances >>> Just wonder, what do you mean virtual? >> Just a term to indicate that these are different SCMI instances within >> the same OS. In one of the series from Cristian, he used the term >> 'virtual SCMI instances' so I used the same term here. > That's indeed confusing. Virtual means not a real thing... IIUC, SCMI instance mean single instance within an OS however we are using multiple instances within single OS. That being said, happy to drop virtual if people find it confusing. I tried to use the same term which SCMI reviewer's patch series used. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml index 54d7d11bfed4..5d79b15a1610 100644 --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml @@ -27,7 +27,7 @@ anyOf: properties: $nodename: - const: scmi + pattern: '^scmi(-[0-9]+)?$' compatible: oneOf: