| Message ID | 20240905124432.834831-2-lanzano.alex@gmail.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | Add driver for Sharp Memory LCD | expand |
On 05/09/2024 14:43, Alex Lanzano wrote: > Add device tree bindings for the monochrome Sharp Memory LCD > > Co-developed-by: Mehdi Djait <mehdi.djait@bootlin.com> > Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com> > Signed-off-by: Alex Lanzano <lanzano.alex@gmail.com> I don't understand what happened here. Your process of handling patches is odd. Tags do not disappear, you had to remove them, right? So where is the explanation for this? Best regards, Krzysztof
On Thu, Sep 05, 2024 at 03:23:20PM GMT, Krzysztof Kozlowski wrote: > On 05/09/2024 14:43, Alex Lanzano wrote: > > Add device tree bindings for the monochrome Sharp Memory LCD > > > > Co-developed-by: Mehdi Djait <mehdi.djait@bootlin.com> > > Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com> > > Signed-off-by: Alex Lanzano <lanzano.alex@gmail.com> > > I don't understand what happened here. Your process of handling patches > is odd. Tags do not disappear, you had to remove them, right? So where > is the explanation for this? Whoops! My apologies for wasting time. Nothing changed in this patch I forgot to add in your reviewed-by tag.
On 05/09/2024 22:27, Alex Lanzano wrote: > On Thu, Sep 05, 2024 at 03:23:20PM GMT, Krzysztof Kozlowski wrote: >> On 05/09/2024 14:43, Alex Lanzano wrote: >>> Add device tree bindings for the monochrome Sharp Memory LCD >>> >>> Co-developed-by: Mehdi Djait <mehdi.djait@bootlin.com> >>> Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com> >>> Signed-off-by: Alex Lanzano <lanzano.alex@gmail.com> >> >> I don't understand what happened here. Your process of handling patches >> is odd. Tags do not disappear, you had to remove them, right? So where >> is the explanation for this? > > Whoops! My apologies for wasting time. Nothing changed in this patch > I forgot to add in your reviewed-by tag. Tag was there before, so you removed it... Best regards, Krzysztof
On Thu, Sep 05, 2024 at 11:12:47PM GMT, Krzysztof Kozlowski wrote: > On 05/09/2024 22:27, Alex Lanzano wrote: > > On Thu, Sep 05, 2024 at 03:23:20PM GMT, Krzysztof Kozlowski wrote: > >> On 05/09/2024 14:43, Alex Lanzano wrote: > >>> Add device tree bindings for the monochrome Sharp Memory LCD > >>> > >>> Co-developed-by: Mehdi Djait <mehdi.djait@bootlin.com> > >>> Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com> > >>> Signed-off-by: Alex Lanzano <lanzano.alex@gmail.com> > >> > >> I don't understand what happened here. Your process of handling patches > >> is odd. Tags do not disappear, you had to remove them, right? So where > >> is the explanation for this? > > > > Whoops! My apologies for wasting time. Nothing changed in this patch > > I forgot to add in your reviewed-by tag. > > Tag was there before, so you removed it... In prior versions I was manually adding the tag to the patch file. But I have since added it to the commit message like I should have from the beginning. Again, I apologize for any time wasted and appreciate the review.
diff --git a/Documentation/devicetree/bindings/display/sharp,ls010b7dh04.yaml b/Documentation/devicetree/bindings/display/sharp,ls010b7dh04.yaml new file mode 100644 index 000000000000..8097f091c2a5 --- /dev/null +++ b/Documentation/devicetree/bindings/display/sharp,ls010b7dh04.yaml @@ -0,0 +1,92 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/sharp,ls010b7dh04.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sharp Memory LCD panels + +maintainers: + - Alex Lanzano <lanzano.alex@gmail.com> + +description: + Sharp Memory LCDs are a series of monochrome displays that operate over + a SPI bus. The displays require a signal (VCOM) to be generated to prevent + DC bias build up resulting in pixels being unable to change. Three modes + can be used to provide the VCOM signal ("software", "external", "pwm"). + +properties: + compatible: + enum: + - sharp,ls010b7dh04 + - sharp,ls011b7dh03 + - sharp,ls012b7dd01 + - sharp,ls013b7dh03 + - sharp,ls013b7dh05 + - sharp,ls018b7dh02 + - sharp,ls027b7dh01 + - sharp,ls027b7dh01a + - sharp,ls032b7dd02 + - sharp,ls044q7dh01 + + reg: + maxItems: 1 + + spi-max-frequency: + maximum: 2000000 + + sharp,vcom-mode: + $ref: /schemas/types.yaml#/definitions/string + description: | + software - This mode relies on a software operation to send a + "maintain display" message to the display, toggling the vcom + bit on and off with each message + + external - This mode relies on an external clock to generate + the signal on the EXTCOMM pin + + pwm - This mode relies on a pwm device to generate the signal + on the EXTCOMM pin + + enum: [software, external, pwm] + + enable-gpios: true + + pwms: + maxItems: 1 + description: External VCOM signal + +required: + - compatible + - reg + - sharp,vcom-mode + +allOf: + - $ref: panel/panel-common.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + + - if: + properties: + sharp,vcom-mode: + const: pwm + then: + required: + - pwms + +unevaluatedProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + display@0 { + compatible = "sharp,ls013b7dh03"; + reg = <0>; + spi-cs-high; + spi-max-frequency = <1000000>; + sharp,vcom-mode = "software"; + }; + }; +...