| Message ID | 5a6c1e9a-0724-41b1-86d4-36335d3768ea@stanley.mountain |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [next] iommu/tegra241-cmdqv: Fix ioremap() error handling in probe() | expand |
On Wed, Sep 04, 2024 at 11:02:43AM +0300, Dan Carpenter wrote: > The ioremap() function doesn't return error pointers, it returns NULL > on error so update the error handling. Also just return directly > instead of calling iounmap() on the NULL pointer. Calling > iounmap(NULL) doesn't cause a problem on ARM but on other architectures > it can trigger a warning so it'a bad habbit. > > Fixes: 918eb5c856f6 ("iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com> Thanks!
On Wed, 04 Sep 2024 11:02:43 +0300, Dan Carpenter wrote: > The ioremap() function doesn't return error pointers, it returns NULL > on error so update the error handling. Also just return directly > instead of calling iounmap() on the NULL pointer. Calling > iounmap(NULL) doesn't cause a problem on ARM but on other architectures > it can trigger a warning so it'a bad habbit. > > > [...] Applied to will (for-joerg/arm-smmu/updates), thanks! [1/1] iommu/tegra241-cmdqv: Fix ioremap() error handling in probe() https://git.kernel.org/will/c/086a3c40ebd0 Cheers,
diff --git a/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c b/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c index 03fd13c21dcc..240b54192177 100644 --- a/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c +++ b/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c @@ -772,9 +772,9 @@ __tegra241_cmdqv_probe(struct arm_smmu_device *smmu, struct resource *res, static_assert(offsetof(struct tegra241_cmdqv, smmu) == 0); base = ioremap(res->start, resource_size(res)); - if (IS_ERR(base)) { - dev_err(smmu->dev, "failed to ioremap: %ld\n", PTR_ERR(base)); - goto iounmap; + if (!base) { + dev_err(smmu->dev, "failed to ioremap\n"); + return NULL; } regval = readl(base + TEGRA241_CMDQV_CONFIG);
The ioremap() function doesn't return error pointers, it returns NULL on error so update the error handling. Also just return directly instead of calling iounmap() on the NULL pointer. Calling iounmap(NULL) doesn't cause a problem on ARM but on other architectures it can trigger a warning so it'a bad habbit. Fixes: 918eb5c856f6 ("iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)