| Message ID | 1723534943-28499-1-git-send-email-hongxing.zhu@nxp.com |
|---|---|
| Headers | show |
| Series | Add dbi2 and atu for i.MX8M PCIe EP | expand |
On 13/08/2024 09:42, Richard Zhu wrote: > Add dbi2 and iatu reg for i.MX8MQ PCIe EP. > > For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the > driver. This method is not good. > > In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), > Frank suggests to fetch the dbi2 and atu from DT directly. This commit is > preparation to do that for i.MX8MQ PCIe EP. > > These changes wouldn't break driver function. When "dbi2" and "atu" > properties are present, i.MX PCIe driver would fetch the according base > addresses from DT directly. If only two reg properties are provided, i.MX > PCIe driver would fall back to the old method. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > Reviewed-by: Frank Li <Frank.Li@nxp.com> Stop adding fake tags. This never happened. If it happened, provide lore link. Best regards, Krzysztof
On 13/08/2024 10:54, Krzysztof Kozlowski wrote: > On 13/08/2024 09:42, Richard Zhu wrote: >> Add dbi2 and iatu reg for i.MX8MQ PCIe EP. >> >> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the >> driver. This method is not good. >> >> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), >> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is >> preparation to do that for i.MX8MQ PCIe EP. >> >> These changes wouldn't break driver function. When "dbi2" and "atu" >> properties are present, i.MX PCIe driver would fetch the according base >> addresses from DT directly. If only two reg properties are provided, i.MX >> PCIe driver would fall back to the old method. >> >> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> >> Reviewed-by: Frank Li <Frank.Li@nxp.com> > > Stop adding fake tags. This never happened. If it happened, provide lore > link. > Ah, my bad, now I see it. It's fine, sorry. Best regards, Krzysztof
On Tue, Aug 13, 2024 at 03:42:19PM +0800, Richard Zhu wrote: > v5 changes: > - Correct subject prefix. > > v4 changes: > - Add Frank's reviewed tag, and re-format the commit message. > > v3 changes: > - Refine the commit descriptions. > > v2 changes: > Thanks for Conor's comments. > - Place the new added properties at the end. > > Ideally, dbi2 and atu base addresses should be fetched from DT. > Add dbi2 and atu base addresses for i.MX8M PCIe EP here. > > [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" > [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ > [PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg for i.MX8MP > [PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu reg for i.MX8MM Applied 3 DTS patches, thanks!
On Sat, Aug 31, 2024 at 09:02:38PM +0800, Shawn Guo wrote: > On Tue, Aug 13, 2024 at 03:42:19PM +0800, Richard Zhu wrote: > > v5 changes: > > - Correct subject prefix. > > > > v4 changes: > > - Add Frank's reviewed tag, and re-format the commit message. > > > > v3 changes: > > - Refine the commit descriptions. > > > > v2 changes: > > Thanks for Conor's comments. > > - Place the new added properties at the end. > > > > Ideally, dbi2 and atu base addresses should be fetched from DT. > > Add dbi2 and atu base addresses for i.MX8M PCIe EP here. > > > > [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" > > [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ > > [PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg for i.MX8MP > > [PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu reg for i.MX8MM > > Applied 3 DTS patches, thanks! I have to take them out from my branch for now. Ping me when bindings change gets applied. Shawn