mbox series

[0/4] Simplify code with helper function devm_clk_get*()

Message ID 20240903080627.53652-1-zhangzekun11@huawei.com
Headers show
Series Simplify code with helper function devm_clk_get*() | expand

Message

Zhang Zekun Sept. 3, 2024, 8:06 a.m. UTC 
Use helper function devm_clk_get_enabled() and
devm_clk_get_optional_enabled() to simplify code.

Zhang Zekun (4):
  gpio: cadence: Use helper function devm_clk_get_enabled()
  gpio: lpc18xx: Use helper function devm_clk_get_enabled()
  gpio: mb86s7x: Use helper function devm_clk_get_enabled()
  gpio: xilinx: Use helper function devm_clk_get_enabled()

 drivers/gpio/gpio-cadence.c | 23 ++++++-----------------
 drivers/gpio/gpio-lpc18xx.c | 23 ++++++-----------------
 drivers/gpio/gpio-mb86s7x.c | 21 +++++++--------------
 drivers/gpio/gpio-xilinx.c  | 11 +----------
 4 files changed, 20 insertions(+), 58 deletions(-)

Comments

Bartosz Golaszewski Sept. 4, 2024, 8:01 a.m. UTC | #1 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Tue, 03 Sep 2024 16:06:23 +0800, Zhang Zekun wrote:
> Use helper function devm_clk_get_enabled() and
> devm_clk_get_optional_enabled() to simplify code.
> 
> Zhang Zekun (4):
>   gpio: cadence: Use helper function devm_clk_get_enabled()
>   gpio: lpc18xx: Use helper function devm_clk_get_enabled()
>   gpio: mb86s7x: Use helper function devm_clk_get_enabled()
>   gpio: xilinx: Use helper function devm_clk_get_enabled()
> 
> [...]

Applied, thanks!

[1/4] gpio: cadence: Use helper function devm_clk_get_enabled()
      commit: 7cea93092a28d3338e242b08f8ee5099c82c1cb6
[2/4] gpio: lpc18xx: Use helper function devm_clk_get_enabled()
      commit: c9e5cb9916fcf73ac8d2e0a1e35a9327bf0e347e
[3/4] gpio: mb86s7x: Use helper function devm_clk_get_enabled()
      commit: 1c927fb131fffea28a7ebe00220071d400a11d53
[4/4] gpio: xilinx: Use helper function devm_clk_get_enabled()
      commit: f8d5200bd59b9688f5f59ec8b1e06e8200dc4fda

Best regards,
Zhang Zekun Sept. 4, 2024, 8:44 a.m. UTC | #2 
Hi, Bartosz,

After receiving your ack email, I find out some mistakes in the
commit message. In commit messages of patch [3/4] and patch [4/4], 
devm_clk_get_enabled() should be replaced by 
devm_clk_get_optional_enabled(). Sorry for making these mistakes. I 
think I should send v2 to fix them.

Best Regards,
Zekun

在 2024/9/4 16:01, Bartosz Golaszewski 写道:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> 
> On Tue, 03 Sep 2024 16:06:23 +0800, Zhang Zekun wrote:
>> Use helper function devm_clk_get_enabled() and
>> devm_clk_get_optional_enabled() to simplify code.
>>
>> Zhang Zekun (4):
>>    gpio: cadence: Use helper function devm_clk_get_enabled()
>>    gpio: lpc18xx: Use helper function devm_clk_get_enabled()
>>    gpio: mb86s7x: Use helper function devm_clk_get_enabled()
>>    gpio: xilinx: Use helper function devm_clk_get_enabled()
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/4] gpio: cadence: Use helper function devm_clk_get_enabled()
>        commit: 7cea93092a28d3338e242b08f8ee5099c82c1cb6
> [2/4] gpio: lpc18xx: Use helper function devm_clk_get_enabled()
>        commit: c9e5cb9916fcf73ac8d2e0a1e35a9327bf0e347e
> [3/4] gpio: mb86s7x: Use helper function devm_clk_get_enabled()
>        commit: 1c927fb131fffea28a7ebe00220071d400a11d53
> [4/4] gpio: xilinx: Use helper function devm_clk_get_enabled()
>        commit: f8d5200bd59b9688f5f59ec8b1e06e8200dc4fda
> 
> Best regards,
Bartosz Golaszewski Sept. 4, 2024, 9:05 a.m. UTC | #3 
On Wed, Sep 4, 2024 at 10:44 AM zhangzekun (A) <zhangzekun11@huawei.com> wrote:
>
> Hi, Bartosz,
>
> After receiving your ack email, I find out some mistakes in the
> commit message. In commit messages of patch [3/4] and patch [4/4],
> devm_clk_get_enabled() should be replaced by
> devm_clk_get_optional_enabled(). Sorry for making these mistakes. I
> think I should send v2 to fix them.
>

Ok, I'll back them out.

Bart