| Message ID | 20240903152308.13565-4-detlev.casanova@collabora.com |
|---|---|
| State | Accepted |
| Delegated to: | Andi Shyti |
| Headers | show |
| Series | Add device tree for ArmSoM Sige 5 board | expand |
Hi, On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > Just like RK356x and RK3588, RK3576 is compatible to the existing > rk3399 binding. > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Heiko Stuebner <heiko@sntech.de> I will apply this after 1 and 2 have been merged. BTW, who is maintaining rockchip.yaml? Thanks, Andi > --- > Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > index 82b9d6682297..a9dae5b52f28 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > @@ -38,6 +38,7 @@ properties: > - rockchip,rk3308-i2c > - rockchip,rk3328-i2c > - rockchip,rk3568-i2c > + - rockchip,rk3576-i2c > - rockchip,rk3588-i2c > - rockchip,rv1126-i2c > - const: rockchip,rk3399-i2c > -- > 2.46.0 >
Hello, On Tuesday, 3 September 2024 11:46:00 EDT Andi Shyti wrote: > Hi, > > On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > > Just like RK356x and RK3588, RK3576 is compatible to the existing > > rk3399 binding. > > > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Acked-by: Heiko Stuebner <heiko@sntech.de> > > I will apply this after 1 and 2 have been merged. Sure, although it is not really dependent on 1 and 2. > BTW, who is maintaining rockchip.yaml? Heiko Stuebner is the maintainer of Rockchip SoC support. > Thanks, > Andi > > > --- > > > > Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > > b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml index > > 82b9d6682297..a9dae5b52f28 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > > +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > > > > @@ -38,6 +38,7 @@ properties: > > - rockchip,rk3308-i2c > > - rockchip,rk3328-i2c > > - rockchip,rk3568-i2c > > > > + - rockchip,rk3576-i2c > > > > - rockchip,rk3588-i2c > > - rockchip,rv1126-i2c > > > > - const: rockchip,rk3399-i2c
Hi, On Tue, Sep 03, 2024 at 11:59:34AM GMT, Detlev Casanova wrote: > On Tuesday, 3 September 2024 11:46:00 EDT Andi Shyti wrote: > > Hi, > > > > On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > > > Just like RK356x and RK3588, RK3576 is compatible to the existing > > > rk3399 binding. > > > > > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Acked-by: Heiko Stuebner <heiko@sntech.de> > > > > I will apply this after 1 and 2 have been merged. > > Sure, although it is not really dependent on 1 and 2. yes, but I want to be sure that everything is coming in. > > BTW, who is maintaining rockchip.yaml? > > Heiko Stuebner is the maintainer of Rockchip SoC support. I would guess so, but I think we should also add the entry to the maintainer's file :-) Thanks, Andi > > Thanks, > > Andi > > > > > --- > > > > > > Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > > > b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml index > > > 82b9d6682297..a9dae5b52f28 100644 > > > --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > > > +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > > > > > > @@ -38,6 +38,7 @@ properties: > > > - rockchip,rk3308-i2c > > > - rockchip,rk3328-i2c > > > - rockchip,rk3568-i2c > > > > > > + - rockchip,rk3576-i2c > > > > > > - rockchip,rk3588-i2c > > > - rockchip,rv1126-i2c > > > > > > - const: rockchip,rk3399-i2c > > > >
BTW, just as a self reminder, Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Thanks, Andi On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > Just like RK356x and RK3588, RK3576 is compatible to the existing > rk3399 binding. > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Heiko Stuebner <heiko@sntech.de> > --- > Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > index 82b9d6682297..a9dae5b52f28 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml > @@ -38,6 +38,7 @@ properties: > - rockchip,rk3308-i2c > - rockchip,rk3328-i2c > - rockchip,rk3568-i2c > + - rockchip,rk3576-i2c > - rockchip,rk3588-i2c > - rockchip,rv1126-i2c > - const: rockchip,rk3399-i2c > -- > 2.46.0 >
[remove a bunch of people from Cc] Hi, On Tue, Sep 03, 2024 at 06:47:17PM GMT, Andi Shyti wrote: > On Tue, Sep 03, 2024 at 11:59:34AM GMT, Detlev Casanova wrote: > > On Tuesday, 3 September 2024 11:46:00 EDT Andi Shyti wrote: > > > On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > > > > Just like RK356x and RK3588, RK3576 is compatible to the existing > > > > rk3399 binding. > > > > > > > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Acked-by: Heiko Stuebner <heiko@sntech.de> > > > > > > I will apply this after 1 and 2 have been merged. > > > > Sure, although it is not really dependent on 1 and 2. > > yes, but I want to be sure that everything is coming in. Why? Patch 1 is not even for RK3576 itself, but for a specific board. I would say the ordering is pretty much arbitrary for patches 1-7, so I2C could have been the first patch. (no pressure, I'm just trying to understand the rationale) Greetings, -- Sebastian
Am Dienstag, 3. September 2024, 18:47:17 CEST schrieb Andi Shyti: > On Tue, Sep 03, 2024 at 11:59:34AM GMT, Detlev Casanova wrote: > > On Tuesday, 3 September 2024 11:46:00 EDT Andi Shyti wrote: > > > Hi, > > > > > > On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > > > > Just like RK356x and RK3588, RK3576 is compatible to the existing > > > > rk3399 binding. > > > > > > > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Acked-by: Heiko Stuebner <heiko@sntech.de> > > > > > > I will apply this after 1 and 2 have been merged. > > > > Sure, although it is not really dependent on 1 and 2. > > yes, but I want to be sure that everything is coming in. > > > > BTW, who is maintaining rockchip.yaml? > > > > Heiko Stuebner is the maintainer of Rockchip SoC support. > > I would guess so, but I think we should also add the entry to > the maintainer's file :-) now you made me doubt the wildcards we have in place ;-) # scripts/get_maintainer.pl -f Documentation/devicetree/bindings/arm/rockchip.yaml [...] Heiko Stuebner <heiko@sntech.de> (maintainer:ARM/Rockchip SoC support) [...] linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) So Maintainers seems to be correct ... *phew* :-)
Hi Andi, Am Dienstag, 3. September 2024, 17:46:00 CEST schrieb Andi Shyti: > On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > > Just like RK356x and RK3588, RK3576 is compatible to the existing > > rk3399 binding. > > > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Acked-by: Heiko Stuebner <heiko@sntech.de> > > I will apply this after 1 and 2 have been merged. I picked patch 2 now. Patch 1 should go together with patch 9, but that will require the other binding additions from this series. So if you don't have reservations it would be cool if the i2c binding could get merged. The i2c controller is part of the rk3576 soc and it thankfully also is just the same as the rk356x + rk3588 soc variant as Detlev wrote in the binding. Thanks a lot Heiko
Hi, On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > Just like RK356x and RK3588, RK3576 is compatible to the existing > rk3399 binding. > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Heiko Stuebner <heiko@sntech.de> merged to i2c/i2c-host. Thanks, Andi
Hi Heiko, On Tue, Sep 03, 2024 at 11:59:12PM GMT, Heiko Stübner wrote: > Am Dienstag, 3. September 2024, 18:47:17 CEST schrieb Andi Shyti: > > On Tue, Sep 03, 2024 at 11:59:34AM GMT, Detlev Casanova wrote: > > > On Tuesday, 3 September 2024 11:46:00 EDT Andi Shyti wrote: > > > > Hi, > > > > > > > > On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > > > > > Just like RK356x and RK3588, RK3576 is compatible to the existing > > > > > rk3399 binding. > > > > > > > > > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > Acked-by: Heiko Stuebner <heiko@sntech.de> > > > > > > > > I will apply this after 1 and 2 have been merged. > > > > > > Sure, although it is not really dependent on 1 and 2. > > > > yes, but I want to be sure that everything is coming in. > > > > > > BTW, who is maintaining rockchip.yaml? > > > > > > Heiko Stuebner is the maintainer of Rockchip SoC support. > > > > I would guess so, but I think we should also add the entry to > > the maintainer's file :-) > > now you made me doubt the wildcards we have in place ;-) > > # scripts/get_maintainer.pl -f Documentation/devicetree/bindings/arm/rockchip.yaml > [...] > Heiko Stuebner <heiko@sntech.de> (maintainer:ARM/Rockchip SoC support) > [...] > linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) > > So Maintainers seems to be correct ... *phew* :-) Normally I check the MAINTAINERS file where the rockchip.yaml is not listed. There is an "N: rockchip" under your name, but having it explicitely stated wouldn't hurt (as it is in other arm/*yaml file. That's why I got confused at first. Anyway, sorry for the noise. Thanks, Andi
diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml index 82b9d6682297..a9dae5b52f28 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml @@ -38,6 +38,7 @@ properties: - rockchip,rk3308-i2c - rockchip,rk3328-i2c - rockchip,rk3568-i2c + - rockchip,rk3576-i2c - rockchip,rk3588-i2c - rockchip,rv1126-i2c - const: rockchip,rk3399-i2c