diff mbox series

[v1] netfilter: conntrack: Convert to use ERR_CAST()

Message ID 20240828110651.56431-1-shenlichuan@vivo.com
State Accepted
Headers show
Series [v1] netfilter: conntrack: Convert to use ERR_CAST() | expand

Commit Message

Shen Lichuan Aug. 28, 2024, 11:06 a.m. UTC 
Use the ERR_CAST macro to clearly indicate that this is a pointer 
to an error value and that a type conversion was performed.

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
 net/netfilter/nf_conntrack_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pablo Neira Ayuso Sept. 3, 2024, 8:43 a.m. UTC | #1 
On Wed, Aug 28, 2024 at 07:06:51PM +0800, Shen Lichuan wrote:
> Use the ERR_CAST macro to clearly indicate that this is a pointer 
> to an error value and that a type conversion was performed.

Applied, thanks
diff mbox series

Patch

diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
index 9384426ddc06..d3cb53b008f5 100644
--- a/net/netfilter/nf_conntrack_core.c
+++ b/net/netfilter/nf_conntrack_core.c
@@ -1722,7 +1722,7 @@  init_conntrack(struct net *net, struct nf_conn *tmpl,
 	ct = __nf_conntrack_alloc(net, zone, tuple, &repl_tuple, GFP_ATOMIC,
 				  hash);
 	if (IS_ERR(ct))
-		return (struct nf_conntrack_tuple_hash *)ct;
+		return ERR_CAST(ct);
 
 	if (!nf_ct_add_synproxy(ct, tmpl)) {
 		nf_conntrack_free(ct);