| Message ID | 20240725092209.1356085-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/lrzsz: drop bogus LRZSZ_POST_CONFIGURE_HOOKS | expand |
On Thu, 25 Jul 2024 11:22:09 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > As already done for LRZSZ_BUILD_HOOKS in commit > 5fde4abc8d67ac2317b1de7a1b4cde8091f4e3c7, drop bogus > LRZSZ_POST_CONFIGURE_HOOKS as this hook added in 2010 is also never > called > > Fixes: 4f3f291a3bfc1893cbfb4d9803c35a4f6752784d > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/lrzsz/lrzsz.mk | 5 ----- > 1 file changed, 5 deletions(-) Wow, amazing, this has been around unused since 2010, and we only notice 14 years later... I just fixed up the commit title: it's not really "bogus" but rather "unused", and applied. Thanks! Thomas
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > As already done for LRZSZ_BUILD_HOOKS in commit > 5fde4abc8d67ac2317b1de7a1b4cde8091f4e3c7, drop bogus > LRZSZ_POST_CONFIGURE_HOOKS as this hook added in 2010 is also never > called > Fixes: 4f3f291a3bfc1893cbfb4d9803c35a4f6752784d > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Committed to 2024.02.x and 2024.05.x, thanks.
diff --git a/package/lrzsz/lrzsz.mk b/package/lrzsz/lrzsz.mk index d9be23540e..7247a4bd59 100644 --- a/package/lrzsz/lrzsz.mk +++ b/package/lrzsz/lrzsz.mk @@ -13,11 +13,6 @@ LRZSZ_CPE_ID_VALID = YES LRZSZ_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) LRZSZ_CONF_ENV = LIBS=$(TARGET_NLS_LIBS) -define LRZSZ_POST_CONFIGURE_HOOKS - $(SED) "s/-lnsl//;" $(@D)/src/Makefile - $(SED) "s~\(#define ENABLE_SYSLOG.*\)~/* \1 */~;" $(@D)/config.h -endef - define LRZSZ_INSTALL_TARGET_CMDS $(INSTALL) -m 0755 -D $(@D)/src/lrz $(TARGET_DIR)/usr/bin/rz $(INSTALL) -m 0755 -D $(@D)/src/lsz $(TARGET_DIR)/usr/bin/sz
As already done for LRZSZ_BUILD_HOOKS in commit 5fde4abc8d67ac2317b1de7a1b4cde8091f4e3c7, drop bogus LRZSZ_POST_CONFIGURE_HOOKS as this hook added in 2010 is also never called Fixes: 4f3f291a3bfc1893cbfb4d9803c35a4f6752784d Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/lrzsz/lrzsz.mk | 5 ----- 1 file changed, 5 deletions(-)