| Message ID | 20240826102515.2774296-6-c-vankar@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Add support for Ethernet Boot on SK-AM62 | expand |
On 26/08/24 15:55, Chintan Vankar wrote: > Function "k3_ringacc_ring_reconfig_qmode_raw()" should reset qmode to > requested value and should not update other fields in ring configuration > register. > > Signed-off-by: Chintan Vankar <c-vankar@ti.com> > --- > Thanks for fix this up: Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com> > This patch is newely added in this series. > > drivers/soc/ti/k3-navss-ringacc-u-boot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/k3-navss-ringacc-u-boot.c b/drivers/soc/ti/k3-navss-ringacc-u-boot.c > index 2799f214c77..8227d8bc3e3 100644 > --- a/drivers/soc/ti/k3-navss-ringacc-u-boot.c > +++ b/drivers/soc/ti/k3-navss-ringacc-u-boot.c > @@ -42,7 +42,7 @@ static void k3_ringacc_ring_reconfig_qmode_raw(struct k3_nav_ring *ring, enum k3 > u32 val; > > val = readl(&ring->cfg->size); > - val &= KNAV_RINGACC_CFG_RING_SIZE_QMODE_MASK; > + val &= ~KNAV_RINGACC_CFG_RING_SIZE_QMODE_MASK; > val |= mode << KNAV_RINGACC_CFG_RING_SIZE_QMODE_SHIFT; > writel(val, &ring->cfg->size); > }
Hi! On Fri, 2024-08-30 at 20:29 +0530, Vignesh Raghavendra wrote: > On 26/08/24 15:55, Chintan Vankar wrote: > > Function "k3_ringacc_ring_reconfig_qmode_raw()" should reset qmode to > > requested value and should not update other fields in ring configuration > > register. > > > > Signed-off-by: Chintan Vankar <c-vankar@ti.com> > > --- > > > > Thanks for fix this up: > > > Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com> > Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com> > > This patch is newely added in this series. > > > > drivers/soc/ti/k3-navss-ringacc-u-boot.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/ti/k3-navss-ringacc-u-boot.c b/drivers/soc/ti/k3-navss-ringacc-u-boot.c > > index 2799f214c77..8227d8bc3e3 100644 > > --- a/drivers/soc/ti/k3-navss-ringacc-u-boot.c > > +++ b/drivers/soc/ti/k3-navss-ringacc-u-boot.c > > @@ -42,7 +42,7 @@ static void k3_ringacc_ring_reconfig_qmode_raw(struct k3_nav_ring *ring, enum k3 > > u32 val; > > > > val = readl(&ring->cfg->size); > > - val &= KNAV_RINGACC_CFG_RING_SIZE_QMODE_MASK; > > + val &= ~KNAV_RINGACC_CFG_RING_SIZE_QMODE_MASK; > > val |= mode << KNAV_RINGACC_CFG_RING_SIZE_QMODE_SHIFT; > > writel(val, &ring->cfg->size); > > }
diff --git a/drivers/soc/ti/k3-navss-ringacc-u-boot.c b/drivers/soc/ti/k3-navss-ringacc-u-boot.c index 2799f214c77..8227d8bc3e3 100644 --- a/drivers/soc/ti/k3-navss-ringacc-u-boot.c +++ b/drivers/soc/ti/k3-navss-ringacc-u-boot.c @@ -42,7 +42,7 @@ static void k3_ringacc_ring_reconfig_qmode_raw(struct k3_nav_ring *ring, enum k3 u32 val; val = readl(&ring->cfg->size); - val &= KNAV_RINGACC_CFG_RING_SIZE_QMODE_MASK; + val &= ~KNAV_RINGACC_CFG_RING_SIZE_QMODE_MASK; val |= mode << KNAV_RINGACC_CFG_RING_SIZE_QMODE_SHIFT; writel(val, &ring->cfg->size); }
Function "k3_ringacc_ring_reconfig_qmode_raw()" should reset qmode to requested value and should not update other fields in ring configuration register. Signed-off-by: Chintan Vankar <c-vankar@ti.com> --- This patch is newely added in this series. drivers/soc/ti/k3-navss-ringacc-u-boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)