diff mbox series

[V3,06/10] arc: Adjust dot-product backend patterns

Message ID 20240815084425.2519197-7-victor.donascimento@arm.com
State New
Headers show
Series optabs: Make all `*dot_prod_optab's modeled as conversions | expand

Commit Message

Victor Do Nascimento Aug. 15, 2024, 8:44 a.m. UTC
Following the migration of the dot_prod optab from a direct to a
conversion-type optab, ensure all back-end patterns incorporate the
second machine mode into pattern names.

gcc/ChangeLog:

	* config/arc/simdext.md (sdot_prodv2hi): Renamed to...
	(sdot_prodsiv2hi): ...this.
	(udot_prodv2hi): Renamed to...
	(udot_prodsiv2hi): ...this.
	(sdot_prodv4hi): Renamed to...
	(sdot_prodv2siv4hi): ...this.
	(udot_prodv4hi): Renamed to...
	(udot_prodv2siv4hi): ...this.
---
 gcc/config/arc/simdext.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Victor Do Nascimento Aug. 28, 2024, 3:12 p.m. UTC | #1
Hello,

Gentle reminder for this simple renaming patch :)

Thanks,
Victor

On 8/15/24 09:44, Victor Do Nascimento wrote:
> Following the migration of the dot_prod optab from a direct to a
> conversion-type optab, ensure all back-end patterns incorporate the
> second machine mode into pattern names.
> 
> gcc/ChangeLog:
> 
> 	* config/arc/simdext.md (sdot_prodv2hi): Renamed to...
> 	(sdot_prodsiv2hi): ...this.
> 	(udot_prodv2hi): Renamed to...
> 	(udot_prodsiv2hi): ...this.
> 	(sdot_prodv4hi): Renamed to...
> 	(sdot_prodv2siv4hi): ...this.
> 	(udot_prodv4hi): Renamed to...
> 	(udot_prodv2siv4hi): ...this.
> ---
>   gcc/config/arc/simdext.md | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/gcc/config/arc/simdext.md b/gcc/config/arc/simdext.md
> index 4e51a237c3a..0696f0abb70 100644
> --- a/gcc/config/arc/simdext.md
> +++ b/gcc/config/arc/simdext.md
> @@ -1643,7 +1643,7 @@ (define_insn "dmpyh<V_US_suffix>"
>   
>   ;; We can use dmac as well here.  To be investigated which version
>   ;; brings more.
> -(define_expand "sdot_prodv2hi"
> +(define_expand "sdot_prodsiv2hi"
>     [(match_operand:SI 0 "register_operand" "")
>      (match_operand:V2HI 1 "register_operand" "")
>      (match_operand:V2HI 2 "register_operand" "")
> @@ -1656,7 +1656,7 @@ (define_expand "sdot_prodv2hi"
>    DONE;
>   })
>   
> -(define_expand "udot_prodv2hi"
> +(define_expand "udot_prodsiv2hi"
>     [(match_operand:SI 0 "register_operand" "")
>      (match_operand:V2HI 1 "register_operand" "")
>      (match_operand:V2HI 2 "register_operand" "")
> @@ -1669,7 +1669,7 @@ (define_expand "udot_prodv2hi"
>    DONE;
>   })
>   
> -(define_expand "sdot_prodv4hi"
> +(define_expand "sdot_prodv2siv4hi"
>     [(match_operand:V2SI 0 "register_operand" "")
>      (match_operand:V4HI 1 "register_operand" "")
>      (match_operand:V4HI 2 "register_operand" "")
> @@ -1688,7 +1688,7 @@ (define_expand "sdot_prodv4hi"
>    DONE;
>   })
>   
> -(define_expand "udot_prodv4hi"
> +(define_expand "udot_prodv2siv4hi"
>     [(match_operand:V2SI 0 "register_operand" "")
>      (match_operand:V4HI 1 "register_operand" "")
>      (match_operand:V4HI 2 "register_operand" "")
Richard Sandiford Aug. 29, 2024, 5:14 p.m. UTC | #2
Victor Do Nascimento <victor.donascimento@arm.com> writes:
> Hello,
>
> Gentle reminder for this simple renaming patch :)

OK, thanks.

Richard

> Thanks,
> Victor
>
> On 8/15/24 09:44, Victor Do Nascimento wrote:
>> Following the migration of the dot_prod optab from a direct to a
>> conversion-type optab, ensure all back-end patterns incorporate the
>> second machine mode into pattern names.
>> 
>> gcc/ChangeLog:
>> 
>> 	* config/arc/simdext.md (sdot_prodv2hi): Renamed to...
>> 	(sdot_prodsiv2hi): ...this.
>> 	(udot_prodv2hi): Renamed to...
>> 	(udot_prodsiv2hi): ...this.
>> 	(sdot_prodv4hi): Renamed to...
>> 	(sdot_prodv2siv4hi): ...this.
>> 	(udot_prodv4hi): Renamed to...
>> 	(udot_prodv2siv4hi): ...this.
>> ---
>>   gcc/config/arc/simdext.md | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>> 
>> diff --git a/gcc/config/arc/simdext.md b/gcc/config/arc/simdext.md
>> index 4e51a237c3a..0696f0abb70 100644
>> --- a/gcc/config/arc/simdext.md
>> +++ b/gcc/config/arc/simdext.md
>> @@ -1643,7 +1643,7 @@ (define_insn "dmpyh<V_US_suffix>"
>>   
>>   ;; We can use dmac as well here.  To be investigated which version
>>   ;; brings more.
>> -(define_expand "sdot_prodv2hi"
>> +(define_expand "sdot_prodsiv2hi"
>>     [(match_operand:SI 0 "register_operand" "")
>>      (match_operand:V2HI 1 "register_operand" "")
>>      (match_operand:V2HI 2 "register_operand" "")
>> @@ -1656,7 +1656,7 @@ (define_expand "sdot_prodv2hi"
>>    DONE;
>>   })
>>   
>> -(define_expand "udot_prodv2hi"
>> +(define_expand "udot_prodsiv2hi"
>>     [(match_operand:SI 0 "register_operand" "")
>>      (match_operand:V2HI 1 "register_operand" "")
>>      (match_operand:V2HI 2 "register_operand" "")
>> @@ -1669,7 +1669,7 @@ (define_expand "udot_prodv2hi"
>>    DONE;
>>   })
>>   
>> -(define_expand "sdot_prodv4hi"
>> +(define_expand "sdot_prodv2siv4hi"
>>     [(match_operand:V2SI 0 "register_operand" "")
>>      (match_operand:V4HI 1 "register_operand" "")
>>      (match_operand:V4HI 2 "register_operand" "")
>> @@ -1688,7 +1688,7 @@ (define_expand "sdot_prodv4hi"
>>    DONE;
>>   })
>>   
>> -(define_expand "udot_prodv4hi"
>> +(define_expand "udot_prodv2siv4hi"
>>     [(match_operand:V2SI 0 "register_operand" "")
>>      (match_operand:V4HI 1 "register_operand" "")
>>      (match_operand:V4HI 2 "register_operand" "")
diff mbox series

Patch

diff --git a/gcc/config/arc/simdext.md b/gcc/config/arc/simdext.md
index 4e51a237c3a..0696f0abb70 100644
--- a/gcc/config/arc/simdext.md
+++ b/gcc/config/arc/simdext.md
@@ -1643,7 +1643,7 @@  (define_insn "dmpyh<V_US_suffix>"
 
 ;; We can use dmac as well here.  To be investigated which version
 ;; brings more.
-(define_expand "sdot_prodv2hi"
+(define_expand "sdot_prodsiv2hi"
   [(match_operand:SI 0 "register_operand" "")
    (match_operand:V2HI 1 "register_operand" "")
    (match_operand:V2HI 2 "register_operand" "")
@@ -1656,7 +1656,7 @@  (define_expand "sdot_prodv2hi"
  DONE;
 })
 
-(define_expand "udot_prodv2hi"
+(define_expand "udot_prodsiv2hi"
   [(match_operand:SI 0 "register_operand" "")
    (match_operand:V2HI 1 "register_operand" "")
    (match_operand:V2HI 2 "register_operand" "")
@@ -1669,7 +1669,7 @@  (define_expand "udot_prodv2hi"
  DONE;
 })
 
-(define_expand "sdot_prodv4hi"
+(define_expand "sdot_prodv2siv4hi"
   [(match_operand:V2SI 0 "register_operand" "")
    (match_operand:V4HI 1 "register_operand" "")
    (match_operand:V4HI 2 "register_operand" "")
@@ -1688,7 +1688,7 @@  (define_expand "sdot_prodv4hi"
  DONE;
 })
 
-(define_expand "udot_prodv4hi"
+(define_expand "udot_prodv2siv4hi"
   [(match_operand:V2SI 0 "register_operand" "")
    (match_operand:V4HI 1 "register_operand" "")
    (match_operand:V4HI 2 "register_operand" "")