| Message ID | 20240820055705.3922754-1-quic_varada@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable CPR for IPQ9574 | expand |
Quoting Varadarajan Narayanan (2024-08-19 22:57:03) > diff --git a/drivers/clk/qcom/gcc-ipq9574.c b/drivers/clk/qcom/gcc-ipq9574.c > index 80fc94d705a0..058cde71b202 100644 > --- a/drivers/clk/qcom/gcc-ipq9574.c > +++ b/drivers/clk/qcom/gcc-ipq9574.c > @@ -3997,6 +3997,43 @@ static struct clk_branch gcc_xo_div4_clk = { > }, > }; > > +static const struct freq_tbl ftbl_hmss_rbcpr_clk_src[] = { > + F(24000000, P_XO, 1, 0, 0), > + { } > +}; > + > +static struct clk_rcg2 rbcpr_clk_src = { > + .cmd_rcgr = 0x48044, > + .mnd_width = 0, > + .hid_width = 5, > + .parent_map = gcc_xo_map, > + .freq_tbl = ftbl_gp1_clk_src, > + .clkr.hw.init = &(struct clk_init_data){ Please mark these clk_init_data structures as const. > + .name = "rbcpr_clk_src", > + .parent_data = gcc_xo_gpll0_gpll4,
On Tue, Aug 20, 2024 at 11:27:04AM GMT, Varadarajan Narayanan wrote: > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > * Add thread, scaling factor, CPR descriptor defines to enable > CPR on IPQ9574. > > * Skip 'acc' usage since IPQ9574 does not have acc > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > v7: Add rangeuV vaues > Fix IRQ handler 'argument' > > v6: Rebase on top of Konrad's v15 > - https://lore.kernel.org/lkml/20240708-topic-cpr3h-v15-0-5bc8b8936489@linaro.org/T/ > > v5: Move the 'acc_desc' usage check to first patch > > v4: s/silver//, s/cprh/cpr4/ > Skip 'acc' related code as IPQ9574 does not have acc > > v3: Fix patch author > Included below information in cover letter > v2: Fix Signed-off-by order > Depends: > [1] https://lore.kernel.org/lkml/20230217-topic-cpr3h-v14-0-9fd23241493d@linaro.org/T/ > [2] https://github.com/quic-varada/cpr/commits/konrad/ > --- > drivers/pmdomain/qcom/cpr3.c | 142 ++++++++++++++++++++++++++++++++++- > 1 file changed, 140 insertions(+), 2 deletions(-) > > diff --git a/drivers/pmdomain/qcom/cpr3.c b/drivers/pmdomain/qcom/cpr3.c > index d594bc79be1c..51c8b5766ccd 100644 > --- a/drivers/pmdomain/qcom/cpr3.c > +++ b/drivers/pmdomain/qcom/cpr3.c > @@ -2461,7 +2597,7 @@ static int cpr_thread_init(struct cpr_drv *drv, int tid) > NULL, cpr_irq_handler, > IRQF_ONESHOT | > IRQF_TRIGGER_RISING, > - "cpr", drv); > + "cpr", thread); Unrelated change => separate patch. LGTM otherwise. > if (ret) > goto fail; > } > @@ -2544,7 +2680,8 @@ static int cpr_probe(struct platform_device *pdev) > desc = data->cpr_desc; > > /* CPRh disallows MEM-ACC access from the HLOS */ > - if (!(data->acc_desc || desc->cpr_type == CTRL_TYPE_CPRH)) > + if (!(data->acc_desc || desc->cpr_type == CTRL_TYPE_CPRH || > + of_device_is_compatible(dev->of_node, "qcom,ipq9574-cpr4"))) > return dev_err_probe(dev, -EINVAL, "Invalid ACC data\n"); > > drv = devm_kzalloc(dev, sizeof(*drv), GFP_KERNEL); > @@ -2694,6 +2831,7 @@ static void cpr_remove(struct platform_device *pdev) > } > > static const struct of_device_id cpr3_match_table[] = { > + { .compatible = "qcom,ipq9574-cpr4", .data = &ipq9574_cpr_acc_desc }, > { .compatible = "qcom,msm8998-cprh", .data = &msm8998_cpr_acc_desc }, > { .compatible = "qcom,sdm630-cprh", .data = &sdm630_cpr_acc_desc }, > { } > -- > 2.34.1 >
This series tries to enable CPR on IPQ9574 based on the drivers posted in [1] - Add support for Core Power Reduction v3, v4 and Hardened. dt_binding_check and dtbs_check passed. Depends: [1] https://lore.kernel.org/lkml/20240708-topic-cpr3h-v15-0-5bc8b8936489@linaro.org/T/ [2] https://lore.kernel.org/linux-arm-msm/20240703091651.2820236-10-quic_varada@quicinc.com/ v7: Remove RPMPD per https://lore.kernel.org/linux-arm-msm/iy3l3ybmvllqxtyqq7fifiokxaaedrs22davveel4ikjoqivdm@dinswoc52qpz/ Add rangeuV values Fix IRQ handler 'argument' v6: Update depends to Konrad's V15 Rebase on top of V15 Change 'acc_desc' check to accomodate v15 changes v5: This series tries to enable CPR on IPQ9574, that implements CPRv4. Since [1] is older, faced few minor issues. Those are addressed in [2]. Depends: [1] https://lore.kernel.org/lkml/20230217-topic-cpr3h-v14-0-9fd23241493d@linaro.org/T/ [2] https://github.com/quic-varada/cpr/tree/4de50be55a89eb29ab0d40d3fcfe9aa7a9ccf910 [3] https://lore.kernel.org/linux-arm-msm/20240703091651.2820236-10-quic_varada@quicinc.com/ Drop 'dt-bindings: opp: v2-qcom-level: Update minItems for oloop-vadj & cloop-vadj', the [3] dependency listed above. It should be squashed into [1] Add acc_desc is not NULL check in one more place in cpr_probe Update one commit message and add acked-by, reviewd-by v4: s/cprh/cpr4/ Create new match data for ipq9574 that includes genpd_names Update cloop-vadj & oloop-vadj with minItems v3: Fix patch authorship for 2 patches Include CPR3 file changes done to Konrad's patches in https://github.com/quic-varada/cpr/commits/konrad/ Change url for [2] to skip the cpr3 file changes v2: Fix Signed-off-by order in 2 patches Update constraints in qcom,cpr3.yaml Add rbcpr_clk_src registration Add Reviewed-by to one of the patches Not adding Acked-by as the file has changed Praveenkumar I (1): soc: qcom: cpr3: Add IPQ9574 definitions Varadarajan Narayanan (6): soc: qcom: cpr3: Fix 'acc_desc' usage cpufreq: qcom-nvmem: Add support for IPQ9574 dt-bindings: soc: qcom: cpr3: Add bindings for IPQ9574 dt-bindings: clock: Add CPR clock defines for IPQ9574 clk: qcom: gcc-ipq9574: Add CPR clock definition arm64: dts: qcom: ipq9574: Enable CPR .../bindings/soc/qcom/qcom,cpr3.yaml | 35 +++ arch/arm64/boot/dts/qcom/ipq9574.dtsi | 234 ++++++++++++++++-- drivers/clk/qcom/gcc-ipq9574.c | 39 +++ drivers/cpufreq/qcom-cpufreq-nvmem.c | 7 +- drivers/pmdomain/qcom/cpr3.c | 151 ++++++++++- include/dt-bindings/clock/qcom,ipq9574-gcc.h | 2 + 6 files changed, 445 insertions(+), 23 deletions(-)