| Message ID | 20240824141616.3139902-1-dario.binacchi@amarulasolutions.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] package/babeld: bump to version 1.10 | expand |
On Sat, 24 Aug 2024 16:16:16 +0200 Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > - Removed the disambiguation code: source-specific routing is no longer > supported for IPv4, and for IPv6 only on Linux 3.11 or later. > - Fixed an issue handling of retractions with no next hop, which caused > interoperability problems with BIRD. Thanks to Fabian Bläse. > - If skip-kernel-setup is set, we no longer disable the rp_filter, which > makes babeld work in containers. Thanks to Martin Weinelt. > > Fixes: > - http://autobuild.buildroot.org/results/2447060c86acf1bd8d6ee0bcf8f9b6adcdfc50c9 Hmm, sorry but why a version bump is needed to fix an issue about a tarball not being found? This is generally a sign that upstream is moving tarballs around after they are released, which means that at some point the issue will occur again with babeld 1.10. Could you check what happened with the babeld 1.9.2 tarball, perhaps by contacting upstream? (I mean of course we will want to update babeld to version 1.10, but this should be done separately than fixing the download issue) Thanks! Thomas
Hello Thomas, On Mon, Aug 26, 2024 at 6:45 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Sat, 24 Aug 2024 16:16:16 +0200 > Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > > > - Removed the disambiguation code: source-specific routing is no longer > > supported for IPv4, and for IPv6 only on Linux 3.11 or later. > > - Fixed an issue handling of retractions with no next hop, which caused > > interoperability problems with BIRD. Thanks to Fabian Bläse. > > - If skip-kernel-setup is set, we no longer disable the rp_filter, which > > makes babeld work in containers. Thanks to Martin Weinelt. > > > > Fixes: > > - http://autobuild.buildroot.org/results/2447060c86acf1bd8d6ee0bcf8f9b6adcdfc50c9 > > Hmm, sorry but why a version bump is needed to fix an issue about a > tarball not being found? > > This is generally a sign that upstream is moving tarballs around after > they are released, which means that at some point the issue will occur > again with babeld 1.10. > > Could you check what happened with the babeld 1.9.2 tarball, perhaps by > contacting upstream? This is the response from Juliusz Chroboczek, one of the maintainers of the project: ----------------------------------------------------------------------------------------------------- 1.9.2 was released in April 2020, it's over four years old. Some features were removed in 1.13, but there's really no reason to run anything older than 1.12.2. > What happened to it? It's been moved into the archive directory: https://www.irif.fr/~jch/software/files/old/ > If it won't be re-added, can I refer to https://github.com/jech/babeld > as the official source from which buildroot can download the current > and future versions? Yes, that's a good idea; even though I have misgivings about github, I'm not planning to move away anytime soon. Please use tagged versions rather than the master head. Thanks, -- Juliusz ----------------------------------------------------------------------------------------------------- So at this point, I can change the official repository from which to download version 1.9.2 and then proceed with a version bump. For now, I'll send the fix. Do you agree? Thanks and regards, Dario > > (I mean of course we will want to update babeld to version 1.10, but > this should be done separately than fixing the download issue) > > Thanks! > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com
Hello, On Tue, 27 Aug 2024 08:28:43 +0200 Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > This is the response from Juliusz Chroboczek, one of the maintainers of > the project: > > ----------------------------------------------------------------------------------------------------- > 1.9.2 was released in April 2020, it's over four years old. Some features > were removed in 1.13, but there's really no reason to run anything older > than 1.12.2. > > > What happened to it? > > It's been moved into the archive directory: > > https://www.irif.fr/~jch/software/files/old/ Please reply to him that moving files around breaks things for build systems and Linux distributions. It is _really_ not nice. > So at this point, I can change the official repository from which to download > version 1.9.2 and then proceed with a version bump. Yes, use the Github repo, at least it's stable. Another option is to drop the package entirely. It was added by Maxime Hadjinlian back in 2016, and Maxime is no longer using Buildroot. The last bump was done by Sergio Prado in 2020, and nobody touched the package since then, despite an active upstream. Nobody is associated to it in the DEVELOPERS file. Thanks! Thomas
diff --git a/package/babeld/babeld.hash b/package/babeld/babeld.hash index 2e0513efa010..846c21dd29c6 100644 --- a/package/babeld/babeld.hash +++ b/package/babeld/babeld.hash @@ -1,3 +1,3 @@ # Locally computed -sha256 154f00e0a8bf35d6ea9028886c3dc5c3c342dd1a367df55ef29a547b75867f07 babeld-1.9.2.tar.gz +sha256 a5f54a08322640e97399bf4d1411a34319e6e277fbb6fc4966f38a17d72a8dea babeld-1.10.tar.gz sha256 b415c41292cedef6c97b243609e50552887c29343566c639f23282d31efd2afd LICENCE diff --git a/package/babeld/babeld.mk b/package/babeld/babeld.mk index 785fa2bce9f1..8ec5d57d3f04 100644 --- a/package/babeld/babeld.mk +++ b/package/babeld/babeld.mk @@ -4,7 +4,7 @@ # ################################################################################ -BABELD_VERSION = 1.9.2 +BABELD_VERSION = 1.10 BABELD_SITE = http://www.pps.univ-paris-diderot.fr/~jch/software/files BABELD_LICENSE = MIT BABELD_LICENSE_FILES = LICENCE
- Removed the disambiguation code: source-specific routing is no longer supported for IPv4, and for IPv6 only on Linux 3.11 or later. - Fixed an issue handling of retractions with no next hop, which caused interoperability problems with BIRD. Thanks to Fabian Bläse. - If skip-kernel-setup is set, we no longer disable the rp_filter, which makes babeld work in containers. Thanks to Martin Weinelt. Fixes: - http://autobuild.buildroot.org/results/2447060c86acf1bd8d6ee0bcf8f9b6adcdfc50c9 Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- package/babeld/babeld.hash | 2 +- package/babeld/babeld.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)