diff mbox series

package/frotz: update package hash for verion 2.54

Message ID 20240824-frotz-v1-1-05b86b9e6038@gmx.net
State Not Applicable
Headers show
Series package/frotz: update package hash for verion 2.54 | expand

Commit Message

J. Neuschäfer Aug. 24, 2024, 9:11 p.m. UTC 
Recently, hash checks have been failing for frotz-2.54.tar.bz2.
Fortunately, the old version can still be downloaded from
sources.buildroot.org:

$ wget -q https://sources.buildroot.net/frotz/frotz-2.54.tar.bz2
$ sha256sum frotz-2.54.tar.bz2
bdf9131e6de49108c9f032200cea3cb4011e5ca0c9fbdbf5b0c05f7c56c81395  frotz-2.54.tar.bz2

Diffing the old and current unpacked tarballs shows that the change is benign
and appears to be due to a change in GitLab's tarball generation:

	diff -ru frotz-2.54/Makefile frotz-2.54-new/Makefile
	--- frotz-2.54/Makefile 2022-04-14 08:47:41.000000000 +0200
	+++ frotz-2.54-new/Makefile     2022-04-14 08:47:41.000000000 +0200
	@@ -261,7 +261,7 @@
	 GIT_DATE = $(shell git show -s --format=%ci)
	 else
	 GIT_HASH = 5a86de2f0799bde12699a0189ea12be8c96194a5
	-GIT_HASH_SHORT = 5a86de2
	+GIT_HASH_SHORT = 5a86de2f
	 GIT_DATE = 2022-04-13 23:47:41 -0700
	 endif
	 export CFLAGS

For comparison, the sources files in git[1] contain "GIT_HASH_SHORT =
$Format:%h$" etc., rather than an actual commit hash/date.

[1]: https://gitlab.com/DavidGriffith/frotz/-/blob/2.54/Makefile?ref_type=tags#L254

Fixes: http://autobuild.buildroot.net/results/077e4756e56903f094b935af4ee8829507e0c3de/
Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
---
 package/frotz/frotz.hash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 8bd00c16d8af2b4b620a0b2c136e6830b9d6b3a0
change-id: 20240824-frotz-b7c25d3ce8b2

Best regards,
--
J. Neuschäfer <j.neuschaefer@gmx.net>

Comments

Thomas Huth Aug. 25, 2024, 5:49 a.m. UTC | #1 
Am Sat, 24 Aug 2024 23:11:29 +0200
schrieb J. Neuschäfer <j.neuschaefer@gmx.net>:

> Recently, hash checks have been failing for frotz-2.54.tar.bz2.
> Fortunately, the old version can still be downloaded from
> sources.buildroot.org:
> 
> $ wget -q https://sources.buildroot.net/frotz/frotz-2.54.tar.bz2
> $ sha256sum frotz-2.54.tar.bz2
> bdf9131e6de49108c9f032200cea3cb4011e5ca0c9fbdbf5b0c05f7c56c81395  frotz-2.54.tar.bz2
> 
> Diffing the old and current unpacked tarballs shows that the change is benign
> and appears to be due to a change in GitLab's tarball generation:
> 
> 	diff -ru frotz-2.54/Makefile frotz-2.54-new/Makefile
> 	--- frotz-2.54/Makefile 2022-04-14 08:47:41.000000000 +0200
> 	+++ frotz-2.54-new/Makefile     2022-04-14 08:47:41.000000000 +0200
> 	@@ -261,7 +261,7 @@
> 	 GIT_DATE = $(shell git show -s --format=%ci)
> 	 else
> 	 GIT_HASH = 5a86de2f0799bde12699a0189ea12be8c96194a5
> 	-GIT_HASH_SHORT = 5a86de2
> 	+GIT_HASH_SHORT = 5a86de2f
> 	 GIT_DATE = 2022-04-13 23:47:41 -0700
> 	 endif
> 	 export CFLAGS

 Hi!

Thanks for your investigation! But since likely nobody beside me was using
this package, and I also don't need it anymore, I already suggested another
way of "fixing" this problem:

 https://gitlab.com/buildroot.org/buildroot/-/commit/ed2d440a08aba129a737705b2ac4231d

 Thomas
J. Neuschäfer Aug. 25, 2024, 1:43 p.m. UTC | #2 
On Sun, Aug 25, 2024 at 07:49:40AM +0200, Thomas Huth wrote:
> Am Sat, 24 Aug 2024 23:11:29 +0200
> schrieb J. Neuschäfer <j.neuschaefer@gmx.net>:
>
> > Recently, hash checks have been failing for frotz-2.54.tar.bz2.
> > Fortunately, the old version can still be downloaded from
> > sources.buildroot.org:
> >
> > $ wget -q https://sources.buildroot.net/frotz/frotz-2.54.tar.bz2
> > $ sha256sum frotz-2.54.tar.bz2
> > bdf9131e6de49108c9f032200cea3cb4011e5ca0c9fbdbf5b0c05f7c56c81395  frotz-2.54.tar.bz2
> >
> > Diffing the old and current unpacked tarballs shows that the change is benign
> > and appears to be due to a change in GitLab's tarball generation:
> >
> > 	diff -ru frotz-2.54/Makefile frotz-2.54-new/Makefile
> > 	--- frotz-2.54/Makefile 2022-04-14 08:47:41.000000000 +0200
> > 	+++ frotz-2.54-new/Makefile     2022-04-14 08:47:41.000000000 +0200
> > 	@@ -261,7 +261,7 @@
> > 	 GIT_DATE = $(shell git show -s --format=%ci)
> > 	 else
> > 	 GIT_HASH = 5a86de2f0799bde12699a0189ea12be8c96194a5
> > 	-GIT_HASH_SHORT = 5a86de2
> > 	+GIT_HASH_SHORT = 5a86de2f
> > 	 GIT_DATE = 2022-04-13 23:47:41 -0700
> > 	 endif
> > 	 export CFLAGS
>
>  Hi!
>
> Thanks for your investigation! But since likely nobody beside me was using
> this package, and I also don't need it anymore, I already suggested another
> way of "fixing" this problem:
>
>  https://gitlab.com/buildroot.org/buildroot/-/commit/ed2d440a08aba129a737705b2ac4231d

Ah, that's fine too.

Thanks
diff mbox series

Patch

diff --git a/package/frotz/frotz.hash b/package/frotz/frotz.hash
index 145aa3800f..5c7e2c85e6 100644
--- a/package/frotz/frotz.hash
+++ b/package/frotz/frotz.hash
@@ -1,3 +1,3 @@ 
 # Locally calculated
-sha256  bdf9131e6de49108c9f032200cea3cb4011e5ca0c9fbdbf5b0c05f7c56c81395  frotz-2.54.tar.bz2
+sha256  756d7e11370c9c8e61573e350e2a5071e77fd2781be74c107bd432f817f3abc7  frotz-2.54.tar.bz2
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING