| Message ID | 20240819092850.1590758-2-ryan_chen@aspeedtech.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Andi Shyti |
| Headers | show |
| Series | Add ASPEED AST2600 I2Cv2 controller driver | expand |
On 19/08/2024 11:28, Ryan Chen wrote: > Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,enable-dma > and description for ast2600-i2cv2. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org> ?!? What happened here? Why are you amending tags?!? That's not allowed. You cannot change received tags, change people names or their data! And how is it even possible, srsly, how do you even work with git? Git would never do it, so you had to do it on purpose via some weird workflow. Best regards, Krzysztof
> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for > AST2600-i2cv2 > > On 19/08/2024 11:28, Ryan Chen wrote: > > Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,enable-dma > > and description for ast2600-i2cv2. > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org> > > ?!? > > What happened here? Why are you amending tags?!? That's not allowed. You > cannot change received tags, change people names or their data! And how is it > even possible, srsly, how do you even work with git? Git would never do it, so > you had to do it on purpose via some weird workflow. > Sorry, I don't know Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> is you or not. Or should I still keep Krzysztof Kozlowski <krzk+dt@kernel.org>? https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777768-2-ryan_chen@aspeedtech.com/ > Best regards, > Krzysztof
On 20/08/2024 03:29, Ryan Chen wrote: >> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for >> AST2600-i2cv2 >> >> On 19/08/2024 11:28, Ryan Chen wrote: >>> Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,enable-dma >>> and description for ast2600-i2cv2. >>> >>> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> >>> Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org> >> >> ?!? >> >> What happened here? Why are you amending tags?!? That's not allowed. You >> cannot change received tags, change people names or their data! And how is it >> even possible, srsly, how do you even work with git? Git would never do it, so >> you had to do it on purpose via some weird workflow. >> > Sorry, I don't know Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> is you or not. > Or should I still keep Krzysztof Kozlowski <krzk+dt@kernel.org>? > > https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777768-2-ryan_chen@aspeedtech.com/ Here is the tag you received. You added it in v12. Why did you change the tag suddenly to something else? Do you understand that you are not allowed to change people tags? I have doubts if you ask about people's identities, which is entirely irrelevant. Best regards, Krzysztof
> >> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for > >> AST2600-i2cv2 > >> > >> On 19/08/2024 11:28, Ryan Chen wrote: > >>> Add ast2600-i2cv2 compatible and aspeed,global-regs, > >>> aspeed,enable-dma and description for ast2600-i2cv2. > >>> > >>> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > >>> Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org> > >> > >> ?!? > >> > >> What happened here? Why are you amending tags?!? That's not allowed. > >> You cannot change received tags, change people names or their data! > >> And how is it even possible, srsly, how do you even work with git? > >> Git would never do it, so you had to do it on purpose via some weird > workflow. > >> > > Sorry, I don't know Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> is > you or not. > > Or should I still keep Krzysztof Kozlowski <krzk+dt@kernel.org>? > > > > https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777 > > 768-2-ryan_chen@aspeedtech.com/ > > Here is the tag you received. You added it in v12. > > Why did you change the tag suddenly to something else? > > Do you understand that you are not allowed to change people tags? I have > doubts if you ask about people's identities, which is entirely irrelevant. > Sorry, I am not understood. https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777768-2-ryan_chen@aspeedtech.com/ Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> at v10 So, what should I do now at v13?? > Best regards, > Krzysztof
On 20/08/2024 08:50, Ryan Chen wrote: >>>> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for >>>> AST2600-i2cv2 >>>> >>>> On 19/08/2024 11:28, Ryan Chen wrote: >>>>> Add ast2600-i2cv2 compatible and aspeed,global-regs, >>>>> aspeed,enable-dma and description for ast2600-i2cv2. >>>>> >>>>> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> >>>>> Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org> >>>> >>>> ?!? >>>> >>>> What happened here? Why are you amending tags?!? That's not allowed. >>>> You cannot change received tags, change people names or their data! >>>> And how is it even possible, srsly, how do you even work with git? >>>> Git would never do it, so you had to do it on purpose via some weird >> workflow. >>>> >>> Sorry, I don't know Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> is >> you or not. >>> Or should I still keep Krzysztof Kozlowski <krzk+dt@kernel.org>? >>> >>> https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777 >>> 768-2-ryan_chen@aspeedtech.com/ >> >> Here is the tag you received. You added it in v12. >> >> Why did you change the tag suddenly to something else? >> >> Do you understand that you are not allowed to change people tags? I have >> doubts if you ask about people's identities, which is entirely irrelevant. >> > Sorry, I am not understood. I don't know how to say this simpler that you are not allowed to change tags. You receive tag, use b4 to apply it or add it manually. Do not alter it. Do not change it. Do not add things there. Do not remove parts of it. Tag is as is. You only copy and paste. Is this understood now? > https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777768-2-ryan_chen@aspeedtech.com/ > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> at v10 > So, what should I do now at v13?? Fix your workflow and go back to previous version which had correct tag. And answer - why did you decide to change it? Best regards, Krzysztof
> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for > AST2600-i2cv2 > > On 20/08/2024 08:50, Ryan Chen wrote: > >>>> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for > >>>> AST2600-i2cv2 > >>>> > >>>> On 19/08/2024 11:28, Ryan Chen wrote: > >>>>> Add ast2600-i2cv2 compatible and aspeed,global-regs, > >>>>> aspeed,enable-dma and description for ast2600-i2cv2. > >>>>> > >>>>> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > >>>>> Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org> > >>>> > >>>> ?!? > >>>> > >>>> What happened here? Why are you amending tags?!? That's not > allowed. > >>>> You cannot change received tags, change people names or their data! > >>>> And how is it even possible, srsly, how do you even work with git? > >>>> Git would never do it, so you had to do it on purpose via some > >>>> weird > >> workflow. > >>>> > >>> Sorry, I don't know Krzysztof Kozlowski > >>> <krzysztof.kozlowski@linaro.org> is > >> you or not. > >>> Or should I still keep Krzysztof Kozlowski <krzk+dt@kernel.org>? > >>> > >>> https://patches.linaro.org/project/linux-i2c/patch/20230415012848.17 > >>> 77 > >>> 768-2-ryan_chen@aspeedtech.com/ > >> > >> Here is the tag you received. You added it in v12. > >> > >> Why did you change the tag suddenly to something else? > >> > >> Do you understand that you are not allowed to change people tags? I > >> have doubts if you ask about people's identities, which is entirely irrelevant. > >> > > Sorry, I am not understood. > > I don't know how to say this simpler that you are not allowed to change tags. > > You receive tag, use b4 to apply it or add it manually. Do not alter it. > Do not change it. Do not add things there. Do not remove parts of it. > > Tag is as is. You only copy and paste. > > Is this understood now? > > > > > https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777 > > 768-2-ryan_chen@aspeedtech.com/ > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> at > > v10 So, what should I do now at v13?? > > Fix your workflow and go back to previous version which had correct tag. > And answer - why did you decide to change it? > Sorry, I understand the tag means now. It should keep original review-by tag. And send v14. > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml index 6df27b47b922..6c16fc76c978 100644 --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml @@ -9,9 +9,6 @@ title: ASPEED I2C on the AST24XX, AST25XX, and AST26XX SoCs maintainers: - Rayn Chen <rayn_chen@aspeedtech.com> -allOf: - - $ref: /schemas/i2c/i2c-controller.yaml# - properties: compatible: enum: @@ -49,12 +46,50 @@ properties: description: states that there is another master active on this bus + aspeed,enable-dma: + type: boolean + description: | + I2C bus enable dma mode transfer. + + ASPEED ast2600 platform equipped with 16 I2C controllers that share a + single DMA engine. DTS files can specify the data transfer mode to/from + the device, either DMA or programmed I/O. However, hardware limitations + may require a DTS to manually allocate which controller can use DMA mode. + The "aspeed,enable-dma" property allows control of this. + + In cases where one the hardware design results in a specific + controller handling a larger amount of data, a DTS would likely + enable DMA mode for that one controller. + + aspeed,global-regs: + $ref: /schemas/types.yaml#/definitions/phandle + description: The phandle of i2c global register node. + required: - reg - compatible - clocks - resets +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + - if: + properties: + compatible: + contains: + const: aspeed,ast2600-i2cv2 + + then: + properties: + reg: + minItems: 2 + required: + - aspeed,global-regs + else: + properties: + aspeed,global-regs: false + aspeed,enable-dma: false + unevaluatedProperties: false examples: @@ -71,3 +106,13 @@ examples: interrupts = <0>; interrupt-parent = <&i2c_ic>; }; + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + i2c1: i2c@80 { + compatible = "aspeed,ast2600-i2cv2"; + reg = <0x80 0x80>, <0xc00 0x20>; + aspeed,global-regs = <&i2c_global>; + clocks = <&syscon ASPEED_CLK_APB>; + resets = <&syscon ASPEED_RESET_I2C>; + interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>; + };